💬 ajtowns commented on issue "RFC: Bitcoin Core Node `BlockTemplateManager`":
(https://github.com/bitcoin/bitcoin/issues/33389#issuecomment-3295505510)
> [net: Provide block templates to peers on request #33191](https://github.com/bitcoin/bitcoin/pull/33191) will also fit in nicely; see: [ismaelsadeeq@10bd892](https://github.com/ismaelsadeeq/bitcoin/commit/10bd8920fd259aa47d4b96037a2302d7ae6ea41f)

I don't understand this -- peer template sharing seems a really bad fit for a template manager for three reasons:

* the shared templates are probably oversized (2MvB instead of 1MvB) so aren't directly useful to reuse in other contexts (and would b
...

🤔 w0xlt reviewed a pull request: "log: always print initial signature verification state"
(https://github.com/bitcoin/bitcoin/pull/33336#pullrequestreview-3227507782)
reACK https://github.com/bitcoin/bitcoin/pull/33336/commits/9b04e4f96200daf7516d1b8b6b0dfc4c077837e8

🤔 w0xlt reviewed a pull request: "coins: warn on oversized `-dbcache`"
(https://github.com/bitcoin/bitcoin/pull/33333#pullrequestreview-3227651723)
ACK https://github.com/bitcoin/bitcoin/pull/33333/commits/13fa0d0a433722f294854001b0561c079db12dbc

BSD operating system support can be a follow-up.

💬 fanquake commented on pull request "key: use static context for libsecp256k1 calls where applicable":
(https://github.com/bitcoin/bitcoin/pull/33399#issuecomment-3296148168)
cc @jonasnick @real-or-random

💬 rkrux commented on pull request "wallet/rpc: fix listdescriptors RPC fails to return descriptors with private key information when wallet contains descriptors missing any key":
(https://github.com/bitcoin/bitcoin/pull/32471#discussion_r2351213344)
`has_priv_key` is used only for `PRIVATE` type, consider the following that limits its usage to avoid it being considered a misnomer - related unit/functional tests pass.

```diff
diff --git a/src/script/descriptor.cpp b/src/script/descriptor.cpp
index f29e73e2e6..ef977a5912 100644
--- a/src/script/descriptor.cpp
+++ b/src/script/descriptor.cpp
@@ -891,7 +891,7 @@ public:
std::string tmp;
bool subscript_res{scriptarg->ToStringHelper(arg, tmp, type, cache)};

...

💬 real-or-random commented on pull request "key: use static context for libsecp256k1 calls where applicable":
(https://github.com/bitcoin/bitcoin/pull/33399#issuecomment-3296261604)
> I don't claim to fully understand when the state is needed and when a static can be used.

Whenever the generator point G is multiplied by a secret scalar. Or, roughly speaking, whenever a secret key is involved, i.e., key generation or signing. The exceptions to this rule are the computation of the shared secret in ECDH and EllSwift.

> And would it make sense to rename the old `secp256k1_context_sign` references while we're here?

I'm not sure. `SECP256K1_CONTEXT_SIGN` was deprecated,
...

🤔 real-or-random reviewed a pull request: "key: use static context for libsecp256k1 calls where applicable"
(https://github.com/bitcoin/bitcoin/pull/33399#pullrequestreview-3228076799)
Concept ACK

💬 musaHaruna commented on issue "wallet RPC to double-check the calculated balance":
(https://github.com/bitcoin/bitcoin/issues/28898#issuecomment-3296357283)
Hi everyone,

I’ve opened PR #[28930](https://github.com/bitcoin/bitcoin/pull/33392) that attempts to resolve the issue.

The PR adds a scan_utxoset flag to getbalance / getbalances that lets the wallet independently compute a balance by scanning the UTXO set. If a discrepancy is found, the RPC response includes both balances plus a suggested action (rescanblockchain or reimporting descriptors with the correct timestamp).

This doesn’t replace rescanning — it’s a diagnostic check so users can de
...

💬 ajtowns commented on pull request "net: Provide block templates to peers on request":
(https://github.com/bitcoin/bitcoin/pull/33191#issuecomment-3296407130)
Dropped the code to use our own prior templates for compact block reconstruction to keep this patchset simple.

💬 Sjors commented on pull request "wallet: warn against accidental unsafe older() import":
(https://github.com/bitcoin/bitcoin/pull/33135#discussion_r2351335279)
That doesn't really say much, because indirect includes will succeed but we try to avoid those. Though maybe not for std stuff?

💬 yuvicc commented on issue "v30.0 Testing":
(https://github.com/bitcoin/bitcoin/issues/33368#issuecomment-3296474933)
- I have upgraded the version of my nodes from v29.1 -> v30.0rc1, everything looks stable till now.
- Successfully ran the [testing guide](https://github.com/bitcoin-core/bitcoin-devwiki/wiki/30.0-Release-Candidate-Testing-Guide) on Ubuntu 24.04 and macOS 15.2.

💬 vasild commented on pull request "net: do not apply whitelist permissions to onion inbounds":
(https://github.com/bitcoin/bitcoin/pull/33395#discussion_r2351406219)
Previously `AddWhitelistPermissionFlags()` would have been called for incoming tor connections. It does this:

```cpp
void CConnman::AddWhitelistPermissionFlags(NetPermissionFlags& flags, const CNetAddr &addr, const std::vector<NetWhitelistPermissions>& ranges) const {
for (const auto& subnet : ranges) {
if (subnet.m_subnet.Match(addr)) {
NetPermissions::AddFlag(flags, subnet.m_flags);
}
}
if (NetPermissions::HasFlag(flags, NetPermissionFlags::Imp
...

💬 vasild commented on pull request "net: do not apply whitelist permissions to onion inbounds":
(https://github.com/bitcoin/bitcoin/pull/33395#discussion_r2351365803)
nit, this is just moving code around without modifying it, feel free to ignore; can be written shorter as:

```suggestion
const bool inbound_onion = std::ranges::find(m_onion_binds, addr_bind) != m_onion_binds.end();
```

💬 janb84 commented on pull request "doc: Add documentation explaining different build types":
(https://github.com/bitcoin/bitcoin/pull/33355#issuecomment-3296644767)
Please:
- remove the .claude folder and contents
- change pr description or remove the "How Bitcoin's Script Virtual Machine Works" document

As an additional note, please declare the usage of the AI, if applicable.

💬 fanquake commented on pull request "test: Prevent disk space warning during node_init_tests":
(https://github.com/bitcoin/bitcoin/pull/33391#issuecomment-3296722478)
Backported to 30.x in #33356.

👍 TheCharlatan approved a pull request: "multiprocess: Don't require bitcoin -m argument when IPC options are used"
(https://github.com/bitcoin/bitcoin/pull/33229#pullrequestreview-3228511746)
ACK f9685d6a1389938b0cceb31d9eef201ab3dd2e86

💬 optout21 commented on pull request "refactor: Fix typo and correct template parameter inconsistency":
(https://github.com/bitcoin/bitcoin/pull/33394#issuecomment-3296775924)
Concept NACK
Though the changes are reasonable, I don't think a typo fix in a variable name justifies a separate PR.

💬 jalateras commented on pull request "doc: Add documentation explaining different build types":
(https://github.com/bitcoin/bitcoin/pull/33355#issuecomment-3296807458)
@janb84

1. I have removed unrelated files
2. I have squashed and pushed
3. I have added an AI declaration in the PR

🤔 optout21 reviewed a pull request: "refactor: Fix typo and correct template parameter inconsistency"
(https://github.com/bitcoin/bitcoin/pull/33394#pullrequestreview-3228547436)
Concept NACK
Though the changes are reasonable, I don't think a typo fix in a variable name justifies a separate PR.

💬 TheCharlatan commented on pull request "doc: Add documentation explaining different build types":
(https://github.com/bitcoin/bitcoin/pull/33355#issuecomment-3296948637)
NACK

Besides reading heavily AI-generated, this information does not seem useful, since it does not describe concretely how to actually make use of any of our shipped build artefacts.