⚠️ fanquake opened an issue: "oss-fuzz: build failing"
(https://github.com/bitcoin/bitcoin/issues/33366)
https://oss-fuzz-build-logs.storage.googleapis.com/log-08166704-3ba3-406e-9e55-637c906d1fd2.txt:
```bash
C++ compiler .......................... Clang 22.0.0, /src/aflplusplus/afl-clang-fast++
<snip>
Step #3 - "compile-afl-address-x86_64": [100%] [32m [1mLinking CXX executable ../../../bin/fuzz [0m
Step #3 - "compile-afl-address-x86_64": `.text.asan.module_ctor.45' referenced in section `.init_array.1[asan.module_ctor.45]' of /tmp/lto-llvm-b064c1.o: defined in discarded section `.text.asan.modu
...
(https://github.com/bitcoin/bitcoin/issues/33366)
https://oss-fuzz-build-logs.storage.googleapis.com/log-08166704-3ba3-406e-9e55-637c906d1fd2.txt:
```bash
C++ compiler .......................... Clang 22.0.0, /src/aflplusplus/afl-clang-fast++
<snip>
Step #3 - "compile-afl-address-x86_64": [100%] [32m [1mLinking CXX executable ../../../bin/fuzz [0m
Step #3 - "compile-afl-address-x86_64": `.text.asan.module_ctor.45' referenced in section `.init_array.1[asan.module_ctor.45]' of /tmp/lto-llvm-b064c1.o: defined in discarded section `.text.asan.modu
...
✅ darosior closed a pull request: "script: return verification flag responsible for error upon validation failure"
(https://github.com/bitcoin/bitcoin/pull/33012)
(https://github.com/bitcoin/bitcoin/pull/33012)
💬 darosior commented on pull request "script: return verification flag responsible for error upon validation failure":
(https://github.com/bitcoin/bitcoin/pull/33012#issuecomment-3280825306)
There may be use cases for better reporting independently of reducing unconfirmed transactions validation time, but i'm not going to make a priority of working on those. Closing for now.
(https://github.com/bitcoin/bitcoin/pull/33012#issuecomment-3280825306)
There may be use cases for better reporting independently of reducing unconfirmed transactions validation time, but i'm not going to make a priority of working on those. Closing for now.
💬 darosior commented on pull request "p2p: stop special-casing witness-stripped error for unconfirmed transactions":
(https://github.com/bitcoin/bitcoin/pull/32379#issuecomment-3280838227)
I would be a nice cleanup to do #33066 and then this PR, but i won't make a priority of working on it. Closing for now.
(https://github.com/bitcoin/bitcoin/pull/32379#issuecomment-3280838227)
I would be a nice cleanup to do #33066 and then this PR, but i won't make a priority of working on it. Closing for now.
✅ darosior closed a pull request: "p2p: stop special-casing witness-stripped error for unconfirmed transactions"
(https://github.com/bitcoin/bitcoin/pull/32379)
(https://github.com/bitcoin/bitcoin/pull/32379)
💬 TheCharlatan commented on pull request "kernel: Separate UTXO set access from validation functions":
(https://github.com/bitcoin/bitcoin/pull/32317#issuecomment-3280976957)
My goal with this PR was making the bulk of `ConnectBlock` logic work without using a `CCoinsViewCache` by moving the call to `UpdateCoins` out of the function. The side effect of that is that the `CBlockUndo` is populated outside of `ConnectBlock` too and has to be passed in. Since it already holds all the required coins, I rather took those coins vectors, than additionally requiring a view providing the same data (next to the reasons I provided in my comment above).
The change was motivated
...
(https://github.com/bitcoin/bitcoin/pull/32317#issuecomment-3280976957)
My goal with this PR was making the bulk of `ConnectBlock` logic work without using a `CCoinsViewCache` by moving the call to `UpdateCoins` out of the function. The side effect of that is that the `CBlockUndo` is populated outside of `ConnectBlock` too and has to be passed in. Since it already holds all the required coins, I rather took those coins vectors, than additionally requiring a view providing the same data (next to the reasons I provided in my comment above).
The change was motivated
...
🤔 glozow reviewed a pull request: "txgraph: use enum Level instead of bool main_only"
(https://github.com/bitcoin/bitcoin/pull/33354#pullrequestreview-3212180028)
code review ACK d45f3717d2c65d1a6012a4bc2f47ff75004fd171
(https://github.com/bitcoin/bitcoin/pull/33354#pullrequestreview-3212180028)
code review ACK d45f3717d2c65d1a6012a4bc2f47ff75004fd171
💬 hebasto commented on issue "oss-fuzz: build failing":
(https://github.com/bitcoin/bitcoin/issues/33366#issuecomment-3281275004)
It seems caused by switching from Clang 18.1.8 to Clang 22.0.0.
(https://github.com/bitcoin/bitcoin/issues/33366#issuecomment-3281275004)
It seems caused by switching from Clang 18.1.8 to Clang 22.0.0.
💬 fjahr commented on pull request "common: Make arith_uint256 trivially copyable":
(https://github.com/bitcoin/bitcoin/pull/33332#discussion_r2341359835)
IMO it is not surprising that tests didn't need to be updated because this is a refactor. For pure refactors that don't change behavior it is normal to not add/edit tests.
Furthermore, trivially copyable is a compile-time structural property that affects ABI/optimization, not behavior. So we aren't changing something that could change behavior in this PR. FWIW, these lines were covered by unit tests, see the coverage reports: https://maflcko.github.io/b-c-cov/test_bitcoin.coverage/src/arith_u
...
(https://github.com/bitcoin/bitcoin/pull/33332#discussion_r2341359835)
IMO it is not surprising that tests didn't need to be updated because this is a refactor. For pure refactors that don't change behavior it is normal to not add/edit tests.
Furthermore, trivially copyable is a compile-time structural property that affects ABI/optimization, not behavior. So we aren't changing something that could change behavior in this PR. FWIW, these lines were covered by unit tests, see the coverage reports: https://maflcko.github.io/b-c-cov/test_bitcoin.coverage/src/arith_u
...
💬 fjahr commented on pull request "common: Make arith_uint256 trivially copyable":
(https://github.com/bitcoin/bitcoin/pull/33332#discussion_r2341360204)
It is implicitly now could not be in the future if there are changes made to the class. So it might be better to let the compiler choose `noexcept` conditionally based on what the class looks like in the future.
I would be fine with removing the default declarations like in the original version of the PR but it seems to me so far more reviewers were in favor of them, so keeping them for now.
If others reviewers are convinced by @l0rinc 's arguments and now in favor of removing, please comm
...
(https://github.com/bitcoin/bitcoin/pull/33332#discussion_r2341360204)
It is implicitly now could not be in the future if there are changes made to the class. So it might be better to let the compiler choose `noexcept` conditionally based on what the class looks like in the future.
I would be fine with removing the default declarations like in the original version of the PR but it seems to me so far more reviewers were in favor of them, so keeping them for now.
If others reviewers are convinced by @l0rinc 's arguments and now in favor of removing, please comm
...
💬 fjahr commented on pull request "common: Make arith_uint256 trivially copyable":
(https://github.com/bitcoin/bitcoin/pull/33332#issuecomment-3281328737)
Addressed the comments, thanks for running the benchmarks @l0rinc , it's good to see that the performance improvement can be demonstrated.
(https://github.com/bitcoin/bitcoin/pull/33332#issuecomment-3281328737)
Addressed the comments, thanks for running the benchmarks @l0rinc , it's good to see that the performance improvement can be demonstrated.
💬 Raimo33 commented on pull request "common: Make arith_uint256 trivially copyable":
(https://github.com/bitcoin/bitcoin/pull/33332#issuecomment-3281348841)
ACK 653a9849d5f98ba80e334ddc0ae9a5e367459f59
(https://github.com/bitcoin/bitcoin/pull/33332#issuecomment-3281348841)
ACK 653a9849d5f98ba80e334ddc0ae9a5e367459f59
📝 bitgold7 opened a pull request: "Posv3.1 integration"
(https://github.com/bitcoin/bitcoin/pull/33367)
<!--
*** Please remove the following help text before submitting: ***
Pull requests without a rationale and clear improvement may be closed
immediately.
GUI-related pull requests should be opened against
https://github.com/bitcoin-core/gui
first. See CONTRIBUTING.md
-->
<!--
Please provide clear motivation for your patch and explain how it improves
Bitcoin Core user experience or Bitcoin Core developer experience
significantly:
* Any test improvements or new tests that improv
...
(https://github.com/bitcoin/bitcoin/pull/33367)
<!--
*** Please remove the following help text before submitting: ***
Pull requests without a rationale and clear improvement may be closed
immediately.
GUI-related pull requests should be opened against
https://github.com/bitcoin-core/gui
first. See CONTRIBUTING.md
-->
<!--
Please provide clear motivation for your patch and explain how it improves
Bitcoin Core user experience or Bitcoin Core developer experience
significantly:
* Any test improvements or new tests that improv
...
🚀 glozow merged a pull request: "txgraph: use enum Level instead of bool main_only"
(https://github.com/bitcoin/bitcoin/pull/33354)
(https://github.com/bitcoin/bitcoin/pull/33354)
📝 sipa converted_to_draft a pull request: "Replace cluster linearization algorithm with SFL"
(https://github.com/bitcoin/bitcoin/pull/32545)
Part of cluster mempool: #30289. Based on #30605.
This replaces the cluster linearization algorithm introduced in #30126 and #30286 (a combination of LIMO with candidate-set search), with a completely different algorithm: [spanning-forest linearization](https://delvingbitcoin.org/t/spanning-forest-cluster-linearization/1419/1), which appears to have much better performance for hard clusters. See [this post](https://delvingbitcoin.org/t/how-to-linearize-your-cluster/303/68) for a comparison be
...
(https://github.com/bitcoin/bitcoin/pull/32545)
Part of cluster mempool: #30289. Based on #30605.
This replaces the cluster linearization algorithm introduced in #30126 and #30286 (a combination of LIMO with candidate-set search), with a completely different algorithm: [spanning-forest linearization](https://delvingbitcoin.org/t/spanning-forest-cluster-linearization/1419/1), which appears to have much better performance for hard clusters. See [this post](https://delvingbitcoin.org/t/how-to-linearize-your-cluster/303/68) for a comparison be
...
💬 sipa commented on pull request "Replace cluster linearization algorithm with SFL":
(https://github.com/bitcoin/bitcoin/pull/32545#issuecomment-3281455036)
I'm working on some improvements and reorganization of the commit here, so marking it as draft for now.
(https://github.com/bitcoin/bitcoin/pull/32545#issuecomment-3281455036)
I'm working on some improvements and reorganization of the commit here, so marking it as draft for now.
💬 sipa commented on pull request "txgraph: randomize order of same-feerate distinct-cluster transactions":
(https://github.com/bitcoin/bitcoin/pull/33335#discussion_r2341550686)
Eh. When seen individual comparisons in isolation, independently, each has a probability of exactly 2^-64 of being a collision.
But within a group of N clusters, the ability that at least one pair exists whose hashes will collide, is approximately `1-exp(-N*(N-1)/2^65)`. You can be even more precise, as only pairs of clusters which have chunks with equal feerates matter, but this is a sufficiently low bound that I don't think we care.
(https://github.com/bitcoin/bitcoin/pull/33335#discussion_r2341550686)
Eh. When seen individual comparisons in isolation, independently, each has a probability of exactly 2^-64 of being a collision.
But within a group of N clusters, the ability that at least one pair exists whose hashes will collide, is approximately `1-exp(-N*(N-1)/2^65)`. You can be even more precise, as only pairs of clusters which have chunks with equal feerates matter, but this is a sufficiently low bound that I don't think we care.
💬 l0rinc commented on pull request "validation: ensure assumevalid is always used during reindex":
(https://github.com/bitcoin/bitcoin/pull/31615#issuecomment-3281660246)
While just restarting the node with this commit didn't help for some reason, doing a reindex with it does seem to disable signature verification successfully. But it doesn't actually seem to fix the underlying problem, since `./build/bin/bitcoin-cli -datadir=$DATA_DIR getblockchaininfo | jq .headers` still returns `841150` for me.
So while it does seem to work around the issue described in https://github.com/bitcoin/bitcoin/pull/33336#issuecomment-3277968407, it doesn't seem to solve the unde
...
(https://github.com/bitcoin/bitcoin/pull/31615#issuecomment-3281660246)
While just restarting the node with this commit didn't help for some reason, doing a reindex with it does seem to disable signature verification successfully. But it doesn't actually seem to fix the underlying problem, since `./build/bin/bitcoin-cli -datadir=$DATA_DIR getblockchaininfo | jq .headers` still returns `841150` for me.
So while it does seem to work around the issue described in https://github.com/bitcoin/bitcoin/pull/33336#issuecomment-3277968407, it doesn't seem to solve the unde
...
⚠️ fanquake opened an issue: "v30.0 Testing"
(https://github.com/bitcoin/bitcoin/issues/33368)
Umbrella issue for 30.0 testing. Please help testing on a wide variety of supported platforms, as well as interaction with different software.
Let us know which version you tested on which operating system.
If you find an issue, please search Github for known issues first and then open a new Github issue.
This meta issue should not be used to report bugs, as a single thread makes it impossible to track more than one topic.
See [30.0 Release Notes Draft](https://github.com/bitcoin-core/bitcoi
...
(https://github.com/bitcoin/bitcoin/issues/33368)
Umbrella issue for 30.0 testing. Please help testing on a wide variety of supported platforms, as well as interaction with different software.
Let us know which version you tested on which operating system.
If you find an issue, please search Github for known issues first and then open a new Github issue.
This meta issue should not be used to report bugs, as a single thread makes it impossible to track more than one topic.
See [30.0 Release Notes Draft](https://github.com/bitcoin-core/bitcoi
...
⚠️ fanquake pinned an issue: "v30.0 Testing"
(https://github.com/bitcoin/bitcoin/issues/33368)
Umbrella issue for 30.0 testing. Please help testing on a wide variety of supported platforms, as well as interaction with different software.
Let us know which version you tested on which operating system.
If you find an issue, please search Github for known issues first and then open a new Github issue.
This meta issue should not be used to report bugs, as a single thread makes it impossible to track more than one topic.
See [30.0 Release Notes Draft](https://github.com/bitcoin-core/bitcoi
...
(https://github.com/bitcoin/bitcoin/issues/33368)
Umbrella issue for 30.0 testing. Please help testing on a wide variety of supported platforms, as well as interaction with different software.
Let us know which version you tested on which operating system.
If you find an issue, please search Github for known issues first and then open a new Github issue.
This meta issue should not be used to report bugs, as a single thread makes it impossible to track more than one topic.
See [30.0 Release Notes Draft](https://github.com/bitcoin-core/bitcoi
...