Bitcoin Core Github
45 subscribers
118K links
Download Telegram
fanquake closed a pull request: "draft: CMake Goals and Guidelines"
(https://github.com/bitcoin/bitcoin/pull/33317)
💬 ajtowns commented on pull request "kernel: Separate UTXO set access from validation functions":
(https://github.com/bitcoin/bitcoin/pull/32317#issuecomment-3269734161)
> Pass a block's spent coins through the existing `CBlockUndo` data structure to `ConnectBlock`

I don't think this is really a good direction. We already have a generic interface for supplying info about unspent coins: `CCoinsView`; I think we should be using that, rather than requiring users to convert their utxo data store into our undo format?

The thing that gets in the way of that seems to be the `AccessCoin` function returning a `Coin` by reference rather than value, but that doesn't
...
💬 Sjors commented on issue "ci: Support running from a worktree":
(https://github.com/bitcoin/bitcoin/issues/30028#issuecomment-3269740880)
As mentioned in https://github.com/bitcoin/bitcoin/pull/32767 the linter still doesn't work in a worktree.
⚠️ fanquake opened an issue: "ci: derived LLVM version too new"
(https://github.com/bitcoin/bitcoin/issues/33345)
Running the native MSAN job, it will install `clang 21.1.1`, which will result in a failure to clone the LLVM repo, as there is no 21.1.1 tag:
```bash
time env -i HOME="$HOME" PATH="$PATH" USER="$USER" bash -c 'MAKEJOBS="-j17" FILE_ENV="./ci/test/00_setup_env_native_msan.sh" ./ci/test_run_all.sh'
<snip>
+ [[ -n MemoryWithOrigins ]]
+ '[' -n 21 ']'
++ sed --silent 's@.*clang version \([0-9.]*\).*@\1@p'
++ clang --version
+ retry -- git clone --depth=1 https://github.com/llvm/llvm-project -b llvmo
...
💬 fanquake commented on issue "ci: derived LLVM version too new":
(https://github.com/bitcoin/bitcoin/issues/33345#issuecomment-3269794728)
cc @maflcko
📝 fanquake opened a pull request: "doc: remove release note fragment"
(https://github.com/bitcoin/bitcoin/pull/33346)
I've added the content to https://github.com/bitcoin-core/bitcoin-devwiki/wiki/v30.0-Release-Notes-Draft.
👍 dergoegge approved a pull request: "doc: remove release note fragment"
(https://github.com/bitcoin/bitcoin/pull/33346#pullrequestreview-3200515279)
ACK 0f0e6fe7f5f467353704c3a4f51ceb9a4e2cf0a0
🚀 fanquake merged a pull request: "doc: remove release note fragment"
(https://github.com/bitcoin/bitcoin/pull/33346)
📝 fanquake opened a pull request: "build: bump `CLIENT_VERSION_MAJOR` to 30"
(https://github.com/bitcoin/bitcoin/pull/33347)
Last step before branch off.
👍 hebasto approved a pull request: "build: bump `CLIENT_VERSION_MAJOR` to 30"
(https://github.com/bitcoin/bitcoin/pull/33347#pullrequestreview-3200673497)
ACK 9f744fffc39d93c9966dec1d61f113a7521983ad.
🚀 fanquake merged a pull request: "build: bump `CLIENT_VERSION_MAJOR` to 30"
(https://github.com/bitcoin/bitcoin/pull/33347)
💬 fanquake commented on issue "Release Schedule for 30.0":
(https://github.com/bitcoin/bitcoin/issues/32275#issuecomment-3269994120)
`30.x` has been branched off: https://github.com/bitcoin/bitcoin/tree/30.x.
💬 hebasto commented on pull request "ci, iwyu: Treat warnings as errors for specific directories":
(https://github.com/bitcoin/bitcoin/pull/31308#issuecomment-3270036463)
Rebased due to a conflict with https://github.com/bitcoin/bitcoin/pull/30469.
📝 fanquake opened a pull request: "contrib: add bitcoin binary to gen-manpages"
(https://github.com/bitcoin/bitcoin/pull/33348)
This was missed in #31375.
💬 fanquake commented on pull request "multiprocess: Add bitcoin wrapper executable":
(https://github.com/bitcoin/bitcoin/pull/31375#issuecomment-3270040917)
`gen-manpages.py` followup in #33348.
📝 fanquake opened a pull request: "[30.x] v30.0rc1"
(https://github.com/bitcoin/bitcoin/pull/33349)
* Bumps version to `v30.0rc1`.
* Generates example bitcoin.conf.
* Generates the manpages (will backport #33348).
* Points release-notes.md to the devwiki (https://github.com/bitcoin-core/bitcoin-devwiki/wiki/v30.0-Release-Notes-Draft).
👍 dergoegge approved a pull request: "contrib: add bitcoin binary to gen-manpages"
(https://github.com/bitcoin/bitcoin/pull/33348#pullrequestreview-3200876564)
ACK 53e6db91ef59a80d9141f6bbc56dd547b6c1b46b
🚀 fanquake merged a pull request: "contrib: add bitcoin binary to gen-manpages"
(https://github.com/bitcoin/bitcoin/pull/33348)
💬 fanquake commented on pull request "contrib: add bitcoin binary to gen-manpages":
(https://github.com/bitcoin/bitcoin/pull/33348#issuecomment-3270141486)
Partial (f5887a8de4c8b3492aa8713c59c4e3819fd4e42b) backport to 30.x in #33349.
🤔 naiyoma reviewed a pull request: "net: Prevent node from binding to the same `CService`"
(https://github.com/bitcoin/bitcoin/pull/33231#pullrequestreview-3200967067)

Tested ACK 4d4789dffad55b96f1cb96b718cc6923f5344454

Manually tested with different duplicate bindings.
```
./build/bin/bitcoind -bind=0.0.0.0=onion -bind=0.0.0.0=onion
./build/bin/bitcoind -bind=0.0.0.0 -bind=0.0.0.0
./build/bin/bitcoind -whitebind=relay@127.0.0.1:8333 -whitebind=mempool@127.0.0.1:8333
```
On master, the error message is misleading
```
2025-09-09T10:59:38Z [net:error] Unable to bind to 0.0.0.0:8334 on this computer. Bitcoin Core is probably already running.
2025-09
...