🚀 fanquake merged a pull request: "ci: reduce runner sizes on various jobs"
(https://github.com/bitcoin/bitcoin/pull/33319)
(https://github.com/bitcoin/bitcoin/pull/33319)
🚀 fanquake merged a pull request: "ci: Checkout latest merged pulls"
(https://github.com/bitcoin/bitcoin/pull/33303)
(https://github.com/bitcoin/bitcoin/pull/33303)
💬 fanquake commented on pull request "Release: 30.0 translations update":
(https://github.com/bitcoin/bitcoin/pull/33275#issuecomment-3269692601)
ACK b320f5efa1753aead857d4cddd742af16e51d8d1
(https://github.com/bitcoin/bitcoin/pull/33275#issuecomment-3269692601)
ACK b320f5efa1753aead857d4cddd742af16e51d8d1
💬 willcl-ark commented on pull request "ci: reduce runner sizes on various jobs":
(https://github.com/bitcoin/bitcoin/pull/33319#issuecomment-3269693548)
WIP stats collection (forked from @0xB10C project) here: https://willcl-ark.github.io/bitcoin-core-ci-stats
(https://github.com/bitcoin/bitcoin/pull/33319#issuecomment-3269693548)
WIP stats collection (forked from @0xB10C project) here: https://willcl-ark.github.io/bitcoin-core-ci-stats
📝 fanquake opened a pull request: "[29.x] Backports"
(https://github.com/bitcoin/bitcoin/pull/33344)
Backports:
* #33340
(https://github.com/bitcoin/bitcoin/pull/33344)
Backports:
* #33340
🚀 fanquake merged a pull request: "Release: 30.0 translations update"
(https://github.com/bitcoin/bitcoin/pull/33275)
(https://github.com/bitcoin/bitcoin/pull/33275)
💬 fanquake commented on pull request "draft: CMake Goals and Guidelines":
(https://github.com/bitcoin/bitcoin/pull/33317#issuecomment-3269723504)
> can you grant me write access to the Wiki?
You should have access now. Will close this in favour of the using wiki.
(https://github.com/bitcoin/bitcoin/pull/33317#issuecomment-3269723504)
> can you grant me write access to the Wiki?
You should have access now. Will close this in favour of the using wiki.
✅ fanquake closed a pull request: "draft: CMake Goals and Guidelines"
(https://github.com/bitcoin/bitcoin/pull/33317)
(https://github.com/bitcoin/bitcoin/pull/33317)
💬 ajtowns commented on pull request "kernel: Separate UTXO set access from validation functions":
(https://github.com/bitcoin/bitcoin/pull/32317#issuecomment-3269734161)
> Pass a block's spent coins through the existing `CBlockUndo` data structure to `ConnectBlock`
I don't think this is really a good direction. We already have a generic interface for supplying info about unspent coins: `CCoinsView`; I think we should be using that, rather than requiring users to convert their utxo data store into our undo format?
The thing that gets in the way of that seems to be the `AccessCoin` function returning a `Coin` by reference rather than value, but that doesn't
...
(https://github.com/bitcoin/bitcoin/pull/32317#issuecomment-3269734161)
> Pass a block's spent coins through the existing `CBlockUndo` data structure to `ConnectBlock`
I don't think this is really a good direction. We already have a generic interface for supplying info about unspent coins: `CCoinsView`; I think we should be using that, rather than requiring users to convert their utxo data store into our undo format?
The thing that gets in the way of that seems to be the `AccessCoin` function returning a `Coin` by reference rather than value, but that doesn't
...
💬 Sjors commented on issue "ci: Support running from a worktree":
(https://github.com/bitcoin/bitcoin/issues/30028#issuecomment-3269740880)
As mentioned in https://github.com/bitcoin/bitcoin/pull/32767 the linter still doesn't work in a worktree.
(https://github.com/bitcoin/bitcoin/issues/30028#issuecomment-3269740880)
As mentioned in https://github.com/bitcoin/bitcoin/pull/32767 the linter still doesn't work in a worktree.
⚠️ fanquake opened an issue: "ci: derived LLVM version too new"
(https://github.com/bitcoin/bitcoin/issues/33345)
Running the native MSAN job, it will install `clang 21.1.1`, which will result in a failure to clone the LLVM repo, as there is no 21.1.1 tag:
```bash
time env -i HOME="$HOME" PATH="$PATH" USER="$USER" bash -c 'MAKEJOBS="-j17" FILE_ENV="./ci/test/00_setup_env_native_msan.sh" ./ci/test_run_all.sh'
<snip>
+ [[ -n MemoryWithOrigins ]]
+ '[' -n 21 ']'
++ sed --silent 's@.*clang version \([0-9.]*\).*@\1@p'
++ clang --version
+ retry -- git clone --depth=1 https://github.com/llvm/llvm-project -b llvmo
...
(https://github.com/bitcoin/bitcoin/issues/33345)
Running the native MSAN job, it will install `clang 21.1.1`, which will result in a failure to clone the LLVM repo, as there is no 21.1.1 tag:
```bash
time env -i HOME="$HOME" PATH="$PATH" USER="$USER" bash -c 'MAKEJOBS="-j17" FILE_ENV="./ci/test/00_setup_env_native_msan.sh" ./ci/test_run_all.sh'
<snip>
+ [[ -n MemoryWithOrigins ]]
+ '[' -n 21 ']'
++ sed --silent 's@.*clang version \([0-9.]*\).*@\1@p'
++ clang --version
+ retry -- git clone --depth=1 https://github.com/llvm/llvm-project -b llvmo
...
💬 fanquake commented on issue "ci: derived LLVM version too new":
(https://github.com/bitcoin/bitcoin/issues/33345#issuecomment-3269794728)
cc @maflcko
(https://github.com/bitcoin/bitcoin/issues/33345#issuecomment-3269794728)
cc @maflcko
📝 fanquake opened a pull request: "doc: remove release note fragment"
(https://github.com/bitcoin/bitcoin/pull/33346)
I've added the content to https://github.com/bitcoin-core/bitcoin-devwiki/wiki/v30.0-Release-Notes-Draft.
(https://github.com/bitcoin/bitcoin/pull/33346)
I've added the content to https://github.com/bitcoin-core/bitcoin-devwiki/wiki/v30.0-Release-Notes-Draft.
👍 dergoegge approved a pull request: "doc: remove release note fragment"
(https://github.com/bitcoin/bitcoin/pull/33346#pullrequestreview-3200515279)
ACK 0f0e6fe7f5f467353704c3a4f51ceb9a4e2cf0a0
(https://github.com/bitcoin/bitcoin/pull/33346#pullrequestreview-3200515279)
ACK 0f0e6fe7f5f467353704c3a4f51ceb9a4e2cf0a0
🚀 fanquake merged a pull request: "doc: remove release note fragment"
(https://github.com/bitcoin/bitcoin/pull/33346)
(https://github.com/bitcoin/bitcoin/pull/33346)
📝 fanquake opened a pull request: "build: bump `CLIENT_VERSION_MAJOR` to 30"
(https://github.com/bitcoin/bitcoin/pull/33347)
Last step before branch off.
(https://github.com/bitcoin/bitcoin/pull/33347)
Last step before branch off.
👍 hebasto approved a pull request: "build: bump `CLIENT_VERSION_MAJOR` to 30"
(https://github.com/bitcoin/bitcoin/pull/33347#pullrequestreview-3200673497)
ACK 9f744fffc39d93c9966dec1d61f113a7521983ad.
(https://github.com/bitcoin/bitcoin/pull/33347#pullrequestreview-3200673497)
ACK 9f744fffc39d93c9966dec1d61f113a7521983ad.
🚀 fanquake merged a pull request: "build: bump `CLIENT_VERSION_MAJOR` to 30"
(https://github.com/bitcoin/bitcoin/pull/33347)
(https://github.com/bitcoin/bitcoin/pull/33347)
💬 fanquake commented on issue "Release Schedule for 30.0":
(https://github.com/bitcoin/bitcoin/issues/32275#issuecomment-3269994120)
`30.x` has been branched off: https://github.com/bitcoin/bitcoin/tree/30.x.
(https://github.com/bitcoin/bitcoin/issues/32275#issuecomment-3269994120)
`30.x` has been branched off: https://github.com/bitcoin/bitcoin/tree/30.x.
💬 hebasto commented on pull request "ci, iwyu: Treat warnings as errors for specific directories":
(https://github.com/bitcoin/bitcoin/pull/31308#issuecomment-3270036463)
Rebased due to a conflict with https://github.com/bitcoin/bitcoin/pull/30469.
(https://github.com/bitcoin/bitcoin/pull/31308#issuecomment-3270036463)
Rebased due to a conflict with https://github.com/bitcoin/bitcoin/pull/30469.