🤔 l0rinc requested changes to a pull request: "index: Force database compaction in coinstatsindex"
(https://github.com/bitcoin/bitcoin/pull/33306#pullrequestreview-3197501516)
I'm missing benchmark results to see how this change affects the already very slow performance. I will post my own results as soon as they finish.

I would also like to understand why database compaction isn't enabled for this LevelDB instance.

💬 l0rinc commented on pull request "index: Force database compaction in coinstatsindex":
(https://github.com/bitcoin/bitcoin/pull/33306#discussion_r2330924479)
do you think this is better than using the existing `LEVELDB` category? Seems these categories are in short supply and compaction seems like a LevelDB thing to me.

💬 l0rinc commented on pull request "index: Force database compaction in coinstatsindex":
(https://github.com/bitcoin/bitcoin/pull/33306#discussion_r2331873098)
nit: since we're touching it:
```suggestion
DBContext().pdb->CompactRange(/*begin=*/nullptr, /*end=*/nullptr);
```

💬 l0rinc commented on pull request "index: Force database compaction in coinstatsindex":
(https://github.com/bitcoin/bitcoin/pull/33306#discussion_r2330966568)
I haven't checked the linked PR in detail (I have to have *some* stopping condition, and I think the PR should explain the important context) but I didn't get the impression until now that we weren't doing any compaction here before, I just thought you meant that "it's struggling to keep up".

Have a few questions here:
* could we rather add this to the other background compaction thread? Do we understand why there's no automatic compaction?
* does it make sense to do the compaction so often? Th
...

💬 Sjors commented on pull request "[DRAFT] Expose AssumeUTXO Load Snapshot Functionality To The GUI":
(https://github.com/bitcoin-core/gui/pull/870#issuecomment-3269262623)
The dialog wouldn't respond to me clicking on a file or folder. But then after a minute or so it worked again.

💬 vasild commented on pull request "rpc: provide per message stats for global traffic via new RPC 'getnetmsgstats'":
(https://github.com/bitcoin/bitcoin/pull/29418#issuecomment-3269416910)
`528b4d6b9c...87d3d640e6`: rebase due to conflicts and fix a typo in comment

💬 josibake commented on pull request "Silent Payments: Receiving":
(https://github.com/bitcoin/bitcoin/pull/32966#discussion_r2332480260)
FYI, I have a WIP commit that implements a `SilentPaymentsSign` function, I'll push the commit later today. Its a bit more code than what we have with `CKey::TweakAdd`, but I do like that its silent payments specific and can't be used as a footgun.

💬 fanquake commented on pull request "guix: strip binaries in libexec":
(https://github.com/bitcoin/bitcoin/pull/33342#issuecomment-3269550586)
Guix Build:
```bash
2042885891c2fdb6d3220da39e6f19b1a9852e3cca865db10f29e94fb2edc35d guix-build-3cceda9f4855/output/aarch64-linux-gnu/SHA256SUMS.part
f0e603d2a39bab4f4f81160584d6e27c90601c38e8302b813969214e797f16f8 guix-build-3cceda9f4855/output/aarch64-linux-gnu/bitcoin-3cceda9f4855-aarch64-linux-gnu-debug.tar.gz
410a706671693f8770474c797e35bb878961ff810e5a9bfb2bd19b4f069bfd0c guix-build-3cceda9f4855/output/aarch64-linux-gnu/bitcoin-3cceda9f4855-aarch64-linux-gnu.tar.gz
acc23910bac2c095
...

👍 vasild approved a pull request: "net: Fix Discover() not running when using -bind=0.0.0.0:port"
(https://github.com/bitcoin/bitcoin/pull/32757#pullrequestreview-3200165794)
ACK 210dd4061193f221a05c630ef5819f36dde9b15f

It suffices to prefix only the first line of the commit message with "test:".

💬 Sjors commented on pull request "multiprocess: Don't require bitcoin -m argument when IPC options are used":
(https://github.com/bitcoin/bitcoin/pull/33229#issuecomment-3269646261)
ACK f9685d6a1389938b0cceb31d9eef201ab3dd2e86

We could simplify the functional tests a bit with 148ced15c3c27da332985361cc2c83ae12c772eb which drops `BITCOIN_CMD` and simplifies the `_argv` logic.

✅ fanquake closed an issue: "bench: broken CSV format, commas in benchmark names"
(https://github.com/bitcoin/bitcoin/issues/33331)

🚀 fanquake merged a pull request: "Fix benchmark CSV output"
(https://github.com/bitcoin/bitcoin/pull/33340)

🚀 fanquake merged a pull request: "ci: reduce runner sizes on various jobs"
(https://github.com/bitcoin/bitcoin/pull/33319)

🚀 fanquake merged a pull request: "ci: Checkout latest merged pulls"
(https://github.com/bitcoin/bitcoin/pull/33303)

💬 fanquake commented on pull request "Release: 30.0 translations update":
(https://github.com/bitcoin/bitcoin/pull/33275#issuecomment-3269692601)
ACK b320f5efa1753aead857d4cddd742af16e51d8d1

💬 willcl-ark commented on pull request "ci: reduce runner sizes on various jobs":
(https://github.com/bitcoin/bitcoin/pull/33319#issuecomment-3269693548)
WIP stats collection (forked from @0xB10C project) here: https://willcl-ark.github.io/bitcoin-core-ci-stats

📝 fanquake opened a pull request: "[29.x] Backports"
(https://github.com/bitcoin/bitcoin/pull/33344)
Backports:
* #33340

🚀 fanquake merged a pull request: "Release: 30.0 translations update"
(https://github.com/bitcoin/bitcoin/pull/33275)

💬 fanquake commented on pull request "draft: CMake Goals and Guidelines":
(https://github.com/bitcoin/bitcoin/pull/33317#issuecomment-3269723504)
> can you grant me write access to the Wiki?

You should have access now. Will close this in favour of the using wiki.

✅ fanquake closed a pull request: "draft: CMake Goals and Guidelines"
(https://github.com/bitcoin/bitcoin/pull/33317)