🚀 fanquake merged a pull request: "doc: archive v29.1 release notes"
(https://github.com/bitcoin/bitcoin/pull/33309)

✅ fanquake closed an issue: "build: suggest -DENABLE_IPC=OFF when missing capnp"
(https://github.com/bitcoin/bitcoin/issues/33315)

💬 fanquake commented on issue "build: suggest -DENABLE_IPC=OFF when missing capnp":
(https://github.com/bitcoin/bitcoin/issues/33315#issuecomment-3257701571)
Thanks, but I don't think we need a separate issue to track the subtree update, which wont be forgotten.

📝 purpleKarrot opened a pull request: "draft: CMake Goals and Guidelines"
(https://github.com/bitcoin/bitcoin/pull/33317)

💬 hodlinator commented on pull request "headerssync: Correct unrealistic unit test behavior":
(https://github.com/bitcoin/bitcoin/pull/32579#discussion_r2324586432)
Thanks for catching this! Pushed fix.

💬 hodlinator commented on pull request "headerssync: Correct unrealistic unit test behavior":
(https://github.com/bitcoin/bitcoin/pull/32579#discussion_r2324582945)
What makes a 2-statement lambda better than https://en.cppreference.com/w/cpp/language/operator_other.html#Built-in_comma_operator in this case?

Also not sure why it changes the need for the comment.

💬 TheCharlatan commented on pull request "Add functional test for IPC interface":
(https://github.com/bitcoin/bitcoin/pull/33201#discussion_r2324611489)
Or it can be fixed with the following by using the MiniWallet:
```diff
diff --git a/test/functional/interface_ipc.py b/test/functional/interface_ipc.py
index 03f0ed200c..c54e3f3a6b 100755
--- a/test/functional/interface_ipc.py
+++ b/test/functional/interface_ipc.py
@@ -11,0 +12 @@ from test_framework.test_framework import (BitcoinTestFramework, assert_equal)
+from test_framework.wallet import MiniWallet
@@ -94,0 +96,2 @@ class IPCInterfaceTest(BitcoinTestFramework):
+ miniwallet
...

💬 fanquake commented on pull request "depends: strip when installing qt binaries":
(https://github.com/bitcoin/bitcoin/pull/33304#issuecomment-3257746459)
Before this change, depends built cache restore for the centos DEBUG=1 job:
```bash
Cache hit for restore-key: depends-built-ci_native_centos-b5ec5a84074477732c9e7415e49fda779e2e820d1953a68b1654b7dc77d6eedd

Cache Size: ~1090 MB (1143026710 B)
```

The depends built cache saved after this PR:
```bash
Sent 524648857 of 591757721 (88.7%), 38.5 MBs/sec
Sent 591757721 of 591757721 (100.0%), 40.3 MBs/sec
Cache saved with key: depends-built-ci_native_centos-0e079181cbaa95598b2653530a556fb95
...

💬 Sjors commented on pull request "Add functional test for IPC interface":
(https://github.com/bitcoin/bitcoin/pull/33201#discussion_r2324637465)
There was an earlier discussion about that. Apparently in c++ this isn't a problem, but for other language binding we should have defaults. So I'm inclined to agree that we should pick some.

✅ pinheadmz closed an issue: "Is there way to sort balance address functionality just like btcrank.site showing"
(https://github.com/bitcoin/bitcoin/issues/33314)

💬 pinheadmz commented on issue "Is there way to sort balance address functionality just like btcrank.site showing":
(https://github.com/bitcoin/bitcoin/issues/33314#issuecomment-3257841627)
No, Bitcoin Core does not have a built-in address indexer.

👍 vasild approved a pull request: "net: Prevent node from binding to the same `CService`"
(https://github.com/bitcoin/bitcoin/pull/33231#pullrequestreview-3188879865)
ACK 4d4789dffad55b96f1cb96b718cc6923f5344454

⚠️ fanquake opened an issue: "test: intermittent issue in p2p_1p1c_network.py"
(https://github.com/bitcoin/bitcoin/issues/33318)
Timeout failure in the TSAN job here https://github.com/bitcoin/bitcoin/actions/runs/17489459842/job/49675712585?pr=33317:
```bash
2025-09-05T10:51:37.2200865Z [0;33m node3 2025-09-05T10:51:30.541244Z [httpworker.7] [rpc/request.cpp:243] [void JSONRPCRequest::parse(const UniValue &)] [rpc] ThreadRPCServer method=getpeerinfo user=__cookie__ [0m
2025-09-05T10:51:37.2201033Z [0;36m test 2025-09-05T10:51:31.542469Z TestFramework (ERROR): Unexpected exception [0m
2025-09-05T10:51:37.2201165Z [0
...

💬 hodlinator commented on pull request "index: store per-block transaction locations for efficient lookups":
(https://github.com/bitcoin/bitcoin/pull/32541#discussion_r2324775699)
Wasn't getting consistent results until I ran `doas pyperf system tune` and got the variance down from ±1.0ms to ±0.1ms.

Used curl + hyperfine for clearer numbers on variance:

```
₿ hyperfine "curl -v http://localhost:8332/rest/txfromblock/000000000000000000017bfd05b5fa367a424c4a565a4baf7950d9e8605df8ec-5000.bin --output /dev/null" --warmup=1000 --min-runs=5000 --shell=none
```

#### With 0 cache:

```
Benchmark 1: curl -v http://localhost:8332/rest/txfromblock/000000000000000000017
...

💬 TheCharlatan commented on pull request "index: Fix coinstats overflow":
(https://github.com/bitcoin/bitcoin/pull/30469#discussion_r2324788471)
Was this reverted by mistake?

💬 fanquake commented on pull request "[29.x] *san CI backports":
(https://github.com/bitcoin/bitcoin/pull/33294#issuecomment-3257987510)
> Are you planning on adding these to release notes in this PR?

Added a commit for that.

💬 fanquake commented on pull request "trace: Workaround GCC bug compiling with old systemtap":
(https://github.com/bitcoin/bitcoin/pull/33310#issuecomment-3257996751)
Recreated the issue using `4.6`:
```bash
Run Build Command(s): /usr/bin/cmake -E env VERBOSE=1 /bin/gmake -f Makefile cmTC_5ba56/fast
/bin/gmake -f CMakeFiles/cmTC_5ba56.dir/build.make CMakeFiles/cmTC_5ba56.dir/build
gmake[1]: Entering directory '/bitcoin/build/CMakeFiles/CMakeScratch/TryCompile-goOPiQ'
Building CXX object CMakeFiles/cmTC_5ba56.dir/src.cxx.o
/bin/arm-linux-gnueabihf-g++ -DHAVE_USDT_H -I/bitcoin/depends/arm-linux-gnueabihf/include -O
...

🤔 kevkevinpal reviewed a pull request: "test/refactor: use test deque to avoid quadratic iteration"
(https://github.com/bitcoin/bitcoin/pull/33313#pullrequestreview-3188927106)
ACK [1500bb3](https://github.com/bitcoin/bitcoin/pull/33313/commits/1500bb359ef8aaee439c306a3c6ad01040edad9d)

Looks good to me, we're replacing `list` with a `deque` and replacing `pop(0)` with `popleft()`

💬 kevkevinpal commented on pull request "test/refactor: use test deque to avoid quadratic iteration":
(https://github.com/bitcoin/bitcoin/pull/33313#discussion_r2324808349)
deque also has an extend method, it might be preferable to use that instead since it is more readable

https://docs.python.org/3/library/collections.html#collections.deque.extend

💬 kevkevinpal commented on pull request "test/refactor: use test deque to avoid quadratic iteration":
(https://github.com/bitcoin/bitcoin/pull/33313#discussion_r2324787753)
Might make sense to replace this comment to explain why we're using a deque instead of list since it might not be obvious to a reader as to why