💬 fanquake commented on pull request "macOS: Bump minimum required runtime version and prepare for building with upstream LLVM":
(https://github.com/bitcoin/bitcoin/pull/27676#issuecomment-1570295375)
Note that you'l have to drop the `lazy_bind` check (we'll follow up with a `fixup_chains` test later). I've got a branch here with that change, which Guix builds successfully: https://github.com/fanquake/bitcoin/tree/27676_minus_lazy_bind.

Guix Build:
```bash
2da11646ff030cbd9207027e5af33ec77e8dc30fa4811fb47e6c2201da9b54e5 guix-build-36d66d7df78e/output/arm64-apple-darwin/SHA256SUMS.part
e1c5a81e97a942ace7c57fd7c12b8f45287939dd193418c435ac806d28d76b28 guix-build-36d66d7df78e/output/arm64
...

💬 pinheadmz commented on pull request "test: cover addrv2 anchors by adding TorV3 to CAddress in messages.py":
(https://github.com/bitcoin/bitcoin/pull/27452#discussion_r1211789138)
Good question. The Socks5 server we use in the test framework by default disconnects immediately after the handshake and sometimes would not register as a connected peer:

https://cirrus-ci.com/task/6075793026056192?logs=ci#L3820-L3830

💬 pinheadmz commented on pull request "test: cover addrv2 anchors by adding TorV3 to CAddress in messages.py":
(https://github.com/bitcoin/bitcoin/pull/27452#issuecomment-1570323701)
Thanks for the review Will, nits addressed and pushed

💬 torkelrogstad commented on issue "Indicate RBF replaceability, also after transactions have been confirmed ":
(https://github.com/bitcoin/bitcoin/issues/27794#issuecomment-1570339251)
Ok, thanks for the input. IMO what I've laid out here is something consumers of this API would care about. The Core API in general is very hard to work with, this being one example.

✅ torkelrogstad closed an issue: "Indicate RBF replaceability, also after transactions have been confirmed "
(https://github.com/bitcoin/bitcoin/issues/27794)

💬 hebasto commented on pull request "Add public Boost headers explicitly":
(https://github.com/bitcoin/bitcoin/pull/27783#discussion_r1211807185)
> Still, does using `multi_index_container_fwd.hpp` help at all?

No, it doesn't:
```
./txmempool.h:406:29: error: field ‘mapTx’ has incomplete type ‘CTxMemPool::indexed_transaction_set’ {aka ‘boost::multi_index::multi_index_container<CTxMemPoolEntry, boost::multi_index::indexed_by<boost::multi_index::hashed_unique<mempoolentry_txid, SaltedTxidHasher>, boost::multi_index::hashed_unique<boost::multi_index::tag<index_by_wtxid>, mempoolentry_wtxid, SaltedTxidHasher>, boost::multi_index::ordered
...

💬 sipa commented on issue "Indicate RBF replaceability, also after transactions have been confirmed ":
(https://github.com/bitcoin/bitcoin/issues/27794#issuecomment-1570343467)
@torkelrogstad I'm still confused about what you're trying to do. The only sensible answer to the question whether a confirmed transaction is replaceable is *no*. Whatever purpose you have for wondering about that, by the time a transaction confirms, it shouldn't matter anymore to anything.

💬 brunoerg commented on issue "Erlay status in getpeerinfo":
(https://github.com/bitcoin/bitcoin/issues/26602#issuecomment-1570354537)
In order to test Erlay I've implemented this recently to help me with my tests, I can open a PR for that.

💬 jonatack commented on pull request "Raise on invalid -debug and -loglevel config options":
(https://github.com/bitcoin/bitcoin/pull/27632#discussion_r1211826449)
Fixed, thank you.

💬 jonatack commented on pull request "Raise on invalid -debug and -loglevel config options":
(https://github.com/bitcoin/bitcoin/pull/27632#discussion_r1211826908)
Kept the translation -- thank you.

💬 sipa commented on issue "Indicate RBF replaceability, also after transactions have been confirmed ":
(https://github.com/bitcoin/bitcoin/issues/27794#issuecomment-1570364914)
@torkelrogstad Oh, I think I understand now, re-reading your earlier comments.

Having `bip125-replacable` return true for confirmed transaction is not a solution to your issue, because it can already change over time. Imagine a transaction T1 (which does signal) and a descendant transaction T2 (which does not signal), both unconfirmed. `bip125-replaceable` will be true for both, because the BIP125 rules say both are replaceable. Once T1 confirms, however, T2's `bip125-replaceable` will become
...

💬 jonatack commented on pull request "Raise on invalid -debug and -loglevel config options":
(https://github.com/bitcoin/bitcoin/pull/27632#discussion_r1211830118)
Rebased to current master to be able to use `Result` with support for `<void>` and updated the return types from bool to void.

💬 fanquake commented on issue "Spurious (?) valgrind failure for p2p_compactblocks.py":
(https://github.com/bitcoin/bitcoin/issues/27741#issuecomment-1570372707)
> Looks like valgrind 3.21 still has this issue.

Valgrind 3.22 (master @ e3602b3eec0696b183722ea21da14588cf205c74) also still fails.

💬 hebasto commented on pull request "Add public Boost headers explicitly":
(https://github.com/bitcoin/bitcoin/pull/27783#discussion_r1211838351)
> Feel free to take:

Taken. Thank you!

💬 hebasto commented on pull request "Add public Boost headers explicitly":
(https://github.com/bitcoin/bitcoin/pull/27783#issuecomment-1570376358)
Taken @MarcoFalke's [suggestion](https://github.com/bitcoin/bitcoin/pull/27783#discussion_r1211170115).

💬 theuni commented on pull request "macOS: Bump minimum required runtime version and prepare for building with upstream LLVM":
(https://github.com/bitcoin/bitcoin/pull/27676#issuecomment-1570410809)
> Note that you'l have to drop the `lazy_bind` check (we'll follow up with a `fixup_chains` test later). I've got a branch here with that change, which Guix builds successfully: https://github.com/fanquake/bitcoin/tree/27676_minus_lazy_bind.

Whoops, yes, thanks. Patch taken.

So this is now 100% working, just need to decide out what to do about guix.

📝 brunoerg opened a pull request: "rpc, net: add erlay status in `getpeerinfo`"
(https://github.com/bitcoin/bitcoin/pull/27797)
Fixes #26602

Adds `m_tx_reconciliation` in `Peer` struct
to know whether the peer supports Erlay and
exposes it in `getpeerinfo` rpc.

💬 brunoerg commented on pull request "rpc, net: add erlay status in `getpeerinfo`":
(https://github.com/bitcoin/bitcoin/pull/27797#issuecomment-1570411351)
cc: @Sjors

💬 jamesob commented on pull request "assumeutxo (2)":
(https://github.com/bitcoin/bitcoin/pull/27596#discussion_r1211880620)
Fixed, thanks

💬 jamesob commented on pull request "assumeutxo (2)":
(https://github.com/bitcoin/bitcoin/pull/27596#discussion_r1211880971)
Fixed, thanks all.