💬 Sjors commented on pull request "build: suggest -DENABLE_IPC=OFF when missing capnp":
(https://github.com/bitcoin/bitcoin/pull/33290#issuecomment-3257244295)
Closing in favour of https://github.com/bitcoin-core/libmultiprocess/pull/205.

⚠️ Sjors opened an issue: "build: suggest -DENABLE_IPC=OFF when missing capnp"
(https://github.com/bitcoin/bitcoin/issues/33315)
Placeholder for the closed PR #33290.

Currently being worked on in https://github.com/bitcoin-core/libmultiprocess/pull/205

After which we'll need a subtree update.

💬 Sjors commented on pull request "build: suggest -DENABLE_IPC=OFF when missing capnp":
(https://github.com/bitcoin/bitcoin/pull/33290#issuecomment-3257248291)
#33315 could be added to the v30 milestone so we don't forget.

💬 l0rinc commented on pull request "net: Prevent node from binding to the same `CService`":
(https://github.com/bitcoin/bitcoin/pull/33231#issuecomment-3257251460)
ACK 4d4789dffad55b96f1cb96b718cc6923f5344454

💬 w0xlt commented on pull request "net: Prevent node from binding to the same `CService`":
(https://github.com/bitcoin/bitcoin/pull/33231#discussion_r2324248666)
Good catch, fixed in 4d4789dffad55b96f1cb96b718cc6923f5344454. Thanks.

💬 Sjors commented on pull request "multiprocess: Don't require bitcoin -m argument when IPC options are used":
(https://github.com/bitcoin/bitcoin/pull/33229#discussion_r2324249003)
No access to `self.logger` here?

💬 w0xlt commented on pull request "net: Prevent node from binding to the same `CService`":
(https://github.com/bitcoin/bitcoin/pull/33231#discussion_r2324249155)
Done in 4d4789dffad55b96f1cb96b718cc6923f5344454. Thanks.

💬 yuvicc commented on pull request "net: Prevent node from binding to the same `CService`":
(https://github.com/bitcoin/bitcoin/pull/33231#discussion_r2324251766)
> @yuvicc, this still needs fixing

Ahh, I thought that was non-blocking.

💬 yuvicc commented on pull request "net: Prevent node from binding to the same `CService`":
(https://github.com/bitcoin/bitcoin/pull/33231#issuecomment-3257261379)
re-ACK 4d4789dffad55b96f1cb96b718cc6923f5344454

💬 TheCharlatan commented on pull request "Add functional test for IPC interface":
(https://github.com/bitcoin/bitcoin/pull/33201#discussion_r2324373849)
This (and the `template3` declaration above) should go too, right?

⚠️ AbelLykens opened an issue: "builds: add README with build flags"
(https://github.com/bitcoin/bitcoin/issues/33316)
### Please describe the feature you'd like to see added.

For the torrents for Bitcoin Core, as well as the [downloads on the site](https://bitcoincore.org/bin/bitcoin-core-29.1/), it would be useful to have a (small) readme with some information what the different binaries/targzs are.

<img width="423" height="745" alt="Image" src="https://github.com/user-attachments/assets/222b0a0c-6f18-417d-9903-ffa4aa1f2abb" />

Apparently there are **unsigned**, **signed**, **debug** and **codesigning** ver
...

💬 fanquake commented on pull request "Add functional test for IPC interface":
(https://github.com/bitcoin/bitcoin/pull/33201#discussion_r2324551484)
v2.1.0 has been tagged: https://github.com/capnproto/pycapnp/releases/tag/v2.1.0.

🚀 fanquake merged a pull request: "depends: strip when installing qt binaries"
(https://github.com/bitcoin/bitcoin/pull/33304)

🚀 fanquake merged a pull request: "doc: archive v29.1 release notes"
(https://github.com/bitcoin/bitcoin/pull/33309)

✅ fanquake closed an issue: "build: suggest -DENABLE_IPC=OFF when missing capnp"
(https://github.com/bitcoin/bitcoin/issues/33315)

💬 fanquake commented on issue "build: suggest -DENABLE_IPC=OFF when missing capnp":
(https://github.com/bitcoin/bitcoin/issues/33315#issuecomment-3257701571)
Thanks, but I don't think we need a separate issue to track the subtree update, which wont be forgotten.

📝 purpleKarrot opened a pull request: "draft: CMake Goals and Guidelines"
(https://github.com/bitcoin/bitcoin/pull/33317)

💬 hodlinator commented on pull request "headerssync: Correct unrealistic unit test behavior":
(https://github.com/bitcoin/bitcoin/pull/32579#discussion_r2324586432)
Thanks for catching this! Pushed fix.

💬 hodlinator commented on pull request "headerssync: Correct unrealistic unit test behavior":
(https://github.com/bitcoin/bitcoin/pull/32579#discussion_r2324582945)
What makes a 2-statement lambda better than https://en.cppreference.com/w/cpp/language/operator_other.html#Built-in_comma_operator in this case?

Also not sure why it changes the need for the comment.

💬 TheCharlatan commented on pull request "Add functional test for IPC interface":
(https://github.com/bitcoin/bitcoin/pull/33201#discussion_r2324611489)
Or it can be fixed with the following by using the MiniWallet:
```diff
diff --git a/test/functional/interface_ipc.py b/test/functional/interface_ipc.py
index 03f0ed200c..c54e3f3a6b 100755
--- a/test/functional/interface_ipc.py
+++ b/test/functional/interface_ipc.py
@@ -11,0 +12 @@ from test_framework.test_framework import (BitcoinTestFramework, assert_equal)
+from test_framework.wallet import MiniWallet
@@ -94,0 +96,2 @@ class IPCInterfaceTest(BitcoinTestFramework):
+ miniwallet
...