Bitcoin Core Github
43 subscribers
122K links
Download Telegram
💬 l0rinc commented on pull request "net: Prevent node from binding to the same `CService`":
(https://github.com/bitcoin/bitcoin/pull/33231#discussion_r2324140790)
@yuvicc, this still needs fixing
💬 yuvicc commented on issue "InitError() doesn't always halt node startup when blockchain state exists":
(https://github.com/bitcoin/bitcoin/issues/33276#issuecomment-3257139172)
Tried on my local system, I was able to reproduce that.

```
2025-09-05T05:39:58Z UpdateTip: new best=000000004b6da5bbb89d6602b47021c817837330c94c92ffdf0fe7a3fc65fa57 height=1057 version=0x00000001 log2_work=42.047146 tx=1079 date='2009-01-19T19:36:59Z' progress=0.000001 cache=0.3MiB(74txo)
2025-09-05T05:39:58Z UpdateTip: new best=00000000d357309918e1e2586ca15141650f39b8097169274ccdba05991a87b3 height=1058 version=0x00000001 log2_work=42.048509 tx=1080 date='2009-01-19T19:43:41Z' progress=0.0000
...
💬 kannapoix commented on pull request "doc: update multisig tutorial to use multipath descriptors":
(https://github.com/bitcoin/bitcoin/pull/33286#issuecomment-3257174144)
ACK 226836e70501abf9ac2434900e74eec31edd716e

I followed the new instruction and successfully spend from multisig wallet: https://mempool.space/signet/tx/6b5b7922b68b6becfc3aea5a541ce700837d5105d332889929b46cf1428df4a4

Although not directly related to this PR, I have a minor suggestion: it might be helpful to add a loadwallet command for multisig_wallet_01, not just for participant wallets.

````diff
diff --git a/doc/multisig-tutorial.md b/doc/multisig-tutorial.md
index fa6366df91d..352
...
💬 TheCharlatan commented on pull request "Add functional test for IPC interface":
(https://github.com/bitcoin/bitcoin/pull/33201#discussion_r2324220680)
That seems fine, though it would be good to get the fee bumping functionality tested here (in a follow up).
💬 Sjors commented on pull request "build: suggest -DENABLE_IPC=OFF when missing capnp":
(https://github.com/bitcoin/bitcoin/pull/33290#discussion_r2324239243)
Let's go for that approach then.
Sjors closed a pull request: "build: suggest -DENABLE_IPC=OFF when missing capnp"
(https://github.com/bitcoin/bitcoin/pull/33290)
💬 Sjors commented on pull request "build: suggest -DENABLE_IPC=OFF when missing capnp":
(https://github.com/bitcoin/bitcoin/pull/33290#issuecomment-3257244295)
Closing in favour of https://github.com/bitcoin-core/libmultiprocess/pull/205.
⚠️ Sjors opened an issue: "build: suggest -DENABLE_IPC=OFF when missing capnp"
(https://github.com/bitcoin/bitcoin/issues/33315)
Placeholder for the closed PR #33290.

Currently being worked on in https://github.com/bitcoin-core/libmultiprocess/pull/205

After which we'll need a subtree update.
💬 Sjors commented on pull request "build: suggest -DENABLE_IPC=OFF when missing capnp":
(https://github.com/bitcoin/bitcoin/pull/33290#issuecomment-3257248291)
#33315 could be added to the v30 milestone so we don't forget.
💬 l0rinc commented on pull request "net: Prevent node from binding to the same `CService`":
(https://github.com/bitcoin/bitcoin/pull/33231#issuecomment-3257251460)
ACK 4d4789dffad55b96f1cb96b718cc6923f5344454
💬 w0xlt commented on pull request "net: Prevent node from binding to the same `CService`":
(https://github.com/bitcoin/bitcoin/pull/33231#discussion_r2324248666)
Good catch, fixed in 4d4789dffad55b96f1cb96b718cc6923f5344454. Thanks.
💬 Sjors commented on pull request "multiprocess: Don't require bitcoin -m argument when IPC options are used":
(https://github.com/bitcoin/bitcoin/pull/33229#discussion_r2324249003)
No access to `self.logger` here?
💬 w0xlt commented on pull request "net: Prevent node from binding to the same `CService`":
(https://github.com/bitcoin/bitcoin/pull/33231#discussion_r2324249155)
Done in 4d4789dffad55b96f1cb96b718cc6923f5344454. Thanks.
💬 yuvicc commented on pull request "net: Prevent node from binding to the same `CService`":
(https://github.com/bitcoin/bitcoin/pull/33231#discussion_r2324251766)
> @yuvicc, this still needs fixing

Ahh, I thought that was non-blocking.
💬 yuvicc commented on pull request "net: Prevent node from binding to the same `CService`":
(https://github.com/bitcoin/bitcoin/pull/33231#issuecomment-3257261379)
re-ACK 4d4789dffad55b96f1cb96b718cc6923f5344454
💬 TheCharlatan commented on pull request "Add functional test for IPC interface":
(https://github.com/bitcoin/bitcoin/pull/33201#discussion_r2324373849)
This (and the `template3` declaration above) should go too, right?
⚠️ AbelLykens opened an issue: "builds: add README with build flags"
(https://github.com/bitcoin/bitcoin/issues/33316)
### Please describe the feature you'd like to see added.

For the torrents for Bitcoin Core, as well as the [downloads on the site](https://bitcoincore.org/bin/bitcoin-core-29.1/), it would be useful to have a (small) readme with some information what the different binaries/targzs are.

<img width="423" height="745" alt="Image" src="https://github.com/user-attachments/assets/222b0a0c-6f18-417d-9903-ffa4aa1f2abb" />

Apparently there are **unsigned**, **signed**, **debug** and **codesigning** ver
...
💬 fanquake commented on pull request "Add functional test for IPC interface":
(https://github.com/bitcoin/bitcoin/pull/33201#discussion_r2324551484)
v2.1.0 has been tagged: https://github.com/capnproto/pycapnp/releases/tag/v2.1.0.
🚀 fanquake merged a pull request: "depends: strip when installing qt binaries"
(https://github.com/bitcoin/bitcoin/pull/33304)
🚀 fanquake merged a pull request: "doc: archive v29.1 release notes"
(https://github.com/bitcoin/bitcoin/pull/33309)