👋 Crypt-iQ's pull request is ready for review: "net: check for empty header before calling FillBlock"
(https://github.com/bitcoin/bitcoin/pull/33296)

💬 Crypt-iQ commented on pull request "net: check for empty header before calling FillBlock":
(https://github.com/bitcoin/bitcoin/pull/33296#discussion_r2320290141)
Done in 0df02ac0e870bc34c90f95d2a429e6dcc9217dfa

💬 AceHack commented on issue "Please restrict Data Carrier/OP Return to < 80 bytes please before releasing 3":
(https://github.com/bitcoin/bitcoin/issues/33298#issuecomment-3250914872)
Sorry, it seems from an outsider's point of view that you are incorrect in your assessment, and I will not be running Bitcoin Core software and will actively encourage everyone I know to look for alternatives. This may inspire me to create my own. I have a deep background in cryptographic systems and older consensus mechanisms, such as Raft and Paxos, so this is within my area of expertise. Larger miners already have several ways to hurt smaller miners within Bitcoin if they wish; it's a weakn
...

💬 AceHack commented on issue "Please restrict Data Carrier/OP Return to < 80 bytes please before releasing 3":
(https://github.com/bitcoin/bitcoin/issues/33298#issuecomment-3250958089)
From a small home miner's perspective, I have two options when using Bitcoin Core.
1) Participate in mempool, which allows mining, relying on these anonymous P2P elicit transactions, risking prosecution.
2) Disable mempool, not allowing me to mine without using someone else's node, breaking the zero-trust Satoshi's Bitcoin built.

Therefore, Bitcoin Core as of v3 is no longer for home miners and decentralized mining; it now prefers centralization of miners and caters to their needs over those of
...

💬 polespinasa commented on pull request "rpc, logging: add backgroundvalidation to getblockchaininfo":
(https://github.com/bitcoin/bitcoin/pull/33259#discussion_r2320330981)
Implemented the new method and used it also in the logs

💬 polespinasa commented on pull request "rpc, logging: add backgroundvalidation to getblockchaininfo":
(https://github.com/bitcoin/bitcoin/pull/33259#issuecomment-3250969018)
@danielabrozzoni @ajtowns @luke-jr

Tests implemented, not the cleanest way for sure, but I couldn't figure out anything simpler.
Open to suggestions :)

💬 achow101 commented on pull request "net, pcp: handle multi-part responses and filter for default route while querying default gateway":
(https://github.com/bitcoin/bitcoin/pull/32159#issuecomment-3250971643)
ACK 88db09bafe9ec363525e5e526c5f6cdd13691447

📝 Crypt-iQ opened a pull request: "fuzz: compact block harness"
(https://github.com/bitcoin/bitcoin/pull/33300)
Posting up to get feedback, there are some design flaws with the approach in this PR. Coverage is [here](https://crypt-iq.github.io/fuzz_coverage_reports/cmpctblock-aflpp-and-libfuzzer-cov-08282025/) (look in `src/blockencodings.cpp`, relevant compact block bits in `src/net_processing.cpp`).

This harness can make (in)valid blocks, reconstruct blocks with in-mempool txns, and has high stability in AFL++ (~98-99%).

The main downside is that there are filesystem operations. In the `.init` fun
...

💬 polespinasa commented on pull request "rpc, logging: add backgroundvalidation to getblockchaininfo":
(https://github.com/bitcoin/bitcoin/pull/33259#discussion_r2320379705)
done in a48d92a5fb4c443dbf615715c8f25d1de9cabc9e

💬 AceHack commented on issue "Please restrict Data Carrier/OP Return to < 80 bytes please before releasing 3":
(https://github.com/bitcoin/bitcoin/issues/33298#issuecomment-3251035625)
I have five children, four of whom are girls. It makes me angry to think some dumb ex-boyfriend without any effort at all can stick underage pictures of her easily in the OP_RETURN on the blockchain for anyone to see, and it's there forever, immortalized on the blockchain and bitcoin core can decode without additional software. I would make it my life's mission to destroy Bitcoin if that ever happened, even though I currently have immense love for it. I imagine any person who thinks of their f
...

📝 davidgumberg opened a pull request: "gui: Avoid pathological QT text/markdown behavior..."
(https://github.com/bitcoin-core/gui/pull/886)
...during text selection by only setting plaintext mime data.

Fixes the OOM described in https://github.com/bitcoin/bitcoin/issues/33285.

The issue is related to the construction of the [`text/markdown`](https://github.com/qt/qtbase/blob/b617d1176593963a2a9ed21dd5d9a63e84a09400/src/widgets/widgets/qwidgettextcontrol.cpp#L3539) MIME data for the selection. Using the `heaptrack` utility, I observed that nearly all of the allocations when reproducing happen in https://github.com/bitcoin/bitco
...

💬 davidgumberg commented on issue "GUI (?): Copying output from console causes large mem usage/OOM":
(https://github.com/bitcoin/bitcoin/issues/33285#issuecomment-3251123253)
I have opened a fix here: https://github.com/bitcoin-core/gui/pull/886.

💬 w0xlt commented on pull request "gui: Avoid pathological QT text/markdown behavior...":
(https://github.com/bitcoin-core/gui/pull/886#issuecomment-3251127500)
Concept ACK

💬 davidgumberg commented on pull request "net, pcp: handle multi-part responses and filter for default route while querying default gateway":
(https://github.com/bitcoin/bitcoin/pull/32159#issuecomment-3251165278)
Code Review re-ACK 88db09b

```console
$ git range-diff 4c53178...88db09b
```

https://github.com/bitcoin/bitcoin/commit/88db09bafe9ec363525e5e526c5f6cdd13691447 takes the [reviewer suggestion](https://github.com/bitcoin/bitcoin/pull/32159#discussion_r2302222710) of moving the `rtmsg*` cast after checking if `hdr->nlmsg_type == NLMSG_DONE`which resolves https://github.com/bitcoin/bitcoin/issues/33245 and implements [a suggested refactor](https://github.com/bitcoin/bitcoin/pull/32159#discus
...

💬 151henry151 commented on pull request "build: Remove deprecated CMAKE_SKIP_BUILD_RPATH and SKIP_BUILD_RPATH settings":
(https://github.com/bitcoin/bitcoin/pull/33247#discussion_r2320500599)
I think these have been squashed correctly to address these clumsy mistakes and that the final three commits in the pull request reflect this.

💬 151henry151 commented on pull request "build: Remove deprecated CMAKE_SKIP_BUILD_RPATH and SKIP_BUILD_RPATH settings":
(https://github.com/bitcoin/bitcoin/pull/33247#discussion_r2320501230)
I believe this has already been addressed by squashing the relevant commits.

👍 ryanofsky approved a pull request: "Add functional test for IPC interface"
(https://github.com/bitcoin/bitcoin/pull/33201#pullrequestreview-3183296138)
Code review ACK db52550507045402e89c6455bec680fcd61e26b6, just making small suggested changes since last review: fixing up pycapnp install instructions, using --break-system-packages only where needed, making small test cleanups

💬 romanz commented on pull request "index: store per-block transaction locations for efficient lookups":
(https://github.com/bitcoin/bitcoin/pull/32541#discussion_r2320865276)
It seems that OS block cache is quite effective (even with `/*cache_size=*/0`), so I am getting similar performance when using 3GiB DB cache compared to https://github.com/bitcoin/bitcoin/pull/32541#issuecomment-3250323045.

Tested with the patch below:
```
$ ab -k -c 1 -n 100000 http://localhost:8332/rest/txfromblock/$BLOCKHASH-5000.bin
...
Document Path: /rest/txfromblock/000000000000000000017bfd05b5fa367a424c4a565a4baf7950d9e8605df8ec-5000.bin
Document Length: 234 bytes
...

👋 romanz's pull request is ready for review: "index: store per-block transaction locations for efficient lookups"
(https://github.com/bitcoin/bitcoin/pull/32541)

💬 maflcko commented on pull request "build: Remove deprecated CMAKE_SKIP_BUILD_RPATH and SKIP_BUILD_RPATH settings":
(https://github.com/bitcoin/bitcoin/pull/33247#issuecomment-3252077408)
Please squash your commits according to https://github.com/bitcoin/bitcoin/blob/master/CONTRIBUTING.md#squashing-commits