💬 sipa commented on pull request "Add functional test for IPC interface":
(https://github.com/bitcoin/bitcoin/pull/33201#discussion_r2319858473)
Fixed.

💬 sipa commented on pull request "Add functional test for IPC interface":
(https://github.com/bitcoin/bitcoin/pull/33201#discussion_r2319856069)
Leaving as-is.

💬 sipa commented on pull request "Add functional test for IPC interface":
(https://github.com/bitcoin/bitcoin/pull/33201#discussion_r2319857541)
Done.

💬 sipa commented on pull request "Add functional test for IPC interface":
(https://github.com/bitcoin/bitcoin/pull/33201#discussion_r2319857383)
Fixed.

💬 sipa commented on pull request "Add functional test for IPC interface":
(https://github.com/bitcoin/bitcoin/pull/33201#discussion_r2319857246)
Fixed.

💬 sipa commented on pull request "Add functional test for IPC interface":
(https://github.com/bitcoin/bitcoin/pull/33201#discussion_r2319857067)
I've removed it; let's see where CI breaks.

💬 romanz commented on pull request "index: store per-block transaction locations for efficient lookups":
(https://github.com/bitcoin/bitcoin/pull/32541#issuecomment-3250359798)
Ran the same test using `hey` 0.1.4 - enabling `locationsindex` improves the performance ~15.8x (2.963ms → 0.187ms)

## `-locationsindex=1`
```
hey -c 1 -n 10000 http://localhost:8332/rest/txfromblock/$BLOCKHASH-5000.bin

Summary:
Total: 1.8766 secs
Slowest: 0.0686 secs
Fastest: 0.0001 secs
Average: 0.0002 secs
Requests/sec: 5328.8354

Total data: 2340000 bytes
Size/request: 234 bytes

Response time histogram:
0.000 [1] |
0.007 [9998] |■■■■■■■■■■■■■■■■■■■■■
...

💬 romanz commented on pull request "index: store per-block transaction locations for efficient lookups":
(https://github.com/bitcoin/bitcoin/pull/32541#discussion_r2319877158)
Yes - but if it's OK, I would prefer to do it in a separate PR.

💬 achow101 commented on pull request "wallet: Be able to receive and spend inputs involving MuSig2 aggregate keys":
(https://github.com/bitcoin/bitcoin/pull/29675#discussion_r2319894112)
Changed to `part_pubkeys`.

💬 achow101 commented on pull request "wallet: Be able to receive and spend inputs involving MuSig2 aggregate keys":
(https://github.com/bitcoin/bitcoin/pull/29675#discussion_r2319894334)
Done

💬 achow101 commented on pull request "wallet: Be able to receive and spend inputs involving MuSig2 aggregate keys":
(https://github.com/bitcoin/bitcoin/pull/29675#discussion_r2319894625)
Done

💬 achow101 commented on pull request "wallet: Be able to receive and spend inputs involving MuSig2 aggregate keys":
(https://github.com/bitcoin/bitcoin/pull/29675#discussion_r2319894903)
Done

💬 romanz commented on pull request "index: store per-block transaction locations for efficient lookups":
(https://github.com/bitcoin/bitcoin/pull/32541#discussion_r2319896447)
[94389c28e1...56e621d9f1](https://github.com/bitcoin/bitcoin/compare/94389c28e1068ffcc116614d16ac3047eb3068e3..56e621d9f16b3ed56089fa4760cf2b1b00a67362)

💬 romanz commented on pull request "index: store per-block transaction locations for efficient lookups":
(https://github.com/bitcoin/bitcoin/pull/32541#discussion_r2319897284)
94389c28e1...56e621d9f1

💬 darosior commented on pull request "kernel: chainparams & headersync updates for 30.0":
(https://github.com/bitcoin/bitcoin/pull/33274#discussion_r2319880154)
7 weeks ago :grimacing: just in case, heh?

🤔 darosior reviewed a pull request: "kernel: chainparams & headersync updates for 30.0"
(https://github.com/bitcoin/bitcoin/pull/33274#pullrequestreview-3181990147)
-----BEGIN PGP SIGNED MESSAGE-----
Hash: SHA512

ACK 755152ac819a23acf2f9e70316134d74a04d589b. Verified assumevalid, chainwork and stats for mainnet, testnet4 and signet. Verified the serialized utxo set hash for mainnet. Haven't verified header params. Haven't verified for testnet3.
-----BEGIN PGP SIGNATURE-----

iQGzBAEBCgAdFiEEWQtykmla/6W2csuy4T/BRc0/QwQFAmi4kLsACgkQ4T/BRc0/
QwRjPQwArKJge7cs43ejKvvxbtsNtjDfc97jj1CnDtIEJuzKzglFzbdNh0/RY9ef
eAWh04+HhUv2FgNbCIL7PnWLletazPlW0GhTroRqhQsgU/
...

💬 w0xlt commented on pull request "doc: update multisig tutorial to use multipath descriptors":
(https://github.com/bitcoin/bitcoin/pull/33286#issuecomment-3250432274)
Concept ACK

💬 davidgumberg commented on pull request "Revert compact block cache inefficiencies":
(https://github.com/bitcoin/bitcoin/pull/33253#issuecomment-3250442844)
I run a master node on mainnet with `debug=cmpctblock` and `logtimemicros=1`, and the average time between the "Initializing PartiallyDownloadedBlock" message at the [beginning](https://github.com/bitcoin/bitcoin/blob/689a32197638e92995dd8eb071425715f5fdc3a4/src/blockencodings.cpp#L57) of `InitData` and the "Initialized" message at the [end](https://github.com/bitcoin/bitcoin/blob/689a32197638e92995dd8eb071425715f5fdc3a4/src/blockencodings.cpp#L174) is 2.8ms, so the ~20% speedup here to `InitDa
...

💬 ryanofsky commented on issue "intermittent Segmentation fault in mptest IPC path (callFnAsyncParams)":
(https://github.com/bitcoin/bitcoin/issues/33277#issuecomment-3250471220)
This is probably caused by the disconnect-right-before-IPC-call-returns race condition described in https://github.com/bitcoin-core/libmultiprocess/issues/189 and fixed in https://github.com/bitcoin-core/libmultiprocess/issues/201

💬 ryanofsky commented on pull request "Add functional test for IPC interface":
(https://github.com/bitcoin/bitcoin/pull/33201#discussion_r2319974959)
re: https://github.com/bitcoin/bitcoin/pull/33201#discussion_r2319857067

> I've removed it; let's see where CI breaks.

Thanks! For reference, the error on ubuntu seems to be:

```
+ retry -- pip3 install --user pycapnp
error: externally-managed-environment

× This environment is externally managed
╰─> To install Python packages system-wide, try apt install
python3-xyz, where xyz is the package you are trying to
install.

If you wish to install a non-Debian-packag
...