💬 Sjors commented on pull request "Drop testnet3":
(https://github.com/bitcoin/bitcoin/pull/31974#issuecomment-3248728171)
Rebased after #33274.

💬 maflcko commented on pull request "build: suggest -DENABLE_IPC=OFF when missing capnp":
(https://github.com/bitcoin/bitcoin/pull/33290#issuecomment-3248736383)
> > Very strange CI errors:
> > ```
> > 03:45:32.525] -- Configuring incomplete, errors occurred!
> > [03:45:32.543] ++ cmake -P /ci_container_base/ci/test/GetCMakeLogFiles.cmake
> > [03:45:32.586] + cat CMakeFiles/CMakeConfigureLog.yaml
> > [03:45:32.587] cat: CMakeFiles/CMakeConfigureLog.yaml: No such file or directory
> > [03:45:32.621] Command '['./ci/test/02_run_container.sh']' returned non-zero exit status 1.
> > ```
>
> It seems a behaviour change overlooked in #32880.

Sorry,
...

💬 maflcko commented on pull request "build: suggest -DENABLE_IPC=OFF when missing capnp":
(https://github.com/bitcoin/bitcoin/pull/33290#issuecomment-3248739073)
Mind submitting ed95f4f095fecb0a6e5601199959db21e811dd71 as a separate pull?

💬 fanquake commented on issue "GUI (?): Copying output from console causes large mem usage/OOM":
(https://github.com/bitcoin/bitcoin/issues/33285#issuecomment-3248743548)
cc @hebasto

💬 maflcko commented on issue "GUI (?): Copying output from console causes large mem usage/OOM":
(https://github.com/bitcoin/bitcoin/issues/33285#issuecomment-3248757351)
I have the impression that this was already reported years ago, but I couldn't find a reference either.

✅ maflcko closed a pull request: "Bugfix: Correct first-run free space checks"
(https://github.com/bitcoin/bitcoin/pull/29678)

📝 maflcko reopened a pull request: "Bugfix: Correct first-run free space checks"
(https://github.com/bitcoin/bitcoin/pull/29678)
It's not clear what `m_assumed_*_size` are actually set based on, but historically it was in GB, not GiB, and that's still used in the GUI which is more user-facing.

Could just as easily change the GUI if GiB is preferred.

💬 maflcko commented on issue "Revisiting us self-hosting parts of our CI":
(https://github.com/bitcoin/bitcoin/issues/31965#issuecomment-3248800808)
Another follow-up idea would be to port https://0xb10c.github.io/bitcoin-core-ci-stats/graph/ to GHA, to see if this improved/worsened scheduling/runtime.

💬 hodlinator commented on pull request "kernel: chainparams & headersync updates for 30.0":
(https://github.com/bitcoin/bitcoin/pull/33274#discussion_r2318642302)
Could be a case of the worst selection highlight UI ever.
<img width="626" height="255" alt="Screenshot From 2025-09-03 12-50-23" src="https://github.com/user-attachments/assets/9f5e5b6e-5253-4424-9227-0b3c57a0b31e" />
I have the file.

(My client claims the port is open (probably thank to my router reset), so I'm not intentionally leeching, just low demand).

💬 0xB10C commented on issue "Revisiting us self-hosting parts of our CI":
(https://github.com/bitcoin/bitcoin/issues/31965#issuecomment-3248830954)
> Another follow-up idea would be to port https://0xb10c.github.io/bitcoin-core-ci-stats/graph/ to GHA, to see if this improved/worsened scheduling/runtime.

Tracking this here: https://github.com/0xB10C/bitcoin-core-ci-stats/issues/8

💬 Sjors commented on pull request "build: suggest -DENABLE_IPC=OFF when missing capnp":
(https://github.com/bitcoin/bitcoin/pull/33290#issuecomment-3248845988)
@maflcko I prefer if someone else does it, as I don't really know what this part of CI is doing.

Also, it those builds still break.

💬 Sjors commented on pull request "Remove Taproot activation height":
(https://github.com/bitcoin/bitcoin/pull/26201#issuecomment-3248857879)
Rebased after #33274.

💬 hodlinator commented on pull request "kernel: chainparams & headersync updates for 30.0":
(https://github.com/bitcoin/bitcoin/pull/33274#discussion_r2318683180)
```
2025-09-03T11:27:15Z [snapshot] snapshot beginning at 0000000002ebe8bcda020e0dd6ccfbdfac531d2f6a81457191b99fc2df2dbe3b has been fully validated
```
Had to restart node for the 2nd chainstate to be deleted after doing a 2nd round of validation (same as mainnet https://github.com/bitcoin/bitcoin/pull/33274#discussion_r2318454867):
```
2025-09-03T11:28:14Z [snapshot] computing UTXO stats for background chainstate to validate snapshot - this could take a few minutes
2025-09-03T11:28:22Z [s
...

💬 maflcko commented on pull request "build: suggest -DENABLE_IPC=OFF when missing capnp":
(https://github.com/bitcoin/bitcoin/pull/33290#issuecomment-3248896883)
> Also, those builds still break.

That is expected. https://github.com/bitcoin/bitcoin/commit/ed95f4f095fecb0a6e5601199959db21e811dd71 must not interfere with unrelated issues. The reason why your build fails is because you are adding the targets twice. (You can see this by reading the log)

👍 hodlinator approved a pull request: "macdeploy: avoid use of `Bitcoin Core` in Linux cross build"
(https://github.com/bitcoin/bitcoin/pull/33158#pullrequestreview-3180244945)
ACK 921c6ba251494b4970025166a3e25cf20789da66

Good to rename `osx_volname` to `macos_zip` since it's more modern naming of the OS.

Guix output:
```
[100%] Generating dist/bitcoin-macos-app.zip
adding: Bitcoin-Qt.app/ (stored 0%)
...
[100%] Built target deploy
```

Hashes:
```
f15abfa32b63a5b007d52fb31ac148980570b77cc3be12674debdca65d092706 guix-build-921c6ba25149/output/arm64-apple-darwin/SHA256SUMS.part
b94a1863fff232cdd81f2ad4b729eae9242f80d6493afea6c7c02e871658629f guix-
...

💬 hodlinator commented on pull request "macdeploy: avoid use of `Bitcoin Core` in Linux cross build":
(https://github.com/bitcoin/bitcoin/pull/33158#discussion_r2318703303)
nit: Please remove empty newline at the beginning of the block if you retouch.

💬 fanquake commented on issue "GUI (?): Copying output from console causes large mem usage/OOM":
(https://github.com/bitcoin/bitcoin/issues/33285#issuecomment-3248931861)
I guess if it's known and has just never been fixed, maybe we should add a warning that copying from the console (too much?) might crash your node.

💬 fanquake commented on pull request "macdeploy: avoid use of `Bitcoin Core` in Linux cross build":
(https://github.com/bitcoin/bitcoin/pull/33158#discussion_r2318743803)
Dropped.

👍 hodlinator approved a pull request: "macdeploy: avoid use of `Bitcoin Core` in Linux cross build"
(https://github.com/bitcoin/bitcoin/pull/33158#pullrequestreview-3180311911)
ACK 8e434a84999c473a7295772a346cbce27888d28e

💬 jmoik commented on issue "build: secp256k1 warnings not turned into errors in MSAN job":
(https://github.com/bitcoin/bitcoin/issues/33284#issuecomment-3248965317)
I will take a look at this