💬 HowHsu commented on issue "-loadblock doesn't work":
(https://github.com/bitcoin/bitcoin/issues/33280#issuecomment-3248621270)
> are the two datadirs using the same xor.dat or was it disabled (see `-blocksxor`)?
I didn't add `-blocksxor`, but I compared two xor.dat in the two blocks dir (with `vim -b`), seems they are same.
(https://github.com/bitcoin/bitcoin/issues/33280#issuecomment-3248621270)
> are the two datadirs using the same xor.dat or was it disabled (see `-blocksxor`)?
I didn't add `-blocksxor`, but I compared two xor.dat in the two blocks dir (with `vim -b`), seems they are same.
🚀 fanquake merged a pull request: "ci: Migrate CI to hosted Cirrus Runners"
(https://github.com/bitcoin/bitcoin/pull/32989)
(https://github.com/bitcoin/bitcoin/pull/32989)
💬 Sjors commented on pull request "kernel: chainparams & headersync updates for 30.0":
(https://github.com/bitcoin/bitcoin/pull/33274#discussion_r2318512284)
Try again, I should have a reachable seed for the next few hours.
(https://github.com/bitcoin/bitcoin/pull/33274#discussion_r2318512284)
Try again, I should have a reachable seed for the next few hours.
💬 hebasto commented on pull request "build: suggest -DENABLE_IPC=OFF when missing capnp":
(https://github.com/bitcoin/bitcoin/pull/33290#issuecomment-3248645770)
> Very strange CI errors:
>
> ```
> 03:45:32.525] -- Configuring incomplete, errors occurred!
> [03:45:32.543] ++ cmake -P /ci_container_base/ci/test/GetCMakeLogFiles.cmake
> [03:45:32.586] + cat CMakeFiles/CMakeConfigureLog.yaml
> [03:45:32.587] cat: CMakeFiles/CMakeConfigureLog.yaml: No such file or directory
> [03:45:32.621] Command '['./ci/test/02_run_container.sh']' returned non-zero exit status 1.
> ```
Suggesting this patch for a quick fix:
```diff
--- a/ci/test/03_test_scri
...
(https://github.com/bitcoin/bitcoin/pull/33290#issuecomment-3248645770)
> Very strange CI errors:
>
> ```
> 03:45:32.525] -- Configuring incomplete, errors occurred!
> [03:45:32.543] ++ cmake -P /ci_container_base/ci/test/GetCMakeLogFiles.cmake
> [03:45:32.586] + cat CMakeFiles/CMakeConfigureLog.yaml
> [03:45:32.587] cat: CMakeFiles/CMakeConfigureLog.yaml: No such file or directory
> [03:45:32.621] Command '['./ci/test/02_run_container.sh']' returned non-zero exit status 1.
> ```
Suggesting this patch for a quick fix:
```diff
--- a/ci/test/03_test_scri
...
💬 Sjors commented on pull request "build: suggest -DENABLE_IPC=OFF when missing capnp":
(https://github.com/bitcoin/bitcoin/pull/33290#issuecomment-3248663963)
Thanks @hebasto, I added a commit here to try that fix.
(https://github.com/bitcoin/bitcoin/pull/33290#issuecomment-3248663963)
Thanks @hebasto, I added a commit here to try that fix.
💬 marcofleon commented on pull request "build: set ENABLE_IPC to OFF when fuzzing":
(https://github.com/bitcoin/bitcoin/pull/33235#issuecomment-3248680571)
ACK af4156ab75565acc5a71b68e70da5e2cf407df80
I've decided to take the fuzzamoto approach, as I believe it'll be the best way to uncover bugs. In any case, disabling IPC for fuzz builds makes sense, at least until we have fuzz tests that need it.
(https://github.com/bitcoin/bitcoin/pull/33235#issuecomment-3248680571)
ACK af4156ab75565acc5a71b68e70da5e2cf407df80
I've decided to take the fuzzamoto approach, as I believe it'll be the best way to uncover bugs. In any case, disabling IPC for fuzz builds makes sense, at least until we have fuzz tests that need it.
💬 maflcko commented on pull request "ci: Migrate CI to hosted Cirrus Runners":
(https://github.com/bitcoin/bitcoin/pull/32989#discussion_r2318569513)
nit in 9c2b96e0d0303708710f9fbca3f9fdcb2fff21c1: Actually, on a second thought, this seems a bit fragile. It seems this would break the use-case of using several different local folders to run the CI, because the CI images have different, non-deterministic, paths embedded?
I presume the correct fix would be to download the sdk to a hard-coded path in the container image, and then adjust the pre-existing rsync call to copy it at runtime in the container, if needed.
(https://github.com/bitcoin/bitcoin/pull/32989#discussion_r2318569513)
nit in 9c2b96e0d0303708710f9fbca3f9fdcb2fff21c1: Actually, on a second thought, this seems a bit fragile. It seems this would break the use-case of using several different local folders to run the CI, because the CI images have different, non-deterministic, paths embedded?
I presume the correct fix would be to download the sdk to a hard-coded path in the container image, and then adjust the pre-existing rsync call to copy it at runtime in the container, if needed.
💬 Sjors commented on pull request "Drop testnet3":
(https://github.com/bitcoin/bitcoin/pull/31974#issuecomment-3248728171)
Rebased after #33274.
(https://github.com/bitcoin/bitcoin/pull/31974#issuecomment-3248728171)
Rebased after #33274.
💬 maflcko commented on pull request "build: suggest -DENABLE_IPC=OFF when missing capnp":
(https://github.com/bitcoin/bitcoin/pull/33290#issuecomment-3248736383)
> > Very strange CI errors:
> > ```
> > 03:45:32.525] -- Configuring incomplete, errors occurred!
> > [03:45:32.543] ++ cmake -P /ci_container_base/ci/test/GetCMakeLogFiles.cmake
> > [03:45:32.586] + cat CMakeFiles/CMakeConfigureLog.yaml
> > [03:45:32.587] cat: CMakeFiles/CMakeConfigureLog.yaml: No such file or directory
> > [03:45:32.621] Command '['./ci/test/02_run_container.sh']' returned non-zero exit status 1.
> > ```
>
> It seems a behaviour change overlooked in #32880.
Sorry,
...
(https://github.com/bitcoin/bitcoin/pull/33290#issuecomment-3248736383)
> > Very strange CI errors:
> > ```
> > 03:45:32.525] -- Configuring incomplete, errors occurred!
> > [03:45:32.543] ++ cmake -P /ci_container_base/ci/test/GetCMakeLogFiles.cmake
> > [03:45:32.586] + cat CMakeFiles/CMakeConfigureLog.yaml
> > [03:45:32.587] cat: CMakeFiles/CMakeConfigureLog.yaml: No such file or directory
> > [03:45:32.621] Command '['./ci/test/02_run_container.sh']' returned non-zero exit status 1.
> > ```
>
> It seems a behaviour change overlooked in #32880.
Sorry,
...
💬 maflcko commented on pull request "build: suggest -DENABLE_IPC=OFF when missing capnp":
(https://github.com/bitcoin/bitcoin/pull/33290#issuecomment-3248739073)
Mind submitting ed95f4f095fecb0a6e5601199959db21e811dd71 as a separate pull?
(https://github.com/bitcoin/bitcoin/pull/33290#issuecomment-3248739073)
Mind submitting ed95f4f095fecb0a6e5601199959db21e811dd71 as a separate pull?
💬 fanquake commented on issue "GUI (?): Copying output from console causes large mem usage/OOM":
(https://github.com/bitcoin/bitcoin/issues/33285#issuecomment-3248743548)
cc @hebasto
(https://github.com/bitcoin/bitcoin/issues/33285#issuecomment-3248743548)
cc @hebasto
💬 maflcko commented on issue "GUI (?): Copying output from console causes large mem usage/OOM":
(https://github.com/bitcoin/bitcoin/issues/33285#issuecomment-3248757351)
I have the impression that this was already reported years ago, but I couldn't find a reference either.
(https://github.com/bitcoin/bitcoin/issues/33285#issuecomment-3248757351)
I have the impression that this was already reported years ago, but I couldn't find a reference either.
✅ maflcko closed a pull request: "Bugfix: Correct first-run free space checks"
(https://github.com/bitcoin/bitcoin/pull/29678)
(https://github.com/bitcoin/bitcoin/pull/29678)
📝 maflcko reopened a pull request: "Bugfix: Correct first-run free space checks"
(https://github.com/bitcoin/bitcoin/pull/29678)
It's not clear what `m_assumed_*_size` are actually set based on, but historically it was in GB, not GiB, and that's still used in the GUI which is more user-facing.
Could just as easily change the GUI if GiB is preferred.
(https://github.com/bitcoin/bitcoin/pull/29678)
It's not clear what `m_assumed_*_size` are actually set based on, but historically it was in GB, not GiB, and that's still used in the GUI which is more user-facing.
Could just as easily change the GUI if GiB is preferred.
💬 maflcko commented on issue "Revisiting us self-hosting parts of our CI":
(https://github.com/bitcoin/bitcoin/issues/31965#issuecomment-3248800808)
Another follow-up idea would be to port https://0xb10c.github.io/bitcoin-core-ci-stats/graph/ to GHA, to see if this improved/worsened scheduling/runtime.
(https://github.com/bitcoin/bitcoin/issues/31965#issuecomment-3248800808)
Another follow-up idea would be to port https://0xb10c.github.io/bitcoin-core-ci-stats/graph/ to GHA, to see if this improved/worsened scheduling/runtime.
💬 hodlinator commented on pull request "kernel: chainparams & headersync updates for 30.0":
(https://github.com/bitcoin/bitcoin/pull/33274#discussion_r2318642302)
Could be a case of the worst selection highlight UI ever.
<img width="626" height="255" alt="Screenshot From 2025-09-03 12-50-23" src="https://github.com/user-attachments/assets/9f5e5b6e-5253-4424-9227-0b3c57a0b31e" />
I have the file.
(My client claims the port is open (probably thank to my router reset), so I'm not intentionally leeching, just low demand).
(https://github.com/bitcoin/bitcoin/pull/33274#discussion_r2318642302)
Could be a case of the worst selection highlight UI ever.
<img width="626" height="255" alt="Screenshot From 2025-09-03 12-50-23" src="https://github.com/user-attachments/assets/9f5e5b6e-5253-4424-9227-0b3c57a0b31e" />
I have the file.
(My client claims the port is open (probably thank to my router reset), so I'm not intentionally leeching, just low demand).
💬 0xB10C commented on issue "Revisiting us self-hosting parts of our CI":
(https://github.com/bitcoin/bitcoin/issues/31965#issuecomment-3248830954)
> Another follow-up idea would be to port https://0xb10c.github.io/bitcoin-core-ci-stats/graph/ to GHA, to see if this improved/worsened scheduling/runtime.
Tracking this here: https://github.com/0xB10C/bitcoin-core-ci-stats/issues/8
(https://github.com/bitcoin/bitcoin/issues/31965#issuecomment-3248830954)
> Another follow-up idea would be to port https://0xb10c.github.io/bitcoin-core-ci-stats/graph/ to GHA, to see if this improved/worsened scheduling/runtime.
Tracking this here: https://github.com/0xB10C/bitcoin-core-ci-stats/issues/8
💬 Sjors commented on pull request "build: suggest -DENABLE_IPC=OFF when missing capnp":
(https://github.com/bitcoin/bitcoin/pull/33290#issuecomment-3248845988)
@maflcko I prefer if someone else does it, as I don't really know what this part of CI is doing.
Also, it those builds still break.
(https://github.com/bitcoin/bitcoin/pull/33290#issuecomment-3248845988)
@maflcko I prefer if someone else does it, as I don't really know what this part of CI is doing.
Also, it those builds still break.
💬 Sjors commented on pull request "Remove Taproot activation height":
(https://github.com/bitcoin/bitcoin/pull/26201#issuecomment-3248857879)
Rebased after #33274.
(https://github.com/bitcoin/bitcoin/pull/26201#issuecomment-3248857879)
Rebased after #33274.
💬 hodlinator commented on pull request "kernel: chainparams & headersync updates for 30.0":
(https://github.com/bitcoin/bitcoin/pull/33274#discussion_r2318683180)
```
2025-09-03T11:27:15Z [snapshot] snapshot beginning at 0000000002ebe8bcda020e0dd6ccfbdfac531d2f6a81457191b99fc2df2dbe3b has been fully validated
```
Had to restart node for the 2nd chainstate to be deleted after doing a 2nd round of validation (same as mainnet https://github.com/bitcoin/bitcoin/pull/33274#discussion_r2318454867):
```
2025-09-03T11:28:14Z [snapshot] computing UTXO stats for background chainstate to validate snapshot - this could take a few minutes
2025-09-03T11:28:22Z [s
...
(https://github.com/bitcoin/bitcoin/pull/33274#discussion_r2318683180)
```
2025-09-03T11:27:15Z [snapshot] snapshot beginning at 0000000002ebe8bcda020e0dd6ccfbdfac531d2f6a81457191b99fc2df2dbe3b has been fully validated
```
Had to restart node for the 2nd chainstate to be deleted after doing a 2nd round of validation (same as mainnet https://github.com/bitcoin/bitcoin/pull/33274#discussion_r2318454867):
```
2025-09-03T11:28:14Z [snapshot] computing UTXO stats for background chainstate to validate snapshot - this could take a few minutes
2025-09-03T11:28:22Z [s
...