💬 hodlinator commented on pull request "kernel: chainparams & headersync updates for 30.0":
(https://github.com/bitcoin/bitcoin/pull/33274#discussion_r2318451553)
`MINCHAINWORK_HEADERS` matches assume valid block and `HEADER_COMMITMENT_PERIOD` + `REDOWNLOAD_BUFFER_SIZE` are close to numbers predicted for this release in #32579.

💬 hodlinator commented on pull request "kernel: chainparams & headersync updates for 30.0":
(https://github.com/bitcoin/bitcoin/pull/33274#discussion_r2318446931)
My *~/.bitcoin/* dir was 736G after removing other chains. Seldom online with that node, so will not have many stale blocks, but it's in a similar ballpark. Same for chainstate which was 11G.

Increases in other chains seem reasonable.

💬 hodlinator commented on pull request "kernel: chainparams & headersync updates for 30.0":
(https://github.com/bitcoin/bitcoin/pull/33274#discussion_r2318449630)
Mainnet matches output from:
```
₿ bitcoin-cli getchaintxstats 4096 00000000000000000000611fd22f2df7c8fbd0688745c3a6c3bb5109cc2a12cb
```
Others seem acceptable.

💬 hodlinator commented on pull request "kernel: chainparams & headersync updates for 30.0":
(https://github.com/bitcoin/bitcoin/pull/33274#discussion_r2318454867)
Mainnet assume UTXO block confirmed:
```
₿ bitcoin-cli getblock 0000000000000000000108970acb9522ffd516eae17acddcb1bd16469194a821
{
"hash": "0000000000000000000108970acb9522ffd516eae17acddcb1bd16469194a821",
"confirmations": 2908,
"height": 910000,
```
Downloaded torrent as kindly provided by Sjors.

<details><summary>Loaded assume utxo snapshot, saw some odd behavior with validating 2 times and only removing the second chainstate directory after restarting. But snapshot worked.</
...

💬 hodlinator commented on pull request "kernel: chainparams & headersync updates for 30.0":
(https://github.com/bitcoin/bitcoin/pull/33274#discussion_r2318448632)
Mainnet assume valid block checks out:
```
₿ bitcoin-cli getblock 00000000000000000000611fd22f2df7c8fbd0688745c3a6c3bb5109cc2a12cb
{
"hash": "00000000000000000000611fd22f2df7c8fbd0688745c3a6c3bb5109cc2a12cb",
"confirmations": 181,
"height": 912683,
...
"chainwork": "0000000000000000000000000000000000000000dee8e2a309ad8a9820433c68",
```

Other chains all increased minimum chainwork as expected.

💬 hodlinator commented on pull request "kernel: chainparams & headersync updates for 30.0":
(https://github.com/bitcoin/bitcoin/pull/33274#discussion_r2318362184)
Unlike the mainnet one, this one will not download for me. :\

💬 Sjors commented on pull request "doc: update multisig tutorial to use multipath descriptors":
(https://github.com/bitcoin/bitcoin/pull/33286#issuecomment-3248584420)
Concept ACK

#32784 contains a similar change, but it's nice to do that separately and earlier.

💬 purpleKarrot commented on issue "cmake: Errors not actually errors?":
(https://github.com/bitcoin/bitcoin/issues/33153#issuecomment-3248587531)
I would suggest the following changes:

* Revert fdbade6f8ded63519b637c8fa6f39914a400ab5e
* Install the kernel library *iff* it is built as a shared library.
* Export cmake package configuration *iff* the kernel is built as a shared library.
* Don't install a `.pc` file for the kernel at all.

Rationale:

`.pc` files are not relocatable and only work when all packages are installed to a common prefix, which is done by package managers. Since we want to distribute our own packages, we have no way
...

🚀 fanquake merged a pull request: "kernel: chainparams & headersync updates for 30.0"
(https://github.com/bitcoin/bitcoin/pull/33274)

💬 hebasto commented on pull request "build: suggest -DENABLE_IPC=OFF when missing capnp":
(https://github.com/bitcoin/bitcoin/pull/33290#issuecomment-3248603469)
> Very strange CI errors:
>
> ```
> 03:45:32.525] -- Configuring incomplete, errors occurred!
> [03:45:32.543] ++ cmake -P /ci_container_base/ci/test/GetCMakeLogFiles.cmake
> [03:45:32.586] + cat CMakeFiles/CMakeConfigureLog.yaml
> [03:45:32.587] cat: CMakeFiles/CMakeConfigureLog.yaml: No such file or directory
> [03:45:32.621] Command '['./ci/test/02_run_container.sh']' returned non-zero exit status 1.
> ```

It seems a behaviour change overlooked in https://github.com/bitcoin/bitcoi
...

💬 HowHsu commented on issue "-loadblock doesn't work":
(https://github.com/bitcoin/bitcoin/issues/33280#issuecomment-3248621270)
> are the two datadirs using the same xor.dat or was it disabled (see `-blocksxor`)?

I didn't add `-blocksxor`, but I compared two xor.dat in the two blocks dir (with `vim -b`), seems they are same.

🚀 fanquake merged a pull request: "ci: Migrate CI to hosted Cirrus Runners"
(https://github.com/bitcoin/bitcoin/pull/32989)

💬 Sjors commented on pull request "kernel: chainparams & headersync updates for 30.0":
(https://github.com/bitcoin/bitcoin/pull/33274#discussion_r2318512284)
Try again, I should have a reachable seed for the next few hours.

💬 hebasto commented on pull request "build: suggest -DENABLE_IPC=OFF when missing capnp":
(https://github.com/bitcoin/bitcoin/pull/33290#issuecomment-3248645770)
> Very strange CI errors:
>
> ```
> 03:45:32.525] -- Configuring incomplete, errors occurred!
> [03:45:32.543] ++ cmake -P /ci_container_base/ci/test/GetCMakeLogFiles.cmake
> [03:45:32.586] + cat CMakeFiles/CMakeConfigureLog.yaml
> [03:45:32.587] cat: CMakeFiles/CMakeConfigureLog.yaml: No such file or directory
> [03:45:32.621] Command '['./ci/test/02_run_container.sh']' returned non-zero exit status 1.
> ```

Suggesting this patch for a quick fix:
```diff
--- a/ci/test/03_test_scri
...

💬 Sjors commented on pull request "build: suggest -DENABLE_IPC=OFF when missing capnp":
(https://github.com/bitcoin/bitcoin/pull/33290#issuecomment-3248663963)
Thanks @hebasto, I added a commit here to try that fix.

💬 marcofleon commented on pull request "build: set ENABLE_IPC to OFF when fuzzing":
(https://github.com/bitcoin/bitcoin/pull/33235#issuecomment-3248680571)
ACK af4156ab75565acc5a71b68e70da5e2cf407df80

I've decided to take the fuzzamoto approach, as I believe it'll be the best way to uncover bugs. In any case, disabling IPC for fuzz builds makes sense, at least until we have fuzz tests that need it.

💬 maflcko commented on pull request "ci: Migrate CI to hosted Cirrus Runners":
(https://github.com/bitcoin/bitcoin/pull/32989#discussion_r2318569513)
nit in 9c2b96e0d0303708710f9fbca3f9fdcb2fff21c1: Actually, on a second thought, this seems a bit fragile. It seems this would break the use-case of using several different local folders to run the CI, because the CI images have different, non-deterministic, paths embedded?

I presume the correct fix would be to download the sdk to a hard-coded path in the container image, and then adjust the pre-existing rsync call to copy it at runtime in the container, if needed.

💬 Sjors commented on pull request "Drop testnet3":
(https://github.com/bitcoin/bitcoin/pull/31974#issuecomment-3248728171)
Rebased after #33274.

💬 maflcko commented on pull request "build: suggest -DENABLE_IPC=OFF when missing capnp":
(https://github.com/bitcoin/bitcoin/pull/33290#issuecomment-3248736383)
> > Very strange CI errors:
> > ```
> > 03:45:32.525] -- Configuring incomplete, errors occurred!
> > [03:45:32.543] ++ cmake -P /ci_container_base/ci/test/GetCMakeLogFiles.cmake
> > [03:45:32.586] + cat CMakeFiles/CMakeConfigureLog.yaml
> > [03:45:32.587] cat: CMakeFiles/CMakeConfigureLog.yaml: No such file or directory
> > [03:45:32.621] Command '['./ci/test/02_run_container.sh']' returned non-zero exit status 1.
> > ```
>
> It seems a behaviour change overlooked in #32880.

Sorry,
...

💬 maflcko commented on pull request "build: suggest -DENABLE_IPC=OFF when missing capnp":
(https://github.com/bitcoin/bitcoin/pull/33290#issuecomment-3248739073)
Mind submitting ed95f4f095fecb0a6e5601199959db21e811dd71 as a separate pull?