💬 joeyvee1986 commented on pull request "walletdb: Add PrefixCursor":
(https://github.com/bitcoin/bitcoin/pull/27790#issuecomment-1569477575)
Andrew or anyone, where can I find your IRC/Discord/Telegram Chan?

On Tue, May 30, 2023, 10:00 PM Andrew Chow ***@***.***> wrote:

> Split from #24914 <https://github.com/bitcoin/bitcoin/pull/24914> as
> suggested in #24914 (review)
> <https://github.com/bitcoin/bitcoin/pull/24914#pullrequestreview-1442091917>
>
> This PR adds a database cursor that gives a view over all of the records
> beginning with the same prefix.
> ------------------------------
> You can view, comment on, or merge this p
...

💬 MarcoFalke commented on pull request "fuzz: fix wallet notifications.cpp":
(https://github.com/bitcoin/bitcoin/pull/27786#issuecomment-1569541366)
lgtm ACK a10f032115644d60a4321af06768d87d625affc1, thanks

💬 MarcoFalke commented on pull request "wallet: improve IBD sync time by skipping block scanning prior birth time":
(https://github.com/bitcoin/bitcoin/pull/27469#issuecomment-1569542166)
> The base fuzzing corpus should have detected it right?.

Yes, but the fuzz target is too slow right now, so the fuzz input directory is empty.

💬 MarcoFalke commented on pull request "test: fix intermittent error in getblockfrompeer.py":
(https://github.com/bitcoin/bitcoin/pull/27784#issuecomment-1569544891)
lgtm ACK 9fe9074266c6d7ddb40384d81741df1fc94980ff

💬 MarcoFalke commented on pull request "Add public Boost headers explicitly":
(https://github.com/bitcoin/bitcoin/pull/27783#discussion_r1211170115)
Feel free to take:


```diff
diff --git a/src/wallet/test/coinselector_tests.cpp b/src/wallet/test/coinselector_tests.cpp
index a5394d8816..b1d67c1432 100644
--- a/src/wallet/test/coinselector_tests.cpp
+++ b/src/wallet/test/coinselector_tests.cpp
@@ -432,7 +432,7 @@ BOOST_AUTO_TEST_CASE(bnb_search_test)
CAmount selection_target = 16 * CENT;
const auto& no_res = SelectCoinsBnB(GroupCoins(available_coins.All(), /*subtract_fee_outputs*/true),

...

💬 Ayush170-Future commented on pull request "fuzz: wallet, add target for `fees`":
(https://github.com/bitcoin/bitcoin/pull/27647#discussion_r1211172119)
`random_mutable_transaction` appears to be of no use.

📝 denavila opened a pull request: "wallet: Deniability API (Unilateral Transaction Meta-Privacy)"
(https://github.com/bitcoin/bitcoin/pull/27792)
This PR is the wallet API and implementation portion of the GUI PR ( https://github.com/bitcoin-core/gui/pull/733 ) which is an implementation of the ideas in Paul Sztorc's blog post "**Deniability - Unilateral Transaction Meta-Privacy**"(https://www.truthcoin.info/blog/deniability/).

The GUI PR has all the details and screenshots of the GUI additions. Here I'll just copy the relevant context for the wallet API changes:

"_In short, Paul's idea is to periodically split coins and send them t
...

💬 denavila commented on pull request "wallet: Deniability API (Unilateral Transaction Meta-Privacy)":
(https://github.com/bitcoin/bitcoin/pull/27792#issuecomment-1569687477)
@achow101 - per our discussion, I've created a PR with the core "deniability" functionality in the main repo here. The GUI portion is rebased over this branch and is in the GUI repo. I've updated the PRs' descriptions to point to each other.
Please let me know what you think. Thanks!

💬 MarcoFalke commented on pull request "wallet: Deniability API (Unilateral Transaction Meta-Privacy)":
(https://github.com/bitcoin/bitcoin/pull/27792#issuecomment-1569702764)
Not sure how much this achieves. Bitcoin Core's wallet has a "unique" fingerprint on transactions that is shared by way less than 50% of transactions in the network, so creating additional transactions where it is likely (latest when the outputs are spent) that it was a self-transfer seems only to be bloating the utxo set and chain space? I haven't thought about this, but it would be good to have a more in-depth analysis of this, considering using a different "fingerprint vector".

💬 wangtao19911111 commented on issue "configure: error: cannot figure out how to use std::filesystem":
(https://github.com/bitcoin/bitcoin/issues/27148#issuecomment-1569745093)
> > This is the relevant chunk from config.log:
>
> Installing `libstdc++-8-dev` will solve the problem.

how to install this lib？

👋 TheCharlatan's pull request is ready for review: "kernel: Remove shutdown from kernel library"
(https://github.com/bitcoin/bitcoin/pull/27711)

🚀 fanquake merged a pull request: "ci: Prune dangling images on RESTART_CI_DOCKER_BEFORE_RUN"
(https://github.com/bitcoin/bitcoin/pull/27777)

💬 fanquake commented on pull request "ci, iwyu: Update mappings":
(https://github.com/bitcoin/bitcoin/pull/27710#issuecomment-1569792756)
> Addressed @fanquake's https://github.com/bitcoin/bitcoin/pull/27710#discussion_r1210341923.

I don't see how this is addressed, looks like it's now just producing include suggestions that are incorrect/we don't want for the test code.

✅ fanquake closed an issue: "rpc_getblockfrompeer.py intermittent failure: assert_equal(pruneheight, 248); not(249 == 248)"
(https://github.com/bitcoin/bitcoin/issues/27749)

🚀 fanquake merged a pull request: "test: fix intermittent error in getblockfrompeer.py"
(https://github.com/bitcoin/bitcoin/pull/27784)

💬 hebasto commented on pull request "ci, iwyu: Update mappings":
(https://github.com/bitcoin/bitcoin/pull/27710#issuecomment-1569886912)
@fanquake
> ... looks like it's now just producing include suggestions that are incorrect/we don't want for the test code.

Can you point out these suggestions please? Asking because I've just skimmed suggestions for `test/*_tests.cpp` files again and I can see none of them in comparison to the master branch.

👍 dergoegge approved a pull request: "fuzz: Avoid timeout in utxo_total_supply"
(https://github.com/bitcoin/bitcoin/pull/27780#pullrequestreview-1452773063)
ACK fafb4da121b19ba1b7bd173e25651c64d1982fb4

Verified that the target still finds the CVE with the patch applied.

🚀 fanquake merged a pull request: "fuzz: fix wallet notifications.cpp"
(https://github.com/bitcoin/bitcoin/pull/27786)

👍 dergoegge approved a pull request: "doc: Remove unused NO_BLOOM_VERSION constant"
(https://github.com/bitcoin/bitcoin/pull/27657#pullrequestreview-1452792101)
ACK facbcd3742313625137907276628267ad90eee01

💬 willcl-ark commented on issue "bitcoind hangs waiting for `g_requests.empty()`":
(https://github.com/bitcoin/bitcoin/issues/27722#issuecomment-1569922589)
> @willcl-ark can you find what libevent version you're using?

I am using libevent 2.1.12 (like TheStack)