💬 achow101 commented on pull request "ci: Migrate CI to hosted Cirrus Runners":
(https://github.com/bitcoin/bitcoin/pull/32989#issuecomment-3247120869)
ACK 3c5da69a232ba1cfb935012aa53e57002efe0d77

Not particularly familiar with github actions or the cirrus, but it seems like all of the tasks that we were running on cirrus previously are correctly ported over and working.

📝 Cunero opened a pull request: "Update ci.yml"
(https://github.com/bitcoin/bitcoin/pull/33287)
Ci whit actions roots

<!--
*** Please remove the following help text before submitting: ***

Pull requests without a rationale and clear improvement may be closed
immediately.

GUI-related pull requests should be opened against
https://github.com/bitcoin-core/gui
first. See CONTRIBUTING.md

* Any test improvements or new tests that improve coverage are always welcome.
* All other changes should have accompanying unit tests (see `src/test/`) or
functional tests (see `test/`). Con
...

✅ Cunero closed a pull request: "Update ci.yml"
(https://github.com/bitcoin/bitcoin/pull/33287)

🤔 w0xlt reviewed a pull request: "doc: truc packages allow sub min feerate transactions"
(https://github.com/bitcoin/bitcoin/pull/33220#pullrequestreview-3178505708)
reACK https://github.com/bitcoin/bitcoin/pull/33220/commits/7270839af425adddb3ed436a58a41b5bc843dab5

💬 Cunero commented on pull request "Update ci.yml":
(https://github.com/bitcoin/bitcoin/pull/33287#issuecomment-3247171741)
# Security Policy

## Supported Versions

See our website for versions of Bitcoin Core that are currently supported with
security updates: https://bitcoincore.org/en/lifecycle/#schedule

## Reporting a Vulnerability

To report security issues send an email to security@bitcoincore.org (not for support).

The following keys may be used to communicate sensitive information to developers:

| Name | Fingerprint |
|------|-------------|
| Pieter Wuille | 133E AC17 9436 F14A 5CF1 B794 8
...

📝 Cunero reopened a pull request: "Update ci.yml"
(https://github.com/bitcoin/bitcoin/pull/33287)
Ci whit actions roots

<!--
*** Please remove the following help text before submitting: ***

Pull requests without a rationale and clear improvement may be closed
immediately.

GUI-related pull requests should be opened against
https://github.com/bitcoin-core/gui
first. See CONTRIBUTING.md

* Any test improvements or new tests that improve coverage are always welcome.
* All other changes should have accompanying unit tests (see `src/test/`) or
functional tests (see `test/`). Con
...

💬 Cunero commented on pull request "Update ci.yml":
(https://github.com/bitcoin/bitcoin/pull/33287#issuecomment-3247173060)
Thanks @Bitcoin

✅ Cunero closed a pull request: "Update ci.yml"
(https://github.com/bitcoin/bitcoin/pull/33287)

💬 Cunero commented on pull request "Update ci.yml":
(https://github.com/bitcoin/bitcoin/pull/33287#issuecomment-3247177272)
Ginger error...

📝 fqlx opened a pull request: "rpc/deprecateboolverbose Boolean verbosity is deprecated"
(https://github.com/bitcoin/bitcoin/pull/33288)

💬 ryanofsky commented on pull request "clang-tidy: disable clang-analyzer UndefinedBinaryOperatorResult warning":
(https://github.com/bitcoin/bitcoin/pull/33281#issuecomment-3247577007)
Maybe it would make sense to have cmake symlink `.clang-tidy` files from the source directory to the build directory the same way it seems to symlink functional test files

✅ maflcko closed an issue: "Increasing self-hosted runner raw performance"
(https://github.com/bitcoin/bitcoin/issues/30852)

💬 maflcko commented on issue "Increasing self-hosted runner raw performance":
(https://github.com/bitcoin/bitcoin/issues/30852#issuecomment-3247801501)
Closing for now. I think we'll go with https://github.com/bitcoin/bitcoin/issues/31965, which may also increase performance, so there is no longer a need to upgrade the self-hosted runners.

Feel free to continue discussion below. Also, this can be re-opened, or a new issue can be opened.

⚠️ maflcko opened an issue: "check_translations: Provide glossary as context"
(https://github.com/bitcoin/bitcoin/issues/33289)


> One false positive group of issues I noticed is the disagreement on translating terms.

> For example one example is `Peers`, it seems the LLM insists on suggesting `Ομότιμοι` which is more about comparing people, while `Κόμβοι` is more commonly accepted in our case. Not sure how to address this so these issues don't show up, but fwiw I found Transifex's Glossary very interesting to help have long-running async consistency on term translations, but I don't see any option to export them i
...

✅ maflcko closed an issue: "check_translations: Provide glossary as context"
(https://github.com/bitcoin/bitcoin/issues/33289)

💬 maflcko commented on issue "check_translations: Provide glossary as context":
(https://github.com/bitcoin/bitcoin/issues/33289#issuecomment-3247818755)
sry

💬 maflcko commented on issue "Old wallet support (Berkeley 4.8)":
(https://github.com/bitcoin/bitcoin/issues/33273#issuecomment-3247874109)
BDB has many known and unknown issues, so clinging to it when one is worried about wallet issues, seems backward? The backend hasn't been maintained for years (decades?) upstream and many issues in Bitcoin Core weren't fixed either, due to the planned removal.



> In any case, it is understandable that users may not want to mess with upgrading their wallets.

I think it is beneficial to be cautious and deliberate around actions involving the wallet. For example, it can help to create backups to
...

💬 TheCharlatan commented on issue "Old wallet support (Berkeley 4.8)":
(https://github.com/bitcoin/bitcoin/issues/33273#issuecomment-3247919097)
> did you mean that this was implemented? "Support could also mean an automatic migration to sqlite with an internal dependency free converter"

Yes.

💬 purpleKarrot commented on pull request "cmake: make missing Python interpreter behaviour more explicit":
(https://github.com/bitcoin/bitcoin/pull/33278#discussion_r2317931795)
I think this should be a [dependent option](https://cmake.org/cmake/help/latest/module/CMakeDependentOption.html). Also, we should start prefixing all options to allow the project to be used as a subproject:

```cmake
cmake_dependent_option(BTCCORE_ENABLE_FUNCTIONAL_TESTS "Enable the functional tests" ON BUILD_TESTS OFF)
```

📝 Sjors opened a pull request: "build: suggest -DENABLE_IPC=OFF when missing capnp"
(https://github.com/bitcoin/bitcoin/pull/33290)
Since #31802, when existing users upgrade to a recent version of master, or the upcoming v30 release, they'll be treated by an error that CapnProto is missing.

This error is generated by `src/ipc/libmultiprocess/CMakeLists.txt` which is a git subtree and so it doesn't have context of our project, and doesn't know about the `-DENABLE_IPC` option.

This pull request adds a simple pre-check in own CMake file to see if Cap'n Proto is missing. For ease of maintenance it doesn't check the version
...