Bitcoin Core Github
44 subscribers
121K links
Download Telegram
🤔 l0rinc reviewed a pull request: "Release: 30.0 translations update"
(https://github.com/bitcoin/bitcoin/pull/33275#pullrequestreview-3177636174)
Left some notes for the Hungarian translations, they're mostly ok (though they all sound very mechanical), there's one definite mistake and a few ones where the previous one was better
💬 l0rinc commented on pull request "Release: 30.0 translations update":
(https://github.com/bitcoin/bitcoin/pull/33275#discussion_r2316822016)
the previous one was correct:
```suggestion
<translation type="unfinished">Tárca megnyitása</translation>
```
💬 l0rinc commented on pull request "Release: 30.0 translations update":
(https://github.com/bitcoin/bitcoin/pull/33275#discussion_r2316825223)
previous one was better
💬 l0rinc commented on pull request "Release: 30.0 translations update":
(https://github.com/bitcoin/bitcoin/pull/33275#discussion_r2316828200)
this is incorrect, `cím` is `address`:
```suggestion
<translation type="unfinished">A jelenleg kiválasztott aláírás másolása a vágólapra</translation>
```
⚠️ instagibbs opened an issue: "GUI (?): Copying output from console causes large mem usage/OOM"
(https://github.com/bitcoin/bitcoin/issues/33285)
### Is there an existing issue for this?

- [x] I have searched the existing issues

### Current behaviour

Running the GUI on mainnet, I open the console, run:

`getblocktemplate '{"rules": ["segwit"]}'`

everything acts normally until then. If I then try to copy the test, memory usage blows out:

on release build, jumps from <2GB to >7GB memory

on debug build, it jumps to dozens of GB, often causing OOM and kills the process.



### Expected behaviour

I expect the memory usage to not blow up
...
💬 sdaftuar commented on pull request "Cluster mempool implementation":
(https://github.com/bitcoin/bitcoin/pull/28676#discussion_r2316855727)
I believe the ancestor and descendant count limits are still used by the wallet when using `-walletrejectlongchains`, which makes sense for at least a couple of releases after cluster mempool is released while there may still be a lot of nodes running with ancestor/descendant limits in place. So I think these variables should stay for now, perhaps I can add a comment mentioning all this so someone remembers to get rid of these later.
💬 w0xlt commented on pull request "wallet: Identify transactions spending 0-value outputs, and add tests for anchor outputs in a wallet":
(https://github.com/bitcoin/bitcoin/pull/33268#discussion_r2316892720)
nit: perhaps it makes review easier.

```suggestion
fromme_wallet = self.nodes[0].get_wallet_rpc("fromme")
```
💬 hebasto commented on pull request "Release: 30.0 translations update":
(https://github.com/bitcoin/bitcoin/pull/33275#issuecomment-3246455241)
> Left some notes for the Hungarian translations, they're mostly ok (though they all sound very mechanical), there's one definite mistake and a few ones where the previous one was better

Mind adjusting the mentioned translations on Transifex directly?
💬 l0rinc commented on pull request "Release: 30.0 translations update":
(https://github.com/bitcoin/bitcoin/pull/33275#discussion_r2316999726)
Fixed in Transifex, please close
💬 l0rinc commented on pull request "Release: 30.0 translations update":
(https://github.com/bitcoin/bitcoin/pull/33275#discussion_r2316999945)
reverted in Transifex
💬 l0rinc commented on pull request "Release: 30.0 translations update":
(https://github.com/bitcoin/bitcoin/pull/33275#discussion_r2317001048)
Fixed
💬 l0rinc commented on pull request "Release: 30.0 translations update":
(https://github.com/bitcoin/bitcoin/pull/33275#issuecomment-3246578829)
I have adjusted and finished the remaining ones in Hungarian.
I have tried if other languages help with the context (as suggested in https://github.com/bitcoin/bitcoin/pull/33275#issuecomment-3246189935) and the translations were pretty spon-on this way, e.g.
```
_msg1037
• Source (en): Option '-checkpoints' is set but checkpoints were removed. This option has no effect.
Context:
• fr: L’option « -checkpoints » est activée, mais les points de contrôle ont été supprimés. Cette option n’a
...
💬 ismaelsadeeq commented on pull request "mini miner: enable `Linearize` return package feerates":
(https://github.com/bitcoin/bitcoin/pull/33216#discussion_r2317014897)
I think the variable name is descriptive enough hence no need for a comment.
💬 ismaelsadeeq commented on pull request "Wallet: Add `maxfeerate` wallet startup option":
(https://github.com/bitcoin/bitcoin/pull/29278#discussion_r2317052580)
> I’d be surprised if we don’t have a test for that already.

Yes we do :)
💬 ismaelsadeeq commented on pull request "mini miner: enable `Linearize` return package feerates":
(https://github.com/bitcoin/bitcoin/pull/33216#discussion_r2317054430)
Done.
🤔 ismaelsadeeq reviewed a pull request: "cluster mempool: control/optimize TxGraph memory usage"
(https://github.com/bitcoin/bitcoin/pull/33157#pullrequestreview-3177972691)
Concept ACK to have control over memory usage, also not suprised by the numbers because of the added complexity of cluster mempool v master.
💬 ryanofsky commented on issue "intermittent timeout in mptest unit test":
(https://github.com/bitcoin/bitcoin/issues/33244#issuecomment-3246682969)
I think https://github.com/bitcoin-core/libmultiprocess/pull/201 should fix this. I haven't tested it very much yet, but the bug hasn't happened running mptest in a loop for about an hour.
📝 BenWestgate opened a pull request: "doc: update multisig tutorial to use multipath descriptors"
(https://github.com/bitcoin/bitcoin/pull/33286)
### Summary

Update `doc/multisig-tutorial.md` to use multipath descriptor format
instead of separate external/internal descriptors. The tutorial now:

- extracts a single `xpub_n` per participant
- constructs a multipath `wsh(sortedmulti(...))` descriptor with `<0;1>`
change index semantics
- uses `getdescriptorinfo` to compute descriptor checksum
- explains that `importdescriptors` expands the multipath descriptor
into internal and external descriptors

This change is doc
...
💬 0xB10C commented on issue "tracing: test `interface_usdt_net.py` fails due to garbage message type in `net:outbound_message` tracepoint":
(https://github.com/bitcoin/bitcoin/issues/33246#issuecomment-3246737298)
Can you share the output of `readelf -n ./build/bin/bitcoind | grep outbound_message -A 5 -B 3`?
📝 BenWestgate converted_to_draft a pull request: "doc: update multisig tutorial to use multipath descriptors"
(https://github.com/bitcoin/bitcoin/pull/33286)
### Summary

Update `doc/multisig-tutorial.md` to use multipath descriptor format
instead of separate external/internal descriptors. The tutorial now:

- extracts a single `xpub_n` per participant
- constructs a multipath `wsh(sortedmulti(...))` descriptor with `<0;1>`
change index semantics
- uses `getdescriptorinfo` to compute descriptor checksum
- explains that `importdescriptors` expands the multipath descriptor
into internal and external descriptors

This change is doc
...