💬 maflcko commented on pull request "p2p: add `DifferenceFormatter` fuzz target and invariant check":
(https://github.com/bitcoin/bitcoin/pull/33252#discussion_r2306835060)
this is the wrong commit. You'll have to apply the patch to the correct commit.

🤔 janb84 reviewed a pull request: "test: Use extra_port() helper in feature_bind_extra.py"
(https://github.com/bitcoin/bitcoin/pull/33260#pullrequestreview-3164184069)
crACK fabc2615af26c61a503f23ae4fd0353f90602bbe

PR adds extra function that returns a port. In this new function the utility function p2p_port(n) is called, which does a basic check and returns a (pseudo) random port number. This to reduce errors of using port numbers that are unavailable.

This looks like a simple solution without to much churn to solve #33250

💬 janb84 commented on pull request "test: Use extra_port() helper in feature_bind_extra.py":
(https://github.com/bitcoin/bitcoin/pull/33260#discussion_r2306925720)
```suggestion
def new_port():
```
NIT; wouldn't `new_port()` be more suitable ? line 50 is just the use of a new port not an extra port. "extra to what?"

💬 maflcko commented on pull request "test: Use extra_port() helper in feature_bind_extra.py":
(https://github.com/bitcoin/bitcoin/pull/33260#discussion_r2306984636)
It is "extra" on top of the normal node p2p ports, so I'll leave this as-is for now.

⚠️ jsarenik opened an issue: "Zero output not cleared"
(https://github.com/bitcoin/bitcoin/issues/33265)
I think this relates to https://github.com/bitcoin/bitcoin/issues/27463, fyi @instagibbs

Working on a clear reproduction script for regtest, but here are some preliminary notes and signet examples:

The script (network-less) is `51024e73`. It `decode`s to different addresses for mainnet, testnets (including signets) and regtest:

* `bc1pfeessrawgf` - mainnet
* `tb1pfees9rn5nz` - testnets (incl. signets)
* `bcrt1pfeesnyr2tx` - regtest

This LN Anchor address is important because such transac
...

💬 frankomosh commented on pull request "p2p: add `DifferenceFormatter` fuzz target and invariant check":
(https://github.com/bitcoin/bitcoin/pull/33252#discussion_r2307004087)
okey. Will sort it out

💬 maflcko commented on pull request "fees: enable `CBlockPolicyEstimator` return sub 1 sat/vb fee rate estimates":
(https://github.com/bitcoin/bitcoin/pull/33199#issuecomment-3232995418)
This picks up https://github.com/bitcoin/bitcoin/pull/13990? If yes, it may be good to explain the differences.

💬 maflcko commented on pull request "wallet: Remove isminetypes":
(https://github.com/bitcoin/bitcoin/pull/32523#discussion_r2307083091)
Ref also https://github.com/bitcoin/bitcoin/issues/22518

👍 stickies-v approved a pull request: "threading: reduce the scope of lock in getblocktemplate"
(https://github.com/bitcoin/bitcoin/pull/33264#pullrequestreview-3164397816)
ACK 06ec4809045f5cbe51d54e8eda08db03ca4d5ca1

💬 stickies-v commented on pull request "threading: reduce the scope of lock in getblocktemplate":
(https://github.com/bitcoin/bitcoin/pull/33264#discussion_r2307072731)
nit: could be one line lower to reduce scope more

✅ maflcko closed an issue: "0.21.1 native descriptor wallet showing incorrect value for `spendable`"
(https://github.com/bitcoin/bitcoin/issues/22518)

💬 maflcko commented on issue "0.21.1 native descriptor wallet showing incorrect value for `spendable`":
(https://github.com/bitcoin/bitcoin/issues/22518#issuecomment-3233102677)
The docs now say `(DEPRECATED) Always true`, so I guess this can be closed?

👍 rkrux approved a pull request: "wallet: Add `exportwatchonlywallet` RPC to export a watchonly version of a wallet"
(https://github.com/bitcoin/bitcoin/pull/32489#pullrequestreview-3164472562)
lgtm ACK 0f547141487e3964a55102f6ae441233d7144aaf

Thanks for addressing the comments.

💬 maflcko commented on pull request "cmake, guix: Skip building tests in subtrees for releases":
(https://github.com/bitcoin/bitcoin/pull/32054#issuecomment-3233202057)
@hebasto Could close?

💬 cedwies commented on pull request "Revert compact block cache inefficiencies":
(https://github.com/bitcoin/bitcoin/pull/33253#issuecomment-3233243613)
code-review ACK b7b249d

Read-through + local bench; results match others which I have seen. This PR restores cache locality in the compact-block reconstruction hot path and adds a well focused benchmark.

* Reverts the “vector of `CTransactionRef`” refactors and restores a cache-friendly layout for reconstruction.
* `InitData` again takes `std::vector<std::pair<Wtxid, CTransactionRef>> extra_txn`, causing the wtxid to be available without dereferencing in the hot loop.
* Early-exit and c
...

⚠️ 0xB10C opened an issue: "signet: disk-space-DoS due to low mining difficulty"
(https://github.com/bitcoin/bitcoin/issues/33266)
Due to low mining difficulty on Signet, an attacker can grind all possible nonces of a block header and create valid[^valid], alternative headers for Signet blocks. Since these have the [same chain work](https://github.com/bitcoin/bitcoin/blob/6ca6f3b37b992591726bd13b494369bee3bd6468/src/validation.cpp#L4416) as the tip, the newly mined headers [can](https://github.com/bitcoin/bitcoin/blob/6ca6f3b37b992591726bd13b494369bee3bd6468/src/validation.cpp#L4435) be submitted along with the original blo
...

💬 kevkevinpal commented on pull request "threading: reduce the scope of lock in getblocktemplate":
(https://github.com/bitcoin/bitcoin/pull/33264#discussion_r2307302790)
Makes sense to me! updated in [493ba0f](https://github.com/bitcoin/bitcoin/pull/33264/commits/493ba0f688311280056491986068cd4a9ad2be66)

⚠️ lnxsrt opened an issue: "124th peer connection closed every second"
(https://github.com/bitcoin/bitcoin/issues/33267)
### Is there an existing issue for this?

- [x] I have searched the existing issues

### Current behaviour

I'm on Bitcoin Core v29.0.0

I noticed that when at the max number of peers (124 total; 10 outbound; 114 inbound) the most recent peer connection is continually dropped after 1 second and another peer is selected. I can't imagine this is good behavior for the network.

As you can see, my peer count is very high (basically == number of seconds I've been at 124 peers) and the most recent pee
...

💬 instagibbs commented on issue "Zero output not cleared":
(https://github.com/bitcoin/bitcoin/issues/33265#issuecomment-3233461032)
thanks, hit me up when you reproduce it; I am having trouble disintangling if the issue is P2A, or ephemeral dust, or something else.

💬 stickies-v commented on pull request "threading: reduce the scope of lock in getblocktemplate":
(https://github.com/bitcoin/bitcoin/pull/33264#issuecomment-3233506955)
re-ACK 493ba0f688311280056491986068cd4a9ad2be66