💬 l0rinc commented on pull request "test: Use extra_port() helper in feature_bind_extra.py":
(https://github.com/bitcoin/bitcoin/pull/33260#discussion_r2304600873)
I find these reassignments confusing - especially if it contains two ports now.
I think we can get rid of that by using lambdas here, which can provide two separate ports as inputs and the loop would generate the new ports
(https://github.com/bitcoin/bitcoin/pull/33260#discussion_r2304600873)
I find these reassignments confusing - especially if it contains two ports now.
I think we can get rid of that by using lambdas here, which can provide two separate ports as inputs and the loop would generate the new ports
💬 l0rinc commented on pull request "test: Use extra_port() helper in feature_bind_extra.py":
(https://github.com/bitcoin/bitcoin/pull/33260#discussion_r2304594656)
@w0xlt was also modifying these in a different PR, I also considered a similar solution, but suggested using an iterator and lambdas instead https://github.com/bitcoin/bitcoin/pull/33231#discussion_r2296873010
(https://github.com/bitcoin/bitcoin/pull/33260#discussion_r2304594656)
@w0xlt was also modifying these in a different PR, I also considered a similar solution, but suggested using an iterator and lambdas instead https://github.com/bitcoin/bitcoin/pull/33231#discussion_r2296873010
📝 zkpepe opened a pull request: "fix: Merkle root calculation"
(https://github.com/bitcoin/bitcoin/pull/33262)
dropped the extra `SHA256D64` call that was messing up the result.
now it just builds the next level with `Hash(a, b)` like in Bitcoin Core, and the Merkle root comes out right.
(https://github.com/bitcoin/bitcoin/pull/33262)
dropped the extra `SHA256D64` call that was messing up the result.
now it just builds the next level with `Hash(a, b)` like in Bitcoin Core, and the Merkle root comes out right.
✅ fanquake closed a pull request: "fix: Merkle root calculation"
(https://github.com/bitcoin/bitcoin/pull/33262)
(https://github.com/bitcoin/bitcoin/pull/33262)
📝 mdqst opened a pull request: "fix: AutoFile position bug"
(https://github.com/bitcoin/bitcoin/pull/33263)
`AutoFile` doesn’t have `seek`, so I swapped it for `SetPos()` like Bitcoin Core does.
now moving around the file works correctly.
(https://github.com/bitcoin/bitcoin/pull/33263)
`AutoFile` doesn’t have `seek`, so I swapped it for `SetPos()` like Bitcoin Core does.
now moving around the file works correctly.
✅ achow101 closed a pull request: "fix: AutoFile position bug"
(https://github.com/bitcoin/bitcoin/pull/33263)
(https://github.com/bitcoin/bitcoin/pull/33263)
💬 l0rinc commented on pull request "fix: Merkle root calculation":
(https://github.com/bitcoin/bitcoin/pull/33262#issuecomment-3229103031)
For the record, this is a similar attempt to https://github.com/bitcoin/bitcoin/pull/32497#discussion_r2264546311 (probably used by an LLM for inspiration) - but the code was pushed from the GitHub UI and even included the code snipped markers.
@zkpepe, if you want to help, this isn't it, do the work instead of these cheap spams.
(https://github.com/bitcoin/bitcoin/pull/33262#issuecomment-3229103031)
For the record, this is a similar attempt to https://github.com/bitcoin/bitcoin/pull/32497#discussion_r2264546311 (probably used by an LLM for inspiration) - but the code was pushed from the GitHub UI and even included the code snipped markers.
@zkpepe, if you want to help, this isn't it, do the work instead of these cheap spams.
💬 average-gary commented on pull request "miner: Reorg Testnet4 minimum difficulty blocks":
(https://github.com/bitcoin/bitcoin/pull/31117#issuecomment-3229137770)
https://github.com/average-gary/bitcoin-garrys-mod/tree/testnet4-reorg-sv2
I had Claude implement changes from this PR with https://github.com/Sjors/bitcoin/tree/sv2 branch so I could use Sv2 for mining. Hoping to leave it hashing to see if we can't reduce the difficulty on TN4 to normalized levels.
I mined this block with it: https://mempool.space/testnet4/block/0000000000000000b92517e2fe1c4d68d8dcf5ad0068297355d7adfd867fe95c
(https://github.com/bitcoin/bitcoin/pull/31117#issuecomment-3229137770)
https://github.com/average-gary/bitcoin-garrys-mod/tree/testnet4-reorg-sv2
I had Claude implement changes from this PR with https://github.com/Sjors/bitcoin/tree/sv2 branch so I could use Sv2 for mining. Hoping to leave it hashing to see if we can't reduce the difficulty on TN4 to normalized levels.
I mined this block with it: https://mempool.space/testnet4/block/0000000000000000b92517e2fe1c4d68d8dcf5ad0068297355d7adfd867fe95c
💬 achow101 commented on pull request "doc: unify `datacarriersize` warning with release notes":
(https://github.com/bitcoin/bitcoin/pull/33224#issuecomment-3229182645)
> Unfortunately, the "opensource" plan used by the [Bitcoin organization](https://explore.transifex.com/bitcoin/) on Transifex has very limited functionality, and it is not guaranteed that updating the translation source file (as in #33193) won’t reset the "Reviewed" status for other strings.
Can we pay them some money to make that no longer a problem?
(https://github.com/bitcoin/bitcoin/pull/33224#issuecomment-3229182645)
> Unfortunately, the "opensource" plan used by the [Bitcoin organization](https://explore.transifex.com/bitcoin/) on Transifex has very limited functionality, and it is not guaranteed that updating the translation source file (as in #33193) won’t reset the "Reviewed" status for other strings.
Can we pay them some money to make that no longer a problem?
🤔 w0xlt reviewed a pull request: "test: Use extra_port() helper in feature_bind_extra.py"
(https://github.com/bitcoin/bitcoin/pull/33260#pullrequestreview-3161172184)
Concept ACK
(https://github.com/bitcoin/bitcoin/pull/33260#pullrequestreview-3161172184)
Concept ACK
💬 Aris-Ritz commented on issue "`feature_bind_extra.py` test fails in `test_runner` if new nodes are added":
(https://github.com/bitcoin/bitcoin/issues/33250#issuecomment-3229262326)
Duplicate of #33224
(https://github.com/bitcoin/bitcoin/issues/33250#issuecomment-3229262326)
Duplicate of #33224
💬 w0xlt commented on pull request "net: Prevent node from binding to the same `CService`":
(https://github.com/bitcoin/bitcoin/pull/33231#discussion_r2305020054)
The execution will be stopped either way (in the master branch or in this PR).
This PR simply prevents the node from attempting to connect twice to the same address and port, and instead terminates it with a clear message — rather than the confusing one currently shown in the master branch.
> I guess the first err msg is from logging while the second is from init.cpp
Yes, that makes sense. I'll check again.
(https://github.com/bitcoin/bitcoin/pull/33231#discussion_r2305020054)
The execution will be stopped either way (in the master branch or in this PR).
This PR simply prevents the node from attempting to connect twice to the same address and port, and instead terminates it with a clear message — rather than the confusing one currently shown in the master branch.
> I guess the first err msg is from logging while the second is from init.cpp
Yes, that makes sense. I'll check again.
💬 l0rinc commented on pull request "net: Prevent node from binding to the same `CService`":
(https://github.com/bitcoin/bitcoin/pull/33231#discussion_r2305027502)
it just continues IBD on my side after the warning, it doesn't seem to stop after the error
(https://github.com/bitcoin/bitcoin/pull/33231#discussion_r2305027502)
it just continues IBD on my side after the warning, it doesn't seem to stop after the error
🤔 hodlinator reviewed a pull request: "clang-format: align brace-after-struct and *-class formatting"
(https://github.com/bitcoin/bitcoin/pull/32813#pullrequestreview-3161358325)
ACK 7c9b3e1eae8f206753457149f1b1c837f6627d6d (first commit)
Ran `clang-format -dump-config -style=file:src/.clang-format > foo` on that commit and diffed *foo* against *src/.clang-format*. Only differences where added/elaborated settings from me running Clang-format 19. Makes sense to keep the format at the minimum version we support.
(https://github.com/bitcoin/bitcoin/pull/32813#pullrequestreview-3161358325)
ACK 7c9b3e1eae8f206753457149f1b1c837f6627d6d (first commit)
Ran `clang-format -dump-config -style=file:src/.clang-format > foo` on that commit and diffed *foo* against *src/.clang-format*. Only differences where added/elaborated settings from me running Clang-format 19. Makes sense to keep the format at the minimum version we support.
💬 hodlinator commented on pull request "clang-format: align brace-after-struct and *-class formatting":
(https://github.com/bitcoin/bitcoin/pull/32813#discussion_r2305026004)
Ran `clang-format -i -- **.cpp **.h **.hpp` in *src/* for both `AfterStruct` true & false, and compared diffs. Man was it close.
| true (94364a7d5403d9d480ebc065f8709c6dd21e543f) | false |
| -------- | -------- |
| `struct\n{` | `struct {` |
| 85'849 lines | 85'659 lines |
Even though `struct` & `class` can be used interchangeably in C++, only with different defaults for public/private, I think we might as well benefit from the fact that we have 2 concepts and use them to communicate whic
...
(https://github.com/bitcoin/bitcoin/pull/32813#discussion_r2305026004)
Ran `clang-format -i -- **.cpp **.h **.hpp` in *src/* for both `AfterStruct` true & false, and compared diffs. Man was it close.
| true (94364a7d5403d9d480ebc065f8709c6dd21e543f) | false |
| -------- | -------- |
| `struct\n{` | `struct {` |
| 85'849 lines | 85'659 lines |
Even though `struct` & `class` can be used interchangeably in C++, only with different defaults for public/private, I think we might as well benefit from the fact that we have 2 concepts and use them to communicate whic
...
💬 w0xlt commented on pull request "net: Prevent node from binding to the same `CService`":
(https://github.com/bitcoin/bitcoin/pull/33231#discussion_r2305179063)
If you are running in the foreground, `InitError()` prints the message to the console. In `debug.log`, only a single entry is recorded.
This behavior applies to all `InitError()` calls.
https://github.com/bitcoin/bitcoin/blob/6ca6f3b37b992591726bd13b494369bee3bd6468/src/node/interface_ui.cpp#L64
> it just continues IBD on my side after the warning, it doesn't seem to stop after the error
Could you please check again? `InitError()` returns false, which should stop execution.
https://gith
...
(https://github.com/bitcoin/bitcoin/pull/33231#discussion_r2305179063)
If you are running in the foreground, `InitError()` prints the message to the console. In `debug.log`, only a single entry is recorded.
This behavior applies to all `InitError()` calls.
https://github.com/bitcoin/bitcoin/blob/6ca6f3b37b992591726bd13b494369bee3bd6468/src/node/interface_ui.cpp#L64
> it just continues IBD on my side after the warning, it doesn't seem to stop after the error
Could you please check again? `InitError()` returns false, which should stop execution.
https://gith
...
💬 achow101 commented on pull request "test, refactor: Embedded ASmap selected preparatory work":
(https://github.com/bitcoin/bitcoin/pull/33026#issuecomment-3229648177)
ACK 734737b5930df7cebab83cf0dbe5fd390143f2be
(https://github.com/bitcoin/bitcoin/pull/33026#issuecomment-3229648177)
ACK 734737b5930df7cebab83cf0dbe5fd390143f2be
💬 l0rinc commented on pull request "net: Prevent node from binding to the same `CService`":
(https://github.com/bitcoin/bitcoin/pull/33231#discussion_r2305302493)
I tried it again:
```bash
git log -1 | head
commit 28fb7f74c4ae66dcb0f918774d644ac3c393f25b
Author: woltx <94266259+w0xlt@users.noreply.github.com>
Date: Mon Aug 25 20:22:33 2025 -0700
net: Prevent node from binding to the same CService
```
and did:
```bash
rm -rfd build && \
cmake -B build -G Ninja -DCMAKE_BUILD_TYPE=Release && \
ninja -C build && \
build/bin/bitcoind -bind=127.0.0.1:11012 -bind=127.0.0.1:11012
```
which resulted in:
```
...
2025-08-27T21:07:33Z ini
...
(https://github.com/bitcoin/bitcoin/pull/33231#discussion_r2305302493)
I tried it again:
```bash
git log -1 | head
commit 28fb7f74c4ae66dcb0f918774d644ac3c393f25b
Author: woltx <94266259+w0xlt@users.noreply.github.com>
Date: Mon Aug 25 20:22:33 2025 -0700
net: Prevent node from binding to the same CService
```
and did:
```bash
rm -rfd build && \
cmake -B build -G Ninja -DCMAKE_BUILD_TYPE=Release && \
ninja -C build && \
build/bin/bitcoind -bind=127.0.0.1:11012 -bind=127.0.0.1:11012
```
which resulted in:
```
...
2025-08-27T21:07:33Z ini
...
💬 l0rinc commented on pull request "clang-format: align brace-after-struct and *-class formatting":
(https://github.com/bitcoin/bitcoin/pull/32813#discussion_r2305316780)
I would be fine with both as long as it's explicit. I still find the rationale that `struct` and `class` should be formatted similarly, it's harder for me to explain why `struct` is more like a for loop than a `class`...
> 85'849 lines
I have no idea what these numbers mean, I checked same-line opening braces with
```bash
% grep -E '^\s*\bstruct\b\s+[^;{]*\{' --include="*.h" --include="*.cpp" -r src/ | wc -l
393
```
and quickly vibe coded a script that does newlines:
<detai
...
(https://github.com/bitcoin/bitcoin/pull/32813#discussion_r2305316780)
I would be fine with both as long as it's explicit. I still find the rationale that `struct` and `class` should be formatted similarly, it's harder for me to explain why `struct` is more like a for loop than a `class`...
> 85'849 lines
I have no idea what these numbers mean, I checked same-line opening braces with
```bash
% grep -E '^\s*\bstruct\b\s+[^;{]*\{' --include="*.h" --include="*.cpp" -r src/ | wc -l
393
```
and quickly vibe coded a script that does newlines:
<detai
...
💬 w0xlt commented on pull request "net: Prevent node from binding to the same `CService`":
(https://github.com/bitcoin/bitcoin/pull/33231#discussion_r2305337219)
That's strange. On my machine, it's interrupted.
I tried running it by pointing the `-datadir` to an empty folder to see if that was the reason, but it also stopped (shown below).
Wouldn't the `feature_bind_extra` test fail if the node didn't stop?
Are you using a configuration file? Could some settings be affecting this?
```
2025-08-27T21:27:45Z Loaded best chain: hashBestChain=000000000019d6689c085ae165831e934ff763ae46a2a6c172b3f1b60a8ce26f height=0 date=2009-01-03T18:15:05Z progres
...
(https://github.com/bitcoin/bitcoin/pull/33231#discussion_r2305337219)
That's strange. On my machine, it's interrupted.
I tried running it by pointing the `-datadir` to an empty folder to see if that was the reason, but it also stopped (shown below).
Wouldn't the `feature_bind_extra` test fail if the node didn't stop?
Are you using a configuration file? Could some settings be affecting this?
```
2025-08-27T21:27:45Z Loaded best chain: hashBestChain=000000000019d6689c085ae165831e934ff763ae46a2a6c172b3f1b60a8ce26f height=0 date=2009-01-03T18:15:05Z progres
...