✅ maflcko closed an issue: "Please Cancel the OP RETURN function"
(https://github.com/bitcoin/bitcoin/issues/33240)

💬 maflcko commented on issue "Please Cancel the OP RETURN function":
(https://github.com/bitcoin/bitcoin/issues/33240#issuecomment-3214559159)
Usually the issue tracker is used to track technical issues related to the Bitcoin Core code base.

General bitcoin questions and/or support requests are best directed to the [Bitcoin StackExchange](https://bitcoin.stackexchange.com) or the `#bitcoin` IRC channel on Libera Chat, or one of the Bitcoin subreddits, or any other place that you feel is well suited.

Network-wide consensus and/or P2P changes first need to be discussed with the greater ecosystem, for example https://groups.google.com/g
...

✅ maflcko closed an issue: "oss-fuzz: build is broken"
(https://github.com/bitcoin/bitcoin/issues/33232)

💬 maflcko commented on issue "oss-fuzz: build is broken":
(https://github.com/bitcoin/bitcoin/issues/33232#issuecomment-3214581022)
should be fixed?

👋 theuni's pull request is ready for review: "threading: remove ancient CRITICAL_SECTION macros"
(https://github.com/bitcoin/bitcoin/pull/32592)

💬 fanquake commented on pull request "index: Don't commit state in BaseIndex::Rewind":
(https://github.com/bitcoin/bitcoin/pull/33212#issuecomment-3214600249)
Seems like the 3rd or 4th re-run finally got lucky.

💬 zaidmstrr commented on pull request "rpc: Handle -named argument parsing where '=' character is used":
(https://github.com/bitcoin/bitcoin/pull/32821#discussion_r2293916342)
Thanks for suggesting. Fixed

💬 zaidmstrr commented on pull request "rpc: Handle -named argument parsing where '=' character is used":
(https://github.com/bitcoin/bitcoin/pull/32821#discussion_r2293916652)
Fixed

💬 l0rinc commented on pull request "refactor: Header sync optimisations & simplifications":
(https://github.com/bitcoin/bitcoin/pull/32740#discussion_r2293918928)
I personally would let the maintainers decide the order, ank keep both open

💬 zaidmstrr commented on pull request "rpc: Handle -named argument parsing where '=' character is used":
(https://github.com/bitcoin/bitcoin/pull/32821#discussion_r2293919832)
Thanks, done.

✅ fanquake closed an issue: "Indexes stuck on unknown best block after unclean shutdown"
(https://github.com/bitcoin/bitcoin/issues/33208)

🚀 fanquake merged a pull request: "index: Don't commit state in BaseIndex::Rewind"
(https://github.com/bitcoin/bitcoin/pull/33212)

💬 maflcko commented on pull request "ipc: Handle unclean shutdowns better":
(https://github.com/bitcoin/bitcoin/pull/32345#discussion_r2294091366)
This seems to fail the integer sanitizer: https://cirrus-ci.com/task/6018134475276288?logs=check#L211:

```
test/node_init_tests.cpp(14): Entering test suite "node_init_tests"
test/node_init_tests.cpp(33): Entering test case "init_test"
2025-08-21T19:53:08.170490Z [unknown] [test/util/random.cpp:48] [void SeedRandomStateForTest(SeedRand)] Setting random seed for current tests to RANDOM_CTX_SEED=ad2ae1d1b241a8a415874d45b2e104b01c396db4c21ec0899e66d0c85db1d978
2025-08-21T19:53:08.174281Z [te
...

💬 ryanofsky commented on pull request "ipc: Handle unclean shutdowns better":
(https://github.com/bitcoin/bitcoin/pull/32345#discussion_r2294123857)
re: https://github.com/bitcoin/bitcoin/pull/32345#discussion_r2294091366

Probably the node_init test (or maybe the unit test framework) should be disabling -natpmp after #33004 to prevent this code from running. But maybe there is a real bug on this line if it is subtracting `20 - 28`:

https://github.com/bitcoin/bitcoin/blob/73220fc0f958f9b65f66cf0cf042af220b312fc6/src/common/netif.cpp#L127

💬 enirox001 commented on pull request "test: Replace legacy wallet with MiniWallet in rpc_getblockstats.py":
(https://github.com/bitcoin/bitcoin/pull/33184#discussion_r2294175851)
Good catch! Removed FEE_SATOSHIS and now using the default fee. The original settxfee(0.003) was arbitrary - since getblockstats measures UTXOs (not fees), the default fee works fine. Test still passes and code is cleaner.

💬 cedwies commented on pull request "net: Prevent node from binding to the same `CService`":
(https://github.com/bitcoin/bitcoin/pull/33231#issuecomment-3214955658)
Concept ACK

One point to consider is a behavioral change in how the `onion_service_target` is selected.
Consider:
```md
-bind=192.167.1.10:8333=onion
-bind=127.0.0.1:8333=onion
```

Currently `192.167.1.10:8333` will be selected as `onion_service_target`. With this PR, it will be changed to `127.0.0.1:8333` (though one line in logs shows which address is used as target).


One option would be to keep using sets for deduplication, while still preserving the historical “first specifi
...

💬 enirox001 commented on pull request "test: Replace legacy wallet with MiniWallet in rpc_getblockstats.py":
(https://github.com/bitcoin/bitcoin/pull/33184#discussion_r2294179108)
Done

💬 ryanofsky commented on pull request "ipc: Handle unclean shutdowns better":
(https://github.com/bitcoin/bitcoin/pull/32345#discussion_r2294190428)
FWIW chatgpt suggested the following fix for the netlink code. No idea if it is correct:

```diff
--- a/src/common/netif.cpp
+++ b/src/common/netif.cpp
@@ -123,6 +123,17 @@ std::optional<CNetAddr> QueryDefaultGatewayImpl(sa_family_t family)
}

for (nlmsghdr* hdr = (nlmsghdr*)response; NLMSG_OK(hdr, recv_result); hdr = NLMSG_NEXT(hdr, recv_result)) {
+ // Netlink multipart dumps include control messages; ignore them.
+ if (hdr->nlmsg_type == NLMSG_DONE) {
+
...

💬 maflcko commented on pull request "ipc: Handle unclean shutdowns better":
(https://github.com/bitcoin/bitcoin/pull/32345#discussion_r2294197834)
> https://github.com/bitcoin/bitcoin/pull/33004

Ah. I somehow assumed that the ISan warning was specific to this unit test and does not reproduce outside of it. However, I can now reproduce it outside:

```
root@ubuntu-16gb-hel1-1:~/b-c# sysctl -w net.ipv6.conf.all.disable_ipv6=1
net.ipv6.conf.all.disable_ipv6 = 1
root@ubuntu-16gb-hel1-1:~/b-c# UBSAN_OPTIONS="suppressions=$(pwd)/test/sanitizer_suppressions/ubsan:print_stacktrace=1:halt_on_error=1:report_error_type=1" ./bld-cmake/bin/bit
...

💬 yancyribbens commented on pull request "coinselection: Tiebreak SRD eviction by weight":
(https://github.com/bitcoin/bitcoin/pull/33223#discussion_r2294362185)
Since the goal here is to use the same sort as `descending_effval_weight`, L532 - L 535 can be replaced with this single line:

`return descending_effval_weight(group1, group2);`