💬 Sjors commented on pull request "miner: clamp options instead of asserting":
(https://github.com/bitcoin/bitcoin/pull/33222#issuecomment-3213170422)
> However, in case 0 is a valid value for either of these options, we may want to set a different, invalid default value like -1 so the server can detect whether the client set the option, and use its own default if the client hasn't filled it in.

In that case perhaps it's better if we do hardcode defaults, especially if we can pick safe ones.

💬 Sjors commented on pull request "doc: follow-ups to "Add bitcoin-{node,gui} to release binaries for IPC"":
(https://github.com/bitcoin/bitcoin/pull/33233#issuecomment-3213172304)
@jonatack done, although I wasn't expecting there to be only doc changes.

💬 0xB10C commented on pull request "ci: Migrate CI to hosted Cirrus Runners":
(https://github.com/bitcoin/bitcoin/pull/32989#discussion_r2292858152)
nit:
```suggestion
uses: actions/checkout@v5
```
See https://github.com/bitcoin/bitcoin/pull/33171

💬 0xB10C commented on pull request "ci: Migrate CI to hosted Cirrus Runners":
(https://github.com/bitcoin/bitcoin/pull/32989#discussion_r2292859069)
```suggestion
uses: actions/checkout@v5
```

💬 0xB10C commented on pull request "ci: Migrate CI to hosted Cirrus Runners":
(https://github.com/bitcoin/bitcoin/pull/32989#discussion_r2292859570)
```suggestion
uses: actions/checkout@v5
```

📝 stickies-v opened a pull request: "doc: use new block_to_connect parameter name"
(https://github.com/bitcoin/bitcoin/pull/33237)
The parameter name was previously changed from `pblock` to `block_to_connect` in 9ba1fff29e4794615c599e59ef453848a9bdb880, without updating the documentation.

Addresses https://github.com/bitcoin/bitcoin/pull/33078#discussion_r2279914775.

💬 stickies-v commented on pull request "kernel: improve BlockChecked ownership semantics":
(https://github.com/bitcoin/bitcoin/pull/33078#discussion_r2292971381)
Fixed in https://github.com/bitcoin/bitcoin/pull/33237

💬 purpleKarrot commented on pull request "doc: use new block_to_connect parameter name":
(https://github.com/bitcoin/bitcoin/pull/33237#issuecomment-3213403480)
ACK 1c3db0ed8e6f51d66facf4820a9225f6c617ac53

💬 Sjors commented on pull request "wallet: prevent accidental unsafe older() import":
(https://github.com/bitcoin/bitcoin/pull/33135#issuecomment-3213548429)
@brunoerg perhaps a warning is good enough yes.

💬 fanquake commented on pull request "doc: use new block_to_connect parameter name":
(https://github.com/bitcoin/bitcoin/pull/33237#issuecomment-3213559439)
cc @stringintech

💬 stickies-v commented on pull request "index: Don't commit state in BaseIndex::Rewind":
(https://github.com/bitcoin/bitcoin/pull/33212#issuecomment-3213648051)
re-ACK a602f6fb7bf5f9e57299f4d6e246c82379fad8d2

CI [failure](https://github.com/bitcoin/bitcoin/actions/runs/17131871632/job/48598055509?pr=33212) (_"The hosted runner lost communication with the server"_) looks unrelated, would be good to restart?

💬 hodlinator commented on pull request "macdeploy: avoid use of `Bitcoin Core` in Linux cross build":
(https://github.com/bitcoin/bitcoin/pull/33158#issuecomment-3213700908)
Agreed that different names depending on originating platform might be a bit confusing.

Would be slightly more straightforward to switch to *bitcoin-macos-app.zip* as output for all, or allow `-zip` without a value in *contrib/macdeploy/macdeployqtplus* and just produce something like "macdeploy-output.zip".

🤔 janb84 reviewed a pull request: "doc: use new block_to_connect parameter name"
(https://github.com/bitcoin/bitcoin/pull/33237#pullrequestreview-3143812329)
ACK 1c3db0ed8e6f51d66facf4820a9225f6c617ac53

🚀 fanquake merged a pull request: "depends: remove xinerama extension from libxcb"
(https://github.com/bitcoin/bitcoin/pull/33217)

🚀 fanquake merged a pull request: "doc: Remove wrong and redundant doxygen tag"
(https://github.com/bitcoin/bitcoin/pull/33236)

💬 fanquake commented on pull request "doc: add Linux GUI runtime instructions to doc/README.md":
(https://github.com/bitcoin/bitcoin/pull/33197#issuecomment-3213895412)
The dependency on `libxcb-xinerama0` has been removed in #33217 (which will also be backported to the `29.x` branch) so I think pretty much all of the text being added here, is no-longer needed?

💬 dergoegge commented on pull request "rpc: followups for 33106":
(https://github.com/bitcoin/bitcoin/pull/33189#issuecomment-3213905094)
> Not everyone knows what "33106" is

"33106" refers to the pull request with that number: #33106, which is also linked in the PR description (only 12 times). It's common practice to link to a related PR like this (e.g. for a followup) in the PR title. Hope this helps.

💬 danielabrozzoni commented on pull request "refactor: Header sync optimisations & simplifications":
(https://github.com/bitcoin/bitcoin/pull/32740#discussion_r2293413758)
I'm happy to put this in draft and wait for #32579 to be merged first... This PR is smaller, and probably easier to rebase. What do you think?

🤔 musaHaruna reviewed a pull request: "doc: use new block_to_connect parameter name"
(https://github.com/bitcoin/bitcoin/pull/33237#pullrequestreview-3144065754)
ACK [1c3db0e](https://github.com/bitcoin/bitcoin/pull/33237/commits/1c3db0ed8e6f51d66facf4820a9225f6c617ac53)

💬 danielabrozzoni commented on pull request "refactor: Header sync optimisations & simplifications":
(https://github.com/bitcoin/bitcoin/pull/32740#discussion_r2293426298)
I would still keep the reformatting as `clang-format` doesn't like the one on master, and reformats it as I previously did (with the member initializers pushed to the right). At least this reformat is nice and `clang-format` doesn't try to modify it.

I hadn't considered `git blame` though, I don't love the idea of polluting it...