💬 maflcko commented on pull request "ipc: Handle unclean shutdowns better":
(https://github.com/bitcoin/bitcoin/pull/32345#discussion_r2290465048)
should this really be hidden by default? It seems like it should only happen unexpectedly, in which case a LogWarning may be better, or at least LogInfo?

💬 maflcko commented on pull request "Add bitcoin-{node,gui} to release binaries for IPC":
(https://github.com/bitcoin/bitcoin/pull/31802#discussion_r2290393840)
my understanding is that this should refer to the pull introducing the min required, which would be `[0.7.1](https://github.com/bitcoin/bitcoin/pull/28907)` via https://github.com/bitcoin-core/libmultiprocess/commit/414542f81e0997354b45b8ade13ca144a3e35ff1

💬 dergoegge commented on issue "fuzz: `txgraph`: Assertion `cmp == 0' failed":
(https://github.com/bitcoin/bitcoin/issues/33097#issuecomment-3209820443)
The crashing input was found by afl++ but libFuzzer and honggfuzz were also part of the campaign (probably took ~64 CPU hours).

⚠️ fanquake opened an issue: "oss-fuzz: build is broken"
(https://github.com/bitcoin/bitcoin/issues/33232)
Now that #31802 is merged, `oss-fuzz` needs fixing, to either opt-out of multiprocess, or configure depends to use the pre-built Clang for native package compilation (as Ubuntu 20.04 ships with GCC 9):
```bash
/src/bitcoin-core/depends/work/download/native_capnp-1.2.0/capnproto-cxx-1.2.0.tar.gz.temp: OK
Extracting native_capnp...
/src/bitcoin-core/depends/sources/capnproto-cxx-1.2.0.tar.gz: OK
Preprocessing native_capnp...
Configuring native_capnp...
-- The CXX compiler identification is GNU 9.4
...

📝 Sjors opened a pull request: "IPC followups for PR 31802"
(https://github.com/bitcoin/bitcoin/pull/33233)
- have `dependencies.md` link to the PR that updated the capnp version: https://github.com/bitcoin/bitcoin/pull/31802#discussion_r2290393840

💬 Sjors commented on pull request "Add bitcoin-{node,gui} to release binaries for IPC":
(https://github.com/bitcoin/bitcoin/pull/31802#discussion_r2290572656)
Done in #33233

🤔 janb84 reviewed a pull request: "IPC followups for PR 31802"
(https://github.com/bitcoin/bitcoin/pull/33233#pullrequestreview-3140010248)
ACK 2a815d126bc90f787f7adbe8cade45cb7307429b

PR updates dependencies document to point to version bump PR of capnproto.

- "code" review ✅

💬 Sjors commented on pull request "Add bitcoin-{node,gui} to release binaries for IPC":
(https://github.com/bitcoin/bitcoin/pull/31802#issuecomment-3209949040)
@fanquake @maflcko I opened a PR to temporarily disable IPC build for oss-fuzz, please take a look: https://github.com/google/oss-fuzz/pull/13854

💬 Sjors commented on issue "oss-fuzz: build is broken":
(https://github.com/bitcoin/bitcoin/issues/33232#issuecomment-3209951042)
Since I'm not at all familiar with oss-fuzz, I've gone for the simplest solution for now: https://github.com/google/oss-fuzz/pull/13854

💬 maflcko commented on pull request "IPC followups for PR 31802":
(https://github.com/bitcoin/bitcoin/pull/33233#issuecomment-3209973594)
lgtm ACK 2a815d126bc90f787f7adbe8cade45cb7307429b

💬 fanquake commented on pull request "doc: add Linux GUI runtime instructions to doc/README.md":
(https://github.com/bitcoin/bitcoin/pull/33197#discussion_r2290638615)
Opened #33217 to fix the issue.

🤔 BrandonOdiwuor reviewed a pull request: "cmake: Check user-defined `APPEND_*FLAGS` variables early"
(https://github.com/bitcoin/bitcoin/pull/32367#pullrequestreview-3140088293)
ACK eb2a9435044ac91442fafc606c5af2f473bff3c5

Confirmed that the new `bitcoincore_enable_language(...)` macro properly validates user-defined `APPEND_*FLAGS` early via `check_source_compiles(...)`, fixing #32323 by catching bad flags during enable_language(...), and removing the need a clean build directory.

(system: macOS 15.6)

(branch: master)
<img width="1512" height="917" alt="Screenshot 2025-08-21 at 13 21 10" src="https://github.com/user-attachments/assets/be10daae-31c4-4eb7-8504-
...

💬 fanquake commented on pull request "[29.x] 33106 backport and final changes for rc2":
(https://github.com/bitcoin/bitcoin/pull/33226#issuecomment-3210023448)
This needs `gen-bitcoin-conf.sh` run, to accomodate the changed options, before tagging an rc2. I'll open a followup, and we can get rc2 tagged after that.

💬 Sjors commented on pull request "Add functional test for IPC interface":
(https://github.com/bitcoin/bitcoin/pull/33201#issuecomment-3210097534)
For some reason on the macOS native job (`00_setup_env_mac_native.sh`) the interface test is skipped despite `pycapnp` being installed and `bitcoin-node` being built: https://github.com/bitcoin/bitcoin/actions/runs/17120162263/job/48559027457?pr=33201#step:8:3718

I checked that this test did run for native_asan.

I wrote a commit that enables it for additional jobs, which I'm testing in:
- CentOS
- native man
- kernel
- native_tsan
- previous releases
- native valgrind

🚀 fanquake merged a pull request: "[29.x] 33106 backport and final changes for rc2"
(https://github.com/bitcoin/bitcoin/pull/33226)

📝 fanquake opened a pull request: "doc: update example bitcoin conf for 29.1rc2"
(https://github.com/bitcoin/bitcoin/pull/33234)
Followup to #33226.

💬 musaHaruna commented on pull request "test: p2p block malleability":
(https://github.com/bitcoin/bitcoin/pull/33172#discussion_r2290729841)
Added in the latest push. Thank you!

💬 musaHaruna commented on pull request "test: p2p block malleability":
(https://github.com/bitcoin/bitcoin/pull/33172#discussion_r2290730358)
Fixed as suggested in the latest push

📝 fanquake opened a pull request: "build: set ENABLE_IPC to OFF when fuzzing"
(https://github.com/bitcoin/bitcoin/pull/33235)
A `BUILD_FOR_FUZZING` build will currently failure to configure, with missing `capnp`.

💬 maflcko commented on pull request "build: set ENABLE_IPC to OFF when fuzzing":
(https://github.com/bitcoin/bitcoin/pull/33235#issuecomment-3210147334)
> A `BUILD_FOR_FUZZING` build will currently failure to configure, with missing `capnp`.

IPC is by default on, and any build will fail with missing `capnp`? Whatever the user/dev is doing to fix those should be trivial to apply to a fuzz build to not have to special-case it?