💬 aureleoules commented on pull request "ci: Add test coverage job":
(https://github.com/bitcoin/bitcoin/pull/27547#discussion_r1208175632)
Done thanks

💬 aureleoules commented on pull request "ci: Add test coverage job":
(https://github.com/bitcoin/bitcoin/pull/27547#issuecomment-1565723181)
> Does this mean codecov can push changes to pull request or just that it can comment?

It seems that the permissions for "Pull request" are the following: https://docs.github.com/en/rest/overview/permissions-required-for-github-apps?apiVersion=2022-11-28#pull-requests

So I don't think Codecov is able to push to PRs.

🤔 Ronnie6464 requested changes to a pull request: "wallet: ensure the wallet is unlocked when needed for rescanning"
(https://github.com/bitcoin/bitcoin/pull/26347#pullrequestreview-1447762843)
No

👋 ishaanam's pull request is ready for review: "wallet: track mempool conflicts with wallet transactions"
(https://github.com/bitcoin/bitcoin/pull/27307)

👍 Ronnie6464 approved a pull request: "wallet: ensure the wallet is unlocked when needed for rescanning"
(https://github.com/bitcoin/bitcoin/pull/26347#pullrequestreview-1447804625)
[]()

💬 Ronnie6464 commented on pull request "wallet: ensure the wallet is unlocked when needed for rescanning":
(https://github.com/bitcoin/bitcoin/pull/26347#discussion_r1208270533)
- **[]()
```suggestion
encrypted_wallet.sethdseed(seed=hd_seed)_[]()

_
```
**

💬 Ronnie6464 commented on pull request "wallet: ensure the wallet is unlocked when needed for rescanning":
(https://github.com/bitcoin/bitcoin/pull/26347#discussion_r1208269643)
Ronowens6565@gmail.com

💬 Ronnie6464 commented on pull request "wallet: ensure the wallet is unlocked when needed for rescanning":
(https://github.com/bitcoin/bitcoin/pull/26347#discussion_r1208269963)
N[]()

💬 Ronnie6464 commented on pull request "wallet: ensure the wallet is unlocked when needed for rescanning":
(https://github.com/bitcoin/bitcoin/pull/26347#issuecomment-1565820325)
> Wallet passphrases are needed to top up the keypool of encrypted wallets
> during a rescan. The following RPCs need the passphrase when rescanning:
> - `importdescriptors`
> - `rescanblockchain`
>
> The following RPCs use the information about whether or not the
> passphrase is being used to ensure that full rescans are able to
> take place (meaning the following RPCs should not be able to run
> if a rescan requiring the wallet to be unlocked is taking place):
> - `walletlock`
>
...

👍 Ronnie6464 approved a pull request: "wallet: ensure the wallet is unlocked when needed for rescanning"
(https://github.com/bitcoin/bitcoin/pull/26347#pullrequestreview-1447808954)
test/functional/wallet_transactiontime_rescan.py

💬 Ronnie6464 commented on pull request "wallet: ensure the wallet is unlocked when needed for rescanning":
(https://github.com/bitcoin/bitcoin/pull/26347#discussion_r1208271444)
test/functional/wallet_transactiontime_rescan.py

📝 achow101 locked a pull request: "wallet: ensure the wallet is unlocked when needed for rescanning"
(https://github.com/bitcoin/bitcoin/pull/26347)
Wallet passphrases are needed to top up the keypool of encrypted wallets
during a rescan. The following RPCs need the passphrase when rescanning:
- `importdescriptors`
- `rescanblockchain`

The following RPCs use the information about whether or not the
passphrase is being used to ensure that full rescans are able to
take place (meaning the following RPCs should not be able to run
if a rescan requiring the wallet to be unlocked is taking place):
- `walletlock`
- `encry
...

📝 achow101 unlocked a pull request: "wallet: ensure the wallet is unlocked when needed for rescanning"
(https://github.com/bitcoin/bitcoin/pull/26347)
Wallet passphrases are needed to top up the keypool of encrypted wallets
during a rescan. The following RPCs need the passphrase when rescanning:
- `importdescriptors`
- `rescanblockchain`

The following RPCs use the information about whether or not the
passphrase is being used to ensure that full rescans are able to
take place (meaning the following RPCs should not be able to run
if a rescan requiring the wallet to be unlocked is taking place):
- `walletlock`
- `encry
...

📝 achow101 locked a pull request: "wallet: ensure the wallet is unlocked when needed for rescanning"
(https://github.com/bitcoin/bitcoin/pull/26347)
Wallet passphrases are needed to top up the keypool of encrypted wallets
during a rescan. The following RPCs need the passphrase when rescanning:
- `importdescriptors`
- `rescanblockchain`

The following RPCs use the information about whether or not the
passphrase is being used to ensure that full rescans are able to
take place (meaning the following RPCs should not be able to run
if a rescan requiring the wallet to be unlocked is taking place):
- `walletlock`
- `encry
...

💬 joostjager commented on issue "Allow accepting non-standard transactions on mainnet via local rpc":
(https://github.com/bitcoin/bitcoin/issues/27768#issuecomment-1565960002)
Could you provide a concrete example of such a high fee rate transaction that nevertheless isn't included in a block by miners? Also, could you elaborate on why that would be the case? I'd like to better understand their incentives and priorities.

📝 hebasto opened a pull request: "ci: Use docker image cache for "Win64 native [vs2022]" task"
(https://github.com/bitcoin/bitcoin/pull/27771)
This PR aims to speed up the "Win64 native [vs2022]" CI task by caching all prerequisite steps in the docker image cache.

📝 joostjager opened a pull request: "Make non-standard tx acceptance a peer option."
(https://github.com/bitcoin/bitcoin/pull/27772)
Make `-acceptnonstdtxn` apply to peers only and always allow local rpc calls to submit non-standard transactions to the mempool.

Fixes https://github.com/bitcoin/bitcoin/issues/27768

💬 dongcarl commented on pull request "contrib/init: Better systemd integration":
(https://github.com/bitcoin/bitcoin/pull/25975#issuecomment-1566203166)
Pushed 689a65d878:
- Addressed: https://github.com/bitcoin/bitcoin/pull/25975#discussion_r1182373299

💬 dongcarl commented on pull request "contrib/init: Better systemd integration":
(https://github.com/bitcoin/bitcoin/pull/25975#discussion_r1208605841)
Incorporated, thanks!

💬 dongcarl commented on pull request "contrib/init: Better systemd integration":
(https://github.com/bitcoin/bitcoin/pull/25975#issuecomment-1566204313)
I think whether or not to to add a `-nodebuglogfile` is somewhat tangential to the `systemd` integration and more related to whether or not `-daemonwait` is specified or even more specifically whether or not we're writing logs to `stdout`+`stderr`.

As in: Does a user of `bitcoind` that doesn't specify `-daemonwait` and expects logs on `stdout`+`stderr` also expect the debug log file to be written to or no?

In any case, I think we can leave that discussion for another time.