💬 amitiuttarwar commented on pull request "p2p: Diversify automatic outbound connections with respect to networks":
(https://github.com/bitcoin/bitcoin/pull/27213#discussion_r1208070951)
great feedback! that's much cleaner. incorporated in the latest push

💬 RandyMcMillan commented on pull request "Mask values on Transactions View":
(https://github.com/bitcoin-core/gui/pull/708#issuecomment-1565610693)
ACK 4492de1be11f4131811f504a037342c78f480e20

post merge ACK

Great job!

https://github.com/bitcoin-core/gui/pull/701#issuecomment-1401350037

💬 recursive-rat4 commented on issue "Allow accepting non-standard transactions on mainnet via local rpc":
(https://github.com/bitcoin/bitcoin/issues/27768#issuecomment-1565665282)
>The scenario that I have in mind though is alternative transport mechanisms for bitcoin transactions that exist outside the p2p network and that are publicly accessible. Miners are incentivised to pull out of that source, and therefore regular nodes should do that too to keep their mempool as much in sync as possible?

Miner's incentives are more complex than simply put into blockchain anything that pays a satoshi. One may end up in a situation where mempool is filled up with a type of non-st
...

💬 furszy commented on pull request "Fix rpc_getblockfrompeer intermittency by introducing 'getblockfileinfo' RPC command":
(https://github.com/bitcoin/bitcoin/pull/27770#issuecomment-1565677870)
> Not sure. My preference would be to figure out why the blocks are of different size and then make that deterministic instead.

I started there but.. do we really care? (aside from dev curiosity, where I agree that wouldn't be bad to know why).

The test goal is to exercise `getblockfrompeer` and not pruning nor where blocks are stored. Having all those hardcoded heights, expecting to have a precise number of blocks in each block file, looks quite fragile.

I mean, all the hardcoded `prun
...

💬 aureleoules commented on pull request "ci: Add test coverage job":
(https://github.com/bitcoin/bitcoin/pull/27547#discussion_r1208175632)
Done thanks

💬 aureleoules commented on pull request "ci: Add test coverage job":
(https://github.com/bitcoin/bitcoin/pull/27547#issuecomment-1565723181)
> Does this mean codecov can push changes to pull request or just that it can comment?

It seems that the permissions for "Pull request" are the following: https://docs.github.com/en/rest/overview/permissions-required-for-github-apps?apiVersion=2022-11-28#pull-requests

So I don't think Codecov is able to push to PRs.

🤔 Ronnie6464 requested changes to a pull request: "wallet: ensure the wallet is unlocked when needed for rescanning"
(https://github.com/bitcoin/bitcoin/pull/26347#pullrequestreview-1447762843)
No

👋 ishaanam's pull request is ready for review: "wallet: track mempool conflicts with wallet transactions"
(https://github.com/bitcoin/bitcoin/pull/27307)

👍 Ronnie6464 approved a pull request: "wallet: ensure the wallet is unlocked when needed for rescanning"
(https://github.com/bitcoin/bitcoin/pull/26347#pullrequestreview-1447804625)
[]()

💬 Ronnie6464 commented on pull request "wallet: ensure the wallet is unlocked when needed for rescanning":
(https://github.com/bitcoin/bitcoin/pull/26347#discussion_r1208270533)
- **[]()
```suggestion
encrypted_wallet.sethdseed(seed=hd_seed)_[]()

_
```
**

💬 Ronnie6464 commented on pull request "wallet: ensure the wallet is unlocked when needed for rescanning":
(https://github.com/bitcoin/bitcoin/pull/26347#discussion_r1208269643)
Ronowens6565@gmail.com

💬 Ronnie6464 commented on pull request "wallet: ensure the wallet is unlocked when needed for rescanning":
(https://github.com/bitcoin/bitcoin/pull/26347#discussion_r1208269963)
N[]()

💬 Ronnie6464 commented on pull request "wallet: ensure the wallet is unlocked when needed for rescanning":
(https://github.com/bitcoin/bitcoin/pull/26347#issuecomment-1565820325)
> Wallet passphrases are needed to top up the keypool of encrypted wallets
> during a rescan. The following RPCs need the passphrase when rescanning:
> - `importdescriptors`
> - `rescanblockchain`
>
> The following RPCs use the information about whether or not the
> passphrase is being used to ensure that full rescans are able to
> take place (meaning the following RPCs should not be able to run
> if a rescan requiring the wallet to be unlocked is taking place):
> - `walletlock`
>
...

👍 Ronnie6464 approved a pull request: "wallet: ensure the wallet is unlocked when needed for rescanning"
(https://github.com/bitcoin/bitcoin/pull/26347#pullrequestreview-1447808954)
test/functional/wallet_transactiontime_rescan.py

💬 Ronnie6464 commented on pull request "wallet: ensure the wallet is unlocked when needed for rescanning":
(https://github.com/bitcoin/bitcoin/pull/26347#discussion_r1208271444)
test/functional/wallet_transactiontime_rescan.py

📝 achow101 locked a pull request: "wallet: ensure the wallet is unlocked when needed for rescanning"
(https://github.com/bitcoin/bitcoin/pull/26347)
Wallet passphrases are needed to top up the keypool of encrypted wallets
during a rescan. The following RPCs need the passphrase when rescanning:
- `importdescriptors`
- `rescanblockchain`

The following RPCs use the information about whether or not the
passphrase is being used to ensure that full rescans are able to
take place (meaning the following RPCs should not be able to run
if a rescan requiring the wallet to be unlocked is taking place):
- `walletlock`
- `encry
...

📝 achow101 unlocked a pull request: "wallet: ensure the wallet is unlocked when needed for rescanning"
(https://github.com/bitcoin/bitcoin/pull/26347)
Wallet passphrases are needed to top up the keypool of encrypted wallets
during a rescan. The following RPCs need the passphrase when rescanning:
- `importdescriptors`
- `rescanblockchain`

The following RPCs use the information about whether or not the
passphrase is being used to ensure that full rescans are able to
take place (meaning the following RPCs should not be able to run
if a rescan requiring the wallet to be unlocked is taking place):
- `walletlock`
- `encry
...

📝 achow101 locked a pull request: "wallet: ensure the wallet is unlocked when needed for rescanning"
(https://github.com/bitcoin/bitcoin/pull/26347)
Wallet passphrases are needed to top up the keypool of encrypted wallets
during a rescan. The following RPCs need the passphrase when rescanning:
- `importdescriptors`
- `rescanblockchain`

The following RPCs use the information about whether or not the
passphrase is being used to ensure that full rescans are able to
take place (meaning the following RPCs should not be able to run
if a rescan requiring the wallet to be unlocked is taking place):
- `walletlock`
- `encry
...

💬 joostjager commented on issue "Allow accepting non-standard transactions on mainnet via local rpc":
(https://github.com/bitcoin/bitcoin/issues/27768#issuecomment-1565960002)
Could you provide a concrete example of such a high fee rate transaction that nevertheless isn't included in a block by miners? Also, could you elaborate on why that would be the case? I'd like to better understand their incentives and priorities.

📝 hebasto opened a pull request: "ci: Use docker image cache for "Win64 native [vs2022]" task"
(https://github.com/bitcoin/bitcoin/pull/27771)
This PR aims to speed up the "Win64 native [vs2022]" CI task by caching all prerequisite steps in the docker image cache.