🤔 maflcko reviewed a pull request: "Add Docker support with multi-arch build and user permissions handling"
(https://github.com/bitcoin/bitcoin/pull/33139#pullrequestreview-3095800749)
now you are just copy-pasting random files from the internet without even mentioning the source?

💬 maflcko commented on pull request "Add Docker support with multi-arch build and user permissions handling":
(https://github.com/bitcoin/bitcoin/pull/33139#discussion_r2259396974)
copy-paste from https://github.com/hundehausen/tor-hidden-service-docker/blob/main/Dockerfile

💬 maflcko commented on pull request "Add Docker support with multi-arch build and user permissions handling":
(https://github.com/bitcoin/bitcoin/pull/33139#discussion_r2259458592)
This needs a proper workflow documented on how to bump it and when. Otherwise, it would be confusing to have a 30.0 git release tag which contains a dockerfile with a hard-coded 29.0 tag.

💬 maflcko commented on pull request "Add Docker support with multi-arch build and user permissions handling":
(https://github.com/bitcoin/bitcoin/pull/33139#discussion_r2259402491)
copy-paste from https://github.com/willcl-ark/bitcoin-core-docker/blob/master/29.0/alpine/Dockerfile

✅ fanquake closed a pull request: "doc:Fix typos"
(https://github.com/bitcoin/bitcoin/pull/33148)

💬 fanquake commented on pull request "doc:Fix typos":
(https://github.com/bitcoin/bitcoin/pull/33148#issuecomment-3162996627)
PIcked the relevant change into #33125.

💬 fanquake commented on pull request "ci: Use mlc `v1` and fix typos":
(https://github.com/bitcoin/bitcoin/pull/33125#discussion_r2259479844)
Dropped this for now.

💬 maflcko commented on pull request "Add Docker support with multi-arch build and user permissions handling":
(https://github.com/bitcoin/bitcoin/pull/33139#issuecomment-3163010102)
For reference, for development, the dockerfile should look more like https://github.com/fanquake/core-review/blob/0bb70124a23807e3638f29ebd76c2bebc4880fd7/podman/debian.imagefile, just containing the install commands copy-pasted from the docs. But the development and deployment workflows differ significantly enough to not mix them up as the same.

My recommendation would be to just pick *one* problem/goal and not try to interleave multiple in the same pull request.

💬 maflcko commented on pull request "ci: Use mlc `v1` and fix typos":
(https://github.com/bitcoin/bitcoin/pull/33125#issuecomment-3163012735)
Is this ready for review?

💬 maflcko commented on pull request "tests: cover abortrescan() in-flight True path with dynamic-tail retry":
(https://github.com/bitcoin/bitcoin/pull/33131#discussion_r2259496837)
I am sure on Linux you could halt execution of a process (e.g. by adding a gdb breakpoint), but I am not sure if this is possible on Windows, or if this something worth trying.

Could mark as draft while CI is red?

💬 maflcko commented on issue "Release Schedule for 30.0":
(https://github.com/bitcoin/bitcoin/issues/32275#issuecomment-3163039235)
> 2025-08-06 🚧

Looks like the translation update was missed?

📝 bitcoin0158 opened a pull request: "Bitcoin v1"
(https://github.com/bitcoin/bitcoin/pull/33149)
<!--
*** Please remove the following help text before submitting: ***

Pull requests without a rationale and clear improvement may be closed
immediately.

GUI-related pull requests should be opened against
https://github.com/bitcoin-core/gui
first. See CONTRIBUTING.md
-->

<!--
Please provide clear motivation for your patch and explain how it improves
Bitcoin Core user experience or Bitcoin Core developer experience
significantly:

* Any test improvements or new tests that improv
...

✅ fanquake closed a pull request: "Bitcoin v1"
(https://github.com/bitcoin/bitcoin/pull/33149)

⚠️ maflcko opened an issue: "intermittent TSAN failure in lockmanager_tests::blockmanager_readblock_hash_mismatch"
(https://github.com/bitcoin/bitcoin/issues/33150)
TSAN failure (https://github.com/bitcoin/bitcoin/actions/runs/16651908244/job/47126650397?pr=32989#step:8:6056):
```bash
2025-07-31T14:39:40.396402Z [test] [net.cpp:2419] [void CConnman::SetTryNewOutboundPeer(bool)] [net] setting try another outbound peer=false
2025-07-31T14:39:40.396438Z [test] [net.cpp:3192] [void==================
WARNING: ThreadSanitizer: data race (pid=11584)
Write of size 8 at 0x7234000016f0 by main thread:
#0 blockmanager_tests::blockmanager_readblock_hash_mi
...

💬 maflcko commented on issue "intermittent TSAN failure in lockmanager_tests::blockmanager_readblock_hash_mismatch":
(https://github.com/bitcoin/bitcoin/issues/33150#issuecomment-3163078227)
A bit odd that this only happens in the pull changing the CI system, but it seems to be frequent: https://github.com/bitcoin/bitcoin/pull/32989#issuecomment-3160730521

It would be good to look into this, so I created this issue.

👍 ismaelsadeeq approved a pull request: "refactor: CFeeRate encapsulates FeeFrac internally"
(https://github.com/bitcoin/bitcoin/pull/32750#pullrequestreview-3096018187)
re-ACK d3b8a54a81209420ef6447dd4581e1b6b8550647 📦

💬 maflcko commented on pull request "CI: silent merge check":
(https://github.com/bitcoin/bitcoin/pull/33145#issuecomment-3163086012)
Other stuff to check would be that this works at all and doesn't just re-run an ancient commit, like https://github.com/bitcoin/bitcoin/pull/32989#issuecomment-3133536724

👋 fanquake's pull request is ready for review: "ci: Use mlc `v1` and fix typos"
(https://github.com/bitcoin/bitcoin/pull/33125)

💬 ismaelsadeeq commented on pull request "refactor: CFeeRate encapsulates FeeFrac internally":
(https://github.com/bitcoin/bitcoin/pull/32750#discussion_r2259553163)
Yeah you are right 👍🏾

💬 fanquake commented on pull request "ci: Use mlc `v1` and fix typos":
(https://github.com/bitcoin/bitcoin/pull/33125#issuecomment-3163087672)
It can be.