💬 furszy commented on issue "index: ThreadSanitizer: data race on vptr ":
(https://github.com/bitcoin/bitcoin/issues/27355#issuecomment-1564587046)
> > Not really a fix if there is something else going on but.. could use [furszy@8495c85](https://github.com/furszy/bitcoin-core/commit/8495c852ebe199a96a4e205937861b76f54227eb) (quick and dirty) to remove the active-wait timeout error.
>
> Mind opening a pull so that it can be reviewed and tested?

Sure.
Need a bit more time and will do it. I'm already tackling few issues in the area (#27607 and #27720) and would be good to receive a bit more feedback there prior creating this new PR, so
...

💬 MarcoFalke commented on issue "Allow accepting non-standard transactions on mainnet via local rpc":
(https://github.com/bitcoin/bitcoin/issues/27768#issuecomment-1564589375)
I'd say if something is safe and useful, it should be enabled for all transport mechanisms. Only enabling it for alternative outside ones doesn't make sense.

💬 hebasto commented on pull request "build: Add CMake-based build system":
(https://github.com/bitcoin/bitcoin/pull/25797#issuecomment-1564590429)
Rebased using the recent https://github.com/hebasto/bitcoin/pull/15.

The CI build is :green_circle:

Guix builds:
```
0e55d1f6049ff973dc7a0d1a94f898cac5c107867e5b56ad1765add2cf5e9bad guix-build-6da2447ba472/output/aarch64-linux-gnu/SHA256SUMS.part
92edb276a7daef893edc1ad07a062666866b33d1e57c9475571ce7446d947d72 guix-build-6da2447ba472/output/aarch64-linux-gnu/bitcoin-6da2447ba472-aarch64-linux-gnu-debug.tar.gz
b505174b13a9e15c99bb866238f6e8d06cecc9b7099f209fa556581927a61b32 guix-bui
...

💬 joostjager commented on issue "Allow accepting non-standard transactions on mainnet via local rpc":
(https://github.com/bitcoin/bitcoin/issues/27768#issuecomment-1564592179)
How can I then keep my mempool in sync with said public alternative source of non-standard transactions that will also appear in blocks and impact the fees that I should pay?

💬 Andrew-SUPPORT commented on issue "ci: failure in feature_taproot.py (TSAN)":
(https://github.com/bitcoin/bitcoin/issues/27595#issuecomment-1564593511)
Hello

💬 hebasto commented on pull request "Intro: Never change the prune checkbox after the user has touched it":
(https://github.com/bitcoin-core/gui/pull/658#issuecomment-1564602321)
Closing due to a long period of inactivity here. Feel free to reopen.

✅ hebasto closed a pull request: "Intro: Never change the prune checkbox after the user has touched it"
(https://github.com/bitcoin-core/gui/pull/658)

💬 jamesob commented on pull request "p2p: Log addresses of stalling peers":
(https://github.com/bitcoin/bitcoin/pull/27761#issuecomment-1564603683)
github ACK https://github.com/bitcoin/bitcoin/commit/fb02a3cd1a105bdf60ca39e1858e77685be88976

🚀 fanquake merged a pull request: "p2p: Log addresses of stalling peers"
(https://github.com/bitcoin/bitcoin/pull/27761)

🤔 hebasto reviewed a pull request: "ci: Add missing set -e to 01_base_install.sh"
(https://github.com/bitcoin/bitcoin/pull/27739#pullrequestreview-1446580353)
> Otherwise errors are silently ignored

Should we do the same in `ci/test/00_setup_env.sh`?

https://cirrus-ci.com/task/5206141060251648:
```
./ci/test/00_setup_env.sh: line 33: /ci_base_install/depends/config.guess: No such file or directory
```

💬 hebasto commented on pull request "ci: Add missing set -e to 01_base_install.sh":
(https://github.com/bitcoin/bitcoin/pull/27739#discussion_r1207044005)
Mention `-x` option in the PR description?

🤔 brunoerg reviewed a pull request: "fuzz: Change LIMIT_TO_MESSAGE_TYPE from a compile-time to a run-time setting"
(https://github.com/bitcoin/bitcoin/pull/27766#pullrequestreview-1446589212)
Concept ACK

💬 brunoerg commented on pull request "p2p: cleanup `LookupIntern`, `Lookup` and `LookupHost`":
(https://github.com/bitcoin/bitcoin/pull/26261#discussion_r1207055971)
No, going to change it

💬 brunoerg commented on pull request "p2p: cleanup `LookupIntern`, `Lookup` and `LookupHost`":
(https://github.com/bitcoin/bitcoin/pull/26261#issuecomment-1564654141)
@stickies-v I'm addressing it at this moment, will push soon.

💬 hebasto commented on pull request "ci: Add missing set -e to 01_base_install.sh":
(https://github.com/bitcoin/bitcoin/pull/27739#discussion_r1207074805)
`FILE_ENV="./ci/test/00_setup_env_mac_native_arm64.sh" ./ci/test_run_all.sh` fails locally for me now with the following error:
```
ERROR: invalid tag "": repository name must have at least one component
```

Also https://github.com/bitcoin/bitcoin/blob/fa0d36ffb5c8348598998eeb3ea6a3ee93bd6350/ci/test/04_install.sh#L37

💬 brunoerg commented on pull request "p2p: cleanup `LookupIntern`, `Lookup` and `LookupHost`":
(https://github.com/bitcoin/bitcoin/pull/26261#discussion_r1207080551)
The alternative to keep `BOOST_REQUIRE` is creating one more variable but I don't think it's worth, would have to do it in many places. Using `Assert` could also be an alternative, is there any harm of using it? Perhaps import `util/check` just for it?

💬 brunoerg commented on pull request "p2p: cleanup `LookupIntern`, `Lookup` and `LookupHost`":
(https://github.com/bitcoin/bitcoin/pull/26261#discussion_r1207083634)
Since it's a non-blocker I'm pushing addressing all lastest nits, except this one, to not delay and cause futher rebases conflicts.

💬 brunoerg commented on pull request "p2p: cleanup `LookupIntern`, `Lookup` and `LookupHost`":
(https://github.com/bitcoin/bitcoin/pull/26261#issuecomment-1564679459)
Force-pushed addressing:

- https://github.com/bitcoin/bitcoin/pull/26261#discussion_r1201199915
- https://github.com/bitcoin/bitcoin/pull/26261#discussion_r1177587552

Maybe done with nits, and we can have it merged?

👍 stickies-v approved a pull request: "p2p: cleanup `LookupIntern`, `Lookup` and `LookupHost`"
(https://github.com/bitcoin/bitcoin/pull/26261#pullrequestreview-1446643228)
re-ACK 5c832c3820253affc65c0ed490e26e5b0a4d5c9b - just addressing two nits, no other changes

<details>
<summary><code>git range-diff 8b59231641845f71df37e163bf5b8157fb197d05 4eee95e57bb6f773bcaeb405bca949f158a62134 5c832c3820253affc65c0ed490e26e5b0a4d5c9b</code></summary>

```
1: c0cf3d70e = 1: 5c1774a56 p2p, refactor: return `std::vector<CNetAddr>` in `LookupIntern`
2: 94b5edbf6 = 2: 7799eb125 p2p, refactor: return `std::vector<CNetAddr>` in `LookupHost`
3: 617bc481e ! 3: 34bcdfc
...

📝 mmienko opened a pull request: "update osx build docs"
(https://github.com/bitcoin/bitcoin/pull/27769)
- Add Jetbrains IDE dir to gitignore
- Document how to verify Homebrew during OSX build setup

While the project builds for osx M2, developers might not have envrionments properly setup (I didn't becuase I think I installed Homebrew from a guide rather than official site).
Hopefully improved documentation can mitigate future mishaps. Inspired by https://github.com/bitcoin/bitcoin/issues/25556.