💬 furszy commented on pull request "Return EXIT_FAILURE on post-init fatal errors":
(https://github.com/bitcoin/bitcoin/pull/27708#discussion_r1206928091)
Yeah [here](https://github.com/bitcoin/bitcoin/commit/bc2315d86f13e6e15f681ecaf5efc9b33e6128a3#diff-b1e19192258d83199d8adaa5ac31f067af98f63554bfdd679bd8e8073815e69dR1675), I just rebased #27607 on top of this one.

Np on using `AbortNode` there. Just would need to bubble up the indexes error so it can be provided to `AbortNode`.

👍 instagibbs approved a pull request: "p2p: Log addresses of stalling peers"
(https://github.com/bitcoin/bitcoin/pull/27761#pullrequestreview-1446443265)
utACK fb02a3cd1a105bdf60ca39e1858e77685be88976

💬 instagibbs commented on issue "Frequent "Timeout downloading block" with 24.1":
(https://github.com/bitcoin/bitcoin/issues/27705#issuecomment-1564537951)
> Which on this particular node is ~1GB of logs per 2-3 hours.

Another annoying way to find it is detect when node is stalled, then do `getpeerinfo` and see who has a block "inflight", then ban them.

That said, this should not happen regularly post #27626

💬 MarcoFalke commented on pull request "fuzz: Change LIMIT_TO_MESSAGE_TYPE from a compile-time to a run-time setting":
(https://github.com/bitcoin/bitcoin/pull/27766#discussion_r1206947004)
thx, done

💬 furszy commented on pull request "wallet: improve IBD sync time by skipping block scanning prior birth time":
(https://github.com/bitcoin/bitcoin/pull/27469#discussion_r1206948915)
It's merely about consistency and readability.

The explicit `load` call tells the reader that this is an atomic variable, which could prevent some issues. E.g.
```c++
if (block.chain_time_max < m_birth_time - (TIMESTAMP_WINDOW * 2)) return;
else (m_birth_time > something_esle) // do something else..
```
Here there are two atomic reads performed. And the `m_birth_time` could have changed in-between them.

⚠️ joostjager opened an issue: "Allow accepting non-standard transactions on mainnet via local rpc"
(https://github.com/bitcoin/bitcoin/issues/27768)
### Please describe the feature you'd like to see added.

To mitigate mempool divergence between nodes and miners, node operators should have the ability to submit non-standard transactions to their local mempools. One of the reasons to do so is to improve the quality of fee estimates.

Acceptance via the p2p network has been discussed in https://github.com/bitcoin/bitcoin/pull/27578 and is deemed to be problematic. This issue is for enabling non-standard transaction submission for the `sendra
...

👍 dergoegge approved a pull request: "fuzz: Change LIMIT_TO_MESSAGE_TYPE from a compile-time to a run-time setting"
(https://github.com/bitcoin/bitcoin/pull/27766#pullrequestreview-1446480815)
ACK 1111c9ac97ca0f0afeb5df45bc0970b761c3c9ff

💬 furszy commented on pull request "Return EXIT_FAILURE on post-init fatal errors":
(https://github.com/bitcoin/bitcoin/pull/27708#discussion_r1206967261)
> This comment seems a bit inaccurate, e.g. we may have `stop_at_height` set, but shutdown is still triggered internally. There is also one error case in https://github.com/bitcoin/bitcoin/blob/master/src/node/blockstorage.cpp#L931 that triggers a normal shutdown.

I would label `stop_at_height` as an action requested by the user. The user had to provide `-stopatheight` at startup so the shutdown is expected.

On the other hand, https://github.com/bitcoin/bitcoin/blob/master/src/node/blockst
...

💬 furszy commented on pull request "Return EXIT_FAILURE on post-init fatal errors":
(https://github.com/bitcoin/bitcoin/pull/27708#discussion_r1206969917)
sure

💬 MarcoFalke commented on issue "Allow accepting non-standard transactions on mainnet via local rpc":
(https://github.com/bitcoin/bitcoin/issues/27768#issuecomment-1564578894)
Your question is already answered in the thread you link to. You are even answering this yourself in your reply from https://github.com/bitcoin/bitcoin/pull/27578#issuecomment-1564482472:

> if a restriction can be lifted safely and benefit a specific group of users, why not?

So if something that benefits someone can be safely lifted, it should be done. Though, doing it as a non-standard transaction submitted manually and locally only doesn't make sense, as explained in the thread you link
...

💬 joostjager commented on issue "Allow accepting non-standard transactions on mainnet via local rpc":
(https://github.com/bitcoin/bitcoin/issues/27768#issuecomment-1564585565)
I assume you refer to the following explanation why enabling it locally only doesn't make sense:

>Its direct peers will simply discard these when your node broadcasts them, and they will eventually be purged from your mempool as any other non-confirmed transaction.

The scenario that I have in mind though is alternative transport mechanisms for bitcoin transactions that exist outside the p2p network and that are publicly accessible. Miners are incentivised to pull out of that source too, an
...

💬 furszy commented on issue "index: ThreadSanitizer: data race on vptr ":
(https://github.com/bitcoin/bitcoin/issues/27355#issuecomment-1564587046)
> > Not really a fix if there is something else going on but.. could use [furszy@8495c85](https://github.com/furszy/bitcoin-core/commit/8495c852ebe199a96a4e205937861b76f54227eb) (quick and dirty) to remove the active-wait timeout error.
>
> Mind opening a pull so that it can be reviewed and tested?

Sure.
Need a bit more time and will do it. I'm already tackling few issues in the area (#27607 and #27720) and would be good to receive a bit more feedback there prior creating this new PR, so
...

💬 MarcoFalke commented on issue "Allow accepting non-standard transactions on mainnet via local rpc":
(https://github.com/bitcoin/bitcoin/issues/27768#issuecomment-1564589375)
I'd say if something is safe and useful, it should be enabled for all transport mechanisms. Only enabling it for alternative outside ones doesn't make sense.

💬 hebasto commented on pull request "build: Add CMake-based build system":
(https://github.com/bitcoin/bitcoin/pull/25797#issuecomment-1564590429)
Rebased using the recent https://github.com/hebasto/bitcoin/pull/15.

The CI build is :green_circle:

Guix builds:
```
0e55d1f6049ff973dc7a0d1a94f898cac5c107867e5b56ad1765add2cf5e9bad guix-build-6da2447ba472/output/aarch64-linux-gnu/SHA256SUMS.part
92edb276a7daef893edc1ad07a062666866b33d1e57c9475571ce7446d947d72 guix-build-6da2447ba472/output/aarch64-linux-gnu/bitcoin-6da2447ba472-aarch64-linux-gnu-debug.tar.gz
b505174b13a9e15c99bb866238f6e8d06cecc9b7099f209fa556581927a61b32 guix-bui
...

💬 joostjager commented on issue "Allow accepting non-standard transactions on mainnet via local rpc":
(https://github.com/bitcoin/bitcoin/issues/27768#issuecomment-1564592179)
How can I then keep my mempool in sync with said public alternative source of non-standard transactions that will also appear in blocks and impact the fees that I should pay?

💬 Andrew-SUPPORT commented on issue "ci: failure in feature_taproot.py (TSAN)":
(https://github.com/bitcoin/bitcoin/issues/27595#issuecomment-1564593511)
Hello

💬 hebasto commented on pull request "Intro: Never change the prune checkbox after the user has touched it":
(https://github.com/bitcoin-core/gui/pull/658#issuecomment-1564602321)
Closing due to a long period of inactivity here. Feel free to reopen.

✅ hebasto closed a pull request: "Intro: Never change the prune checkbox after the user has touched it"
(https://github.com/bitcoin-core/gui/pull/658)

💬 jamesob commented on pull request "p2p: Log addresses of stalling peers":
(https://github.com/bitcoin/bitcoin/pull/27761#issuecomment-1564603683)
github ACK https://github.com/bitcoin/bitcoin/commit/fb02a3cd1a105bdf60ca39e1858e77685be88976

🚀 fanquake merged a pull request: "p2p: Log addresses of stalling peers"
(https://github.com/bitcoin/bitcoin/pull/27761)