💬 theStack commented on pull request "p2p: TxOrphanage revamp cleanups":
(https://github.com/bitcoin/bitcoin/pull/32941#discussion_r2247899372)
comment nit/question: I think this scenario could only ever happen if the per-peer memory usage limit was set smaller than `MAX_STANDARD_TX_WEIGHT` (which would obviously be a bad idea), right? Otherwise `AddTx` would return early for such txs and doesn't reach `LimitOrphans`.

💬 theStack commented on pull request "p2p: TxOrphanage revamp cleanups":
(https://github.com/bitcoin/bitcoin/pull/32941#discussion_r2247858413)
nit
```suggestion
if (m_reconsiderable_wtxids.contains(wtxid)) continue;
```

💬 theStack commented on pull request "p2p: TxOrphanage revamp cleanups":
(https://github.com/bitcoin/bitcoin/pull/32941#discussion_r2248258958)
Might be nice to set `-maxorphantx` in one functional test to ensure it doesn't error.

💬 theStack commented on pull request "p2p: TxOrphanage revamp cleanups":
(https://github.com/bitcoin/bitcoin/pull/32941#discussion_r2247915200)
```suggestion
// We must now be within limits, otherwise LimitOrphans should have continued further.
```

💬 fanquake commented on pull request "depends: disable builtin rules and suffixes.":
(https://github.com/bitcoin/bitcoin/pull/33045#issuecomment-3144960961)
Guix Build:
```bash
3e4284b29a80131af5c9d6343a02cf5a2831187e7172a1a6ad7f23d1c80dc9c0 guix-build-dc52d2daa4bc/output/aarch64-linux-gnu/SHA256SUMS.part
8e0f592bbc024e6bb47b330a356433353e1cf347d5e00c19120e64426bc909bc guix-build-dc52d2daa4bc/output/aarch64-linux-gnu/bitcoin-dc52d2daa4bc-aarch64-linux-gnu-debug.tar.gz
2de2c50b3a98e5dbf9651e49aa3886203eb87ad23327b1bc062c3bb5aa628520 guix-build-dc52d2daa4bc/output/aarch64-linux-gnu/bitcoin-dc52d2daa4bc-aarch64-linux-gnu.tar.gz
e08b0025054c9ea5
...

💬 glozow commented on pull request "policy: lower the default blockmintxfee, incrementalrelayfee, minrelaytxfee":
(https://github.com/bitcoin/bitcoin/pull/33106#issuecomment-3144964472)
Rebased for #31385

💬 glozow commented on pull request "p2p: TxOrphanage revamp cleanups":
(https://github.com/bitcoin/bitcoin/pull/32941#discussion_r2248271386)
Yes exactly!

📝 D33r-Gee opened a pull request: "Interfaces: Expose UTXO Snapshot Loading and Add Progress Notifications"
(https://github.com/bitcoin/bitcoin/pull/33117)
# Add UTXO Snapshot Loading Interface and Progress Notifications

This PR implements a complete interface for loading UTXO snapshots through the GUI, including progress notifications to provide user feedback during the loading process.

---

## Changes

### Commit 1: `interfaces: expose UTXO snapshot loading in node interface`

- Added a new virtual method `loadSnapshot` to the node interface for loading UTXO snapshots.
- Updated the implementation in `interfaces.cpp` to activate the
...

💬 hebasto commented on pull request "init: [gui] Avoid UB/crash in InitAndLoadChainstate":
(https://github.com/bitcoin/bitcoin/pull/32987#discussion_r2248288321)
The new test fails [OpenBSD](https://github.com/hebasto/bitcoin-core-nightly/actions/runs/16665947528/job/47172219749), [NetBSD](https://github.com/hebasto/bitcoin-core-nightly/actions/runs/16665951490/job/47172247495) and [OmniOS](https://github.com/hebasto/bitcoin-core-nightly/actions/runs/16665947542/job/47172219930):
```
199/274 - feature_reindex_init.py failed, Duration: 2 s

stdout:
2025-08-01T05:00:55.735205Z TestFramework (INFO): PRNG seed is: 3861405245096017501
2025-08-01T05:00:5
...

💬 danielabrozzoni commented on pull request "refactor: Header sync optimisations & simplifications":
(https://github.com/bitcoin/bitcoin/pull/32740#issuecomment-3144999375)
After some thinking, I decided to drop the first commit, and let ProcessNextHeaders take the headers argument and return it, instead of using it as a I/O argument. I tried to write a benchmark to measure how much using the vector as I/O argument would optimize the code, but it convinced me that the new interface would be too hard to work with, as reviewers pointed out. While it might still be a performance improvement, I'm not sure if it's really worth it.

For anyone interested, here's my att
...

💬 glozow commented on pull request "p2p: TxOrphanage revamp cleanups":
(https://github.com/bitcoin/bitcoin/pull/32941#discussion_r2248319433)
added

💬 glozow commented on pull request "p2p: TxOrphanage revamp cleanups":
(https://github.com/bitcoin/bitcoin/pull/32941#discussion_r2248318653)
done

💬 glozow commented on pull request "p2p: TxOrphanage revamp cleanups":
(https://github.com/bitcoin/bitcoin/pull/32941#discussion_r2248319793)
done

💬 glozow commented on pull request "p2p: TxOrphanage revamp cleanups":
(https://github.com/bitcoin/bitcoin/pull/32941#discussion_r2248320957)
already fixed I think

👋 fanquake's pull request is ready for review: "Musig2 tests"
(https://github.com/bitcoin/bitcoin/pull/32724)

👋 fanquake's pull request is ready for review: "wallet: Remove wallet version and several legacy related functions"
(https://github.com/bitcoin/bitcoin/pull/32977)

🤔 enirox001 reviewed a pull request: "test: refactor mempool_accept_wtxid"
(https://github.com/bitcoin/bitcoin/pull/33067#pullrequestreview-3079794265)
ACK

Solid test refactor with significant performance improvement:

- Using pre-mined chain reduces runtime from ~36s to ~7-10s (70%+ faster)
- MiniWallet integration eliminates manual signing and key management
- Class-to-function conversion appropriate for single-use case
- Removes unnecessary variable assignments, improves readability

Test coverage remains identical, CI passes.

💬 hebasto commented on pull request "refactor: Use immediate lambda to work around GCC bug 117966":
(https://github.com/bitcoin/bitcoin/pull/33113#issuecomment-3145104459)
> ```diff
> ci: Re-enable DEBUG=1 in centos task
>
> This reverts the workaround in commit fa079538e32d20aec6786c93e1117da1e8ea0cab, as it is no longer needed.
> ```

Thanks! Your changes have been added.

💬 hebasto commented on pull request "refactor: Use immediate lambda to work around GCC bug 117966":
(https://github.com/bitcoin/bitcoin/pull/33113#issuecomment-3145108301)
> Seems fine, but it can't hurt to enforce it in CI again?
>
> ```diff
> ci: Re-enable DEBUG=1 in centos task
>
> This reverts the workaround in commit fa079538e32d20aec6786c93e1117da1e8ea0cab, as it is no longer needed.
>
> diff --git a/ci/test/00_setup_env_native_centos.sh b/ci/test/00_setup_env_native_centos.sh
> index 25b9923dc7..94002b6349 100755
> --- a/ci/test/00_setup_env_native_centos.sh
> +++ b/ci/test/00_setup_env_native_centos.sh
> @@ -10,11 +10,11 @@ export
...

💬 kevkevinpal commented on pull request "wallet: Fix relative path backup during migration.":
(https://github.com/bitcoin/bitcoin/pull/32273#discussion_r2248423750)
looks like this was fixed in https://github.com/bitcoin/bitcoin/pull/33104