💬 Sjors commented on issue "External signer: in case of error shows only "External signer failure"":
(https://github.com/bitcoin/bitcoin/issues/31004#issuecomment-3144372615)
v27.1 is quite old and I think we've made some improvements since. Can you try again with [v29.0](https://bitcoincore.org/en/download/) or ideally [v29.1rc1](https://bitcoincore.org/bin/bitcoin-core-29.1/test.rc1/)?

💬 Sjors commented on issue "Docs: "External signer" documentation is outdated. (plz close if unwanted request)":
(https://github.com/bitcoin/bitcoin/issues/31005#issuecomment-3144377397)
Feel free to open a PR to update these docs.

✅ fanquake closed an issue: "cmake: Replace f`ile(GLOB ...)` command with an explicit list of `*.ts` files"
(https://github.com/bitcoin/bitcoin/issues/32653)

💬 Sjors commented on issue "Don't abort launch when failing to load a future wallet":
(https://github.com/bitcoin-core/gui/issues/95#issuecomment-3144386190)
This is still an issue fwiw. I often find myself editing or deleting `settings.json` after testing e.g. newly proposed descriptors.

⚠️ hebasto reopened an issue: "cmake: Replace f`ile(GLOB ...)` command with an explicit list of `*.ts` files"
(https://github.com/bitcoin/bitcoin/issues/32653)
From CMake [docs](https://cmake.org/cmake/help/latest/command/file.html#glob):
> We do not recommend using GLOB to collect a list of source files from your source tree. If no CMakeLists.txt file changes when a source is added or removed then the generated build system cannot know when to ask CMake to regenerate.

So the following case have to be reworked:https://github.com/bitcoin/bitcoin/blob/4b1d48a6866b24f0ed027334c6de642fc848d083/src/qt/CMakeLists.txt#L57-L60

📝 hebasto opened a pull request: "cmake: Switch to generated `ts_files.cmake` file"
(https://github.com/bitcoin/bitcoin/pull/33115)
This PR:
1. Moves handling of Qt TS files into the `locale` directory.
2. Switches from inferior globbing to the explicit file list generated by the [`bitcoin-maintainer-tools/update-translations.py`](https://github.com/bitcoin-core/bitcoin-maintainer-tools/blob/main/update-translations.py) script.

Closes #32653.

💬 hebasto commented on pull request "cmake: Switch to generated `ts_files.cmake` file":
(https://github.com/bitcoin/bitcoin/pull/33115#issuecomment-3144428694)
Friendly ping @laanwj :)

💬 fanquake commented on pull request "cmake: Switch to generated `ts_files.cmake` file":
(https://github.com/bitcoin/bitcoin/pull/33115#issuecomment-3144442383)
Can we do a translation update here, to show that this change, and https://github.com/bitcoin-core/bitcoin-maintainer-tools/pull/185, are working properly.

💬 Sjors commented on pull request "wallet: relax external_signer flag constraints":
(https://github.com/bitcoin/bitcoin/pull/33112#issuecomment-3144497794)
Added f8f668c355d16b8545ddc11681e6654b8f33f99a _wallet: avoid createTransaction() with signer_ to prevent breaking GUI signing for private key enabled external signer wallets (even when they don't have other keys).

💬 hebasto commented on pull request "cmake: Switch to generated `ts_files.cmake` file":
(https://github.com/bitcoin/bitcoin/pull/33115#issuecomment-3144525335)
> Can we do a translation update here, to show that this change, and [bitcoin-core/bitcoin-maintainer-tools#185](https://github.com/bitcoin-core/bitcoin-maintainer-tools/pull/185), are working properly.

Sure. A commit has been added. Please see the commit message for details.

👋 glozow's pull request is ready for review: "[WIP] policy: lower the default blockmintxfee, incrementalrelayfee, minrelaytxfee"
(https://github.com/bitcoin/bitcoin/pull/33106)

💬 glozow commented on pull request "policy: lower the default blockmintxfee, incrementalrelayfee, minrelaytxfee":
(https://github.com/bitcoin/bitcoin/pull/33106#discussion_r2247965785)
I have this in the OP, but will add to commit message:

> blockmintxfee shouldn’t be above min relay feerate, otherwise the node accepts transactions it will never mine. I've knocked it down to the bare minimum of 1sat/kvB. Now that we no longer have coin age priority (removed in v0.15), I think we can leave it to the CheckFeeRate policy rule to enforce a minimum entry price, and the block assembly code should just fill up the block with whatever it finds in mempool.

💬 stickies-v commented on pull request "kernel: improve BlockChecked ownership semantics":
(https://github.com/bitcoin/bitcoin/pull/33078#discussion_r2247983524)
Done, thanks. My initial idea was to use value semantics to simplify ownership, and to let the dispatcher implement move semantics where relevant, but that doesn't work when there is one dispatcher and multiple subscribers as is the case with our validation interface. Letting the subscriber explicitly claim ownership by copying the reference makes sense and allows us to pay for what we use.

💬 stickies-v commented on pull request "kernel: improve BlockChecked ownership semantics":
(https://github.com/bitcoin/bitcoin/pull/33078#issuecomment-3144588867)
Force-pushed to call `BlockChecked` with `const std::shared_ptr<const CBlock>&`, [addressing](https://github.com/bitcoin/bitcoin/pull/33078#discussion_r2247983524) review feedback to avoid atomic reference counting overhead when the subscriber doesn't need ownership. Benchmarks indicate this PR now no longer has a significant performance impact, on my machine.

💬 fanquake commented on pull request "cmake: Switch to generated `ts_files.cmake` file":
(https://github.com/bitcoin/bitcoin/pull/33115#issuecomment-3144620952)
https://github.com/bitcoin/bitcoin/pull/33115/checks?check_run_id=47202038035:
```bash
[09:14:13.759] gmake[2]: *** No rule to make target 'src/qt/locale/bitcoin_uz.qm', needed by 'src/qt/bitcoinqt_autogen/EJRQKI7XPS/qrc_bitcoin_locale.cpp'. Stop.
[09:14:13.759] gmake[2]: *** Waiting for unfinished jobs....
```

👍 willcl-ark approved a pull request: "contrib: drop use of `PermissionsStartOnly` & `Group=`"
(https://github.com/bitcoin/bitcoin/pull/33044#pullrequestreview-3079289883)
ACK b392a513f025ca03f718c3ff2bbb970faf6f8afd

Only a single non-blocking nit on the commit message.

💬 willcl-ark commented on pull request "contrib: drop use of `PermissionsStartOnly` & `Group=`":
(https://github.com/bitcoin/bitcoin/pull/33044#discussion_r2248019661)
In b392a513f025ca03f718c3ff2bbb970faf6f8afd

Commit message could be updated to state that we use `!` (not `+` as it says). Using `!` here is the correct choice for minimal priviledge escalation for here though.

💬 glozow commented on pull request "policy: lower the default blockmintxfee, incrementalrelayfee, minrelaytxfee":
(https://github.com/bitcoin/bitcoin/pull/33106#discussion_r2248021432)
`CFeeRate` is a fraction. Prior to using `FeeFrac`, the denominator was always 1000. Now, it's whatever you want it to be (in this case, the tx size). It still has to round, as it needs to output an integer number of satoshis when evaluating the fee for a given size.

The problem is that we weren't rounding before when the fee was always a multiple of the size. Now we have to round; we want the number of satoshis for a size at 0.1sat/vB. I made all the numbers play nice by making the denominat
...

✅ fanquake closed an issue: "build: Alpine portability issues"
(https://github.com/bitcoin/bitcoin/issues/32512)

🚀 fanquake merged a pull request: "doc: add alpine build instructions"
(https://github.com/bitcoin/bitcoin/pull/32559)