💬 achow101 commented on pull request "wallet: Add `exportwatchonlywallet` RPC to export a watchonly version of a wallet":
(https://github.com/bitcoin/bitcoin/pull/32489#discussion_r2246561816)
Done

💬 rot13maxi commented on pull request "[WIP] policy: lower the default blockmintxfee, incrementalrelayfee, minrelaytxfee":
(https://github.com/bitcoin/bitcoin/pull/33106#issuecomment-3141712721)

> > Contrast this with the dust feerate, which defines a value as "too small" based on Bitcoin's protocol constraints on transaction volume (e.g. spend script size vs block space). The conversion rate is thus irrelevant or, at the very least, applies very differently in that context.
>
> No, dust is defined as too small to be worth spending, which is a factor of fee rate to spend it. If the fee rate is 10x lower, the dust limit is logically 10x lower as well.

Dropping the dust threshold
...

⚠️ Mstone87 opened an issue: "Mike stone"
(https://github.com/bitcoin/bitcoin/issues/33108)
### Motivation

Sugabitcoin

### Possible solution

_No response_

### Useful Skills

* Compiling Bitcoin Core from source
* Running the C++ unit tests and the Python functional tests
* ...


### Guidance for new contributors

Want to work on this issue?

For guidance on contributing, please read [CONTRIBUTING.md](https://github.com/bitcoin/bitcoin/blob/master/CONTRIBUTING.md) before opening your pull request.

✅ achow101 closed an issue: "Mike stone"
(https://github.com/bitcoin/bitcoin/issues/33108)

💬 Zeegaths commented on pull request "wallet: Track no-longer-spendable TXOs separately":
(https://github.com/bitcoin/bitcoin/pull/27865#issuecomment-3141776644)
## Performance Testing Results

Tested this PR against master using regtest with high-activity wallets.

### Test Setup:
- Ubuntu 22.04, CMake build
- Fresh regtest environment for both branches
- 1,110 transactions (200 initial coinbase + 500 small sends + 100 coinbase + 300 large sends + 10 final coinbase)
- Identical test patterns on both branches

### Results:

| Operation | Master | PR Branch | Performance Change |
|-----------|--------|-----------|-------------------|
| `ge
...

💬 ryanofsky commented on pull request "cmake: Move internal binaries from bin/ to libexec/":
(https://github.com/bitcoin/bitcoin/pull/31679#issuecomment-3141813974)
> Actually looking closer these are pretty much all build directory links, so are ok.

Sorry about that, the PR description was confusing and achow thought the same thing you did. I rewrote it now to be clearer. (I think the original PR description was also clear but I had replaced it a few weeks ago with a big table to explain some details of the change, and I think the table made it harder to understand the high-level change.)

💬 pablomartin4btc commented on pull request "wallet, refactor: Remove Legacy check and error":
(https://github.com/bitcoin/bitcoin/pull/33082#issuecomment-3141827198)
<ins>_Updates_</ins>
- Reverted a legacy wallet check and removed some unnecessary `LoadWallet()` calls from a few wallet tests in the first commit.

👋 pablomartin4btc's pull request is ready for review: "wallet, refactor: Remove Legacy check and error"
(https://github.com/bitcoin/bitcoin/pull/33082)

💬 1ma commented on pull request "[WIP] policy: lower the default blockmintxfee, incrementalrelayfee, minrelaytxfee":
(https://github.com/bitcoin/bitcoin/pull/33106#issuecomment-3141854197)
NACK. I think the direction of this change makes sense in isolation, but interacts too badly with other default mempool policies.

Users will always prefer to transact at the lowest fee given the current demand for tx confirmation, and miners will always prefer to earn more fees by filling blocks with extremely cheap txs rather than mine half empty blocks. Both these market forces are set to intensify over the long run as fiat inflation goes on and Bitcoin's block subsidy runs out. I don't eve
...

💬 Sammie05 commented on pull request "test: Perform backup filename checks in migrate_and_get_rpc in wallet_migration.py":
(https://github.com/bitcoin/bitcoin/pull/33104#issuecomment-3141944954)
tACK 4b80147
Confirmed the test passes and mocktime is handled consistently within migrate_and_get_rpc.

Reproduced the failure when mocktime is set redundantly and confirmed the fix removes the race. Clean change, and no unnecessary test logic outside the migration function.
Good to go from my end.

📝 cccccccchhhh opened a pull request: "Create chris.txt"
(https://github.com/bitcoin/bitcoin/pull/33109)
hi my name is christo sorry to bother you, if you have time you can read my massage so that we can keep in touch

👋 achow101's pull request is ready for review: "wallet: Be able to receive and spend inputs involving MuSig2 aggregate keys"
(https://github.com/bitcoin/bitcoin/pull/29675)

💬 achow101 commented on pull request "wallet: Be able to receive and spend inputs involving MuSig2 aggregate keys":
(https://github.com/bitcoin/bitcoin/pull/29675#issuecomment-3142073357)
All prerequisites have been merged, ready for review.

💬 HowHsu commented on pull request "index: fix wrong assert of current_tip == m_best_block_index":
(https://github.com/bitcoin/bitcoin/pull/32878#issuecomment-3142149917)
> > Hi @furszy , sorry for the delay, I've picked your commit of the test, which I missed earlier.
>
> No problem. This needs a rebase.

Hi @furszy , seems the test causes some data race

💬 ajtowns commented on pull request "[WIP] policy: lower the default blockmintxfee, incrementalrelayfee, minrelaytxfee":
(https://github.com/bitcoin/bitcoin/pull/33106#discussion_r2246883818)
The precision when setting is sats/kvB so 0.001 sat/vb, since it's just set to the highest fee rate of any tx evicted via `TrimToSize()`.

https://github.com/bitcoin/bitcoin/blob/8712e074bb54eea9ccc4d2009d2150279c9d17ec/src/txmempool.cpp#L1132-L1138

💬 ajtowns commented on pull request "[WIP] policy: lower the default blockmintxfee, incrementalrelayfee, minrelaytxfee":
(https://github.com/bitcoin/bitcoin/pull/33106#discussion_r2246888923)
I think it makes sense (as a default) to always include things in blocks if they're in your mempool. Otherwise having those txs in your mempool potentially blocks you from seeing txs you would include in your block (eg, double-spends that don't pass rbf rules), and seems like something of a waste of memory/bandwidth (though not a DoS risk).

💬 ajtowns commented on pull request "[WIP] policy: lower the default blockmintxfee, incrementalrelayfee, minrelaytxfee":
(https://github.com/bitcoin/bitcoin/pull/33106#issuecomment-3142444090)
> > Contrast this with the dust feerate, which defines a value as "too small" based on Bitcoin's protocol constraints on transaction volume (e.g. spend script size vs block space). The conversion rate is thus irrelevant or, at the very least, applies very differently in that context.
>
> No, dust is defined as too small to be worth spending,

Luke is correct here that was the original rationale for the dust setting, and remains the rationale documented in the comments in [policy.cpp](https:
...

💬 ajtowns commented on pull request "validation: detect witness stripping early on":
(https://github.com/bitcoin/bitcoin/pull/33105#discussion_r2247057170)
I think that's fine -- if `require_standard` is true, then undefined program types will have already given an INPUTS_NOT_STANDARD response; if it's not true and #29843 has been merged, then we'll accept any witness including a null witness for undefined program types, so `RequiresNonEmptyWitness` should return false for them. That can change to true when they're defined in a soft-fork, but that's soft-fork behaviour, so should be fine.

But worrying about it in 29843 rather than here seems bes
...

💬 maflcko commented on pull request "kernel: improve BlockChecked ownership semantics":
(https://github.com/bitcoin/bitcoin/pull/33078#discussion_r2247146156)
would be easier to do this in-place? `block_to_connect=std::make_shared<CBlock>();`, as you mutate the copy anyway

💬 Sjors commented on pull request "Musig2 tests":
(https://github.com/bitcoin/bitcoin/pull/32724#issuecomment-3143470989)
This can be moved out of draft? (since the CI failure is unrelated)

Concept ACK

Just two test vectors? If there's more then it might make sense to put them in a JSON file.