👍 dergoegge approved a pull request: "ci: allow for any libc++ intrumentation & use it for TSAN"
(https://github.com/bitcoin/bitcoin/pull/33099#pullrequestreview-3075208244)
utACK 7aa5b67132dfb71e915675a3dbcb806284e08197

💬 Crypt-iQ commented on pull request "log: rate limiting followups":
(https://github.com/bitcoin/bitcoin/pull/33011#discussion_r2245259646)
Yup, I had also hit the lock contention logging issue in other parts of the test. I ran the suggested diff 100 times without any error. Will add.

💬 glozow commented on issue "doc: Mempool Policy documentation Outdated since TRUC":
(https://github.com/bitcoin/bitcoin/issues/32067#issuecomment-3139909112)
Right, this ended up in [BIP431](https://github.com/bitcoin/bips/blob/master/bip-0431.mediawiki#specification) but not our docs, which is not very clear.

> An individual TRUC transaction is permitted to be below the mempool min relay feerate, assuming it is considered within a package that meets the mempool's feerate requirements.

Happy to review a pull or I can open one

💬 stickies-v commented on pull request "refactor: GenTxid type safety followups":
(https://github.com/bitcoin/bitcoin/pull/33005#discussion_r2245365793)
> hmm, maybe should just do a brain dump to a gist sometime.

Please cc me if you do, would be very interested to see that.

> I think if they were (treated as) opaque handles and you had to use `GetInfo()` ... that would be fine fwiw.

I agree. Although not opaque, I think that's pretty much what the `GetEntry()` methods and `CTxMemPoolEntry` should support doing? But most of the mempool interface is still expecting iterators rather than entries, so it would require a bit of adding/chang
...

💬 darosior commented on pull request "validation: detect witness stripping early on":
(https://github.com/bitcoin/bitcoin/pull/33105#discussion_r2245380170)
I considered it and decided against because 1) whether to add the txid to the reject filter seems unrelated to standardness (and surprising that `-acceptnonstdtxn=1` would now break 1p1c in the adversarial case) and 2) a failure here means the witness is invalid by consensus, #29843 would already not allow it today on master.

💬 maflcko commented on pull request "ci: limit max stack size to 512 KiB":
(https://github.com/bitcoin/bitcoin/pull/33079#issuecomment-3139957274)
> > I wonder if it can be fixed by replacing the hard-coded
>
> I can't seem to recreate this locally, so going to follow up.

Same here, I can't reproduce, even on the same machine.

💬 darosior commented on pull request "validation: detect witness stripping early on":
(https://github.com/bitcoin/bitcoin/pull/33105#discussion_r2245449707)
I think this would be a bit confusing because it would need to return `true` for undefined program types, whereas we don't know yes if this type will require a witness or not (presumably yes, but hey). I also think it's brief enough to not warrant its own function. Happy to change it, but it seems cleaner this way.

💬 darosior commented on pull request "validation: detect witness stripping early on":
(https://github.com/bitcoin/bitcoin/pull/33105#discussion_r2245453045)
self nit: if i retouch, 0e22a1401c7edee8946f404dd0deb59a94231340's message is missing a word at the end of the second sentence.

💬 darosior commented on pull request "Bump SCRIPT_VERIFY flags to 64 bit":
(https://github.com/bitcoin/bitcoin/pull/32998#issuecomment-3140066988)
Concept ACK.

🤔 furszy reviewed a pull request: "index: fix wrong assert of current_tip == m_best_block_index"
(https://github.com/bitcoin/bitcoin/pull/32878#pullrequestreview-3075577814)
> Hi @furszy , sorry for the delay, I've picked your commit of the test, which I missed earlier.

No problem. This needs a rebase.

✅ fanquake closed an issue: "tsan: drop `DEBUG_LOCKORDER` macro from TSAN job?"
(https://github.com/bitcoin/bitcoin/issues/33087)

🚀 fanquake merged a pull request: "ci: allow for any libc++ intrumentation & use it for TSAN"
(https://github.com/bitcoin/bitcoin/pull/33099)

💬 willcl-ark commented on pull request "ci: Migrate CI to hosted Cirrus Runners":
(https://github.com/bitcoin/bitcoin/pull/32989#issuecomment-3140218000)
Pushed to fix the merge conflict, and addressed nits

💬 willcl-ark commented on pull request "ci: Migrate CI to hosted Cirrus Runners":
(https://github.com/bitcoin/bitcoin/pull/32989#discussion_r2245577820)
fixed in 7a33a8bea13 ci: add Cirrus cache host

💬 willcl-ark commented on pull request "ci: Migrate CI to hosted Cirrus Runners":
(https://github.com/bitcoin/bitcoin/pull/32989#discussion_r2245578296)
Fixed in 1587a7baa96 ci: dynamically match makejobs with cores

💬 fanquake commented on pull request "ci: Migrate CI to hosted Cirrus Runners":
(https://github.com/bitcoin/bitcoin/pull/32989#discussion_r2245584929)
Should be no gui after #33099

💬 nervana21 commented on pull request "validation: detect witness stripping early on":
(https://github.com/bitcoin/bitcoin/pull/33105#discussion_r2245589620)
Small nit. This comment could be updated now that we're checking for both `nonstandard` and `stripped` witnesses

```suggestion
// Check for witness-related policy violations.
```

💬 fanquake commented on pull request "ci: Migrate CI to hosted Cirrus Runners":
(https://github.com/bitcoin/bitcoin/pull/32989#issuecomment-3140270122)
TSAN failure (https://github.com/bitcoin/bitcoin/actions/runs/16651908244/job/47126650397?pr=32989#step:8:6056):
```bash
2025-07-31T14:39:40.396402Z [test] [net.cpp:2419] [void CConnman::SetTryNewOutboundPeer(bool)] [net] setting try another outbound peer=false
2025-07-31T14:39:40.396438Z [test] [net.cpp:3192] [void==================
WARNING: ThreadSanitizer: data race (pid=11584)
Write of size 8 at 0x7234000016f0 by main thread:
#0 blockmanager_tests::blockmanager_readblock_hash_mi
...

💬 1440000bytes commented on pull request "Reduce minrelaytxfee to 100 sats/kvB":
(https://github.com/bitcoin/bitcoin/pull/32959#issuecomment-3140353595)
Actually minrelaytxfee should be 10 sat/vbyte

👍 pablomartin4btc approved a pull request: "test: Use the same mocktime when migrating in wallet_migration.py"
(https://github.com/bitcoin/bitcoin/pull/33104#pullrequestreview-3075915901)
ACK 95c11728f423e1c655439f9248a314f083ef68ef

Since now `migrate_and_get_rpc` allows to the `mocked_time` to be passed, as it was already validating the timestamp in the backup filename within the function, wouldn't make sense anymore to do the validation [again](https://github.com/bitcoin/bitcoin/pull/33104/files#r2244750342) outside the function.