💬 hebasto commented on issue "ci: failure in Docker build step":
(https://github.com/bitcoin/bitcoin/issues/27492#issuecomment-1564220108)
> I think "rebase if this is seen" is an ok solution here.

It doesn't work: [before rebasing](https://cirrus-ci.com/build/6335819900780544) --> [after rebasing](https://cirrus-ci.com/build/4752523156783104).

👍 0xB10C approved a pull request: "p2p: Log addresses of stalling peers"
(https://github.com/bitcoin/bitcoin/pull/27761#pullrequestreview-1445980519)
Untested ACK fb02a3cd1a105bdf60ca39e1858e77685be88976

Somewhat related: net logging for specific IP subnets/addresses could also be useful for debugging something like #27705. Probably a bigger change though.

💬 TheCharlatan commented on pull request "ci: Add missing set -e to 01_base_install.sh":
(https://github.com/bitcoin/bitcoin/pull/27739#issuecomment-1564245461)
Re https://github.com/bitcoin/bitcoin/pull/27739#issuecomment-1564193669

> Can you share the output where it should say "Skip base install"? Because it should never be called twice
<details><summary>Details</summary>
<p>

ci_native_tidy_ccache
ci_native_tidy_depends
ci_native_tidy_previous_releases

Number of files: 979 (reg: 918, dir: 61)
Number of created files: 973 (reg: 918, dir: 55)
Number of deleted files: 0
Number of regular files transferred: 918
Total file size: 74.35M by
...

💬 MarcoFalke commented on pull request "ci: Add missing set -e to 01_base_install.sh":
(https://github.com/bitcoin/bitcoin/pull/27739#issuecomment-1564274015)
Ok so ` git config --global ci.base-install-done` evaluates to the empty string? Can you share the details where it is first set?


https://github.com/bitcoin/bitcoin/blob/fa534d780e0bb811b7b762cbd430e30f92dd7d7e/ci/test/01_base_install.sh#L81

💬 MarcoFalke commented on pull request "build: Add CMake-based build system":
(https://github.com/bitcoin/bitcoin/pull/25797#discussion_r1206672381)
?

💬 MarcoFalke commented on issue "ci: failure in Docker build step":
(https://github.com/bitcoin/bitcoin/issues/27492#issuecomment-1564277669)
That seems unrelated, see https://github.com/bitcoin/bitcoin/pull/25797/files#r1206672381

💬 antlsdl1 commented on issue "Release schedule for 26.0":
(https://github.com/bitcoin/bitcoin/issues/27758#issuecomment-1564287534)
0xEb0Ddc0579CF3894C78ae2C4A7d5ec3B36bFa13A 같은 **chrome-native://recent-tabs/**

🚀 fanquake merged a pull request: "refactor: Replace `std::optional<bilingual_str>` with `util::Result`"
(https://github.com/bitcoin/bitcoin/pull/25977)

💬 hebasto commented on pull request "build: Add CMake-based build system":
(https://github.com/bitcoin/bitcoin/pull/25797#discussion_r1206695310)
Oh... Bad rebasing. Thanks!

💬 hebasto commented on issue "ci: failure in Docker build step":
(https://github.com/bitcoin/bitcoin/issues/27492#issuecomment-1564303999)
> That seems unrelated, see [#25797 (files)](https://github.com/bitcoin/bitcoin/pull/25797/files#r1206672381)

Indeed. Sorry for noise.

💬 joostjager commented on pull request "Allow accepting non-standard transactions on mainnet":
(https://github.com/bitcoin/bitcoin/pull/27578#issuecomment-1564315193)
>Its direct peers will simply discard these when your node broadcasts them, and they will eventually be purged from your mempool as any other non-confirmed transaction.

Unless you have peers that run a patch to accept non-standard transactions?

Also if you are mining yourself and using core's block template, you need those txes to enter your mempool first?

🚀 fanquake merged a pull request: "init: Error if ignored bitcoin.conf file is found"
(https://github.com/bitcoin/bitcoin/pull/27302)

💬 TheCharlatan commented on pull request "ci: Add missing set -e to 01_base_install.sh":
(https://github.com/bitcoin/bitcoin/pull/27739#issuecomment-1564324755)
Re https://github.com/bitcoin/bitcoin/pull/27739#issuecomment-1564274015

> Can you share the details where it is first set?

Here is the entire output I am willing to share (the rest above prints my env, which I don't want to paste here)

<p>
<details>
Creating ubuntu:lunar container to run in
[+] Building 1.0s (9/9) FINISHED
=> [in
...

👍 stickies-v approved a pull request: "[23.x] rpc: Fix invalid bech32 handling"
(https://github.com/bitcoin/bitcoin/pull/27756#pullrequestreview-1446142241)
ACK d98770720885cdce1bbe2109a6d214c63fa1814a

Verified that the commit is identical to c2e9214effe9abecae6f81cb10158f9661065da3 (#27755). Change lgtm.

<details>
<summary><code>diff <(git show c2e9214effe9abecae6f81cb10158f9661065da3) <(git show d98770720885cdce1bbe2109a6d214c63fa1814a)</code></summary>

```
1c1
< commit c2e9214effe9abecae6f81cb10158f9661065da3
---
> commit d98770720885cdce1bbe2109a6d214c63fa1814a
336c336
< index b9233ef2c..9ade9e9ea 100755
---
> index b0f24e3b9..
...

💬 fanquake commented on pull request "doc: Add Python install notes to build-osx.md.":
(https://github.com/bitcoin/bitcoin/pull/27728#issuecomment-1564333068)
> Still Concept Nack?

Yes. Developers are free to use pyenv if they want, but it's not a requirement. I'd also say that most developers are likely using a version of Python which is actually much newer, than our oldest supported version.

Also, note that the `ds_store` and `mac_alias` packages will be dropped entirely after #27099, so I think there is even less need to make these changes at this point.

💬 MarcoFalke commented on pull request "ci: Add missing set -e to 01_base_install.sh":
(https://github.com/bitcoin/bitcoin/pull/27739#issuecomment-1564348866)
Well, it isn't building the image, just printing `CACHED`. I'd need the output from when it was built of the step that ran base_install:


```
CACHED [4/4] RUN ["bash", "-c", "cd /ci_base_install/ && set -o errexit && source ./ci/test/00_setup_env.sh && ./ci/test/01_base_install.sh"]

💬 MarcoFalke commented on pull request "ci: Add missing set -e to 01_base_install.sh":
(https://github.com/bitcoin/bitcoin/pull/27739#issuecomment-1564349776)
> the rest above prints my env, which I don't want to paste here

If you can reproduce on a fresh install of your OS, that'd help too

💬 hebasto commented on pull request "refactor: Replace `std::optional<bilingual_str>` with `util::Result`":
(https://github.com/bitcoin/bitcoin/pull/25977#issuecomment-1564350880)
> Looks like there is a clang bug. Could be fixed by either bumping it again, see #27682, but I am not sure how to do that for macOS. Or by replacing `return addrman;` with `return {std::move(addrman)};`, or something like that (temporarily).

Although GCC complains:
```
$ ./configure CONFIG_SITE=$PWD/depends/arm-linux-gnueabihf/share/config.site --enable-suppress-external-warnings CXXFLAGS="-Wextra -Wno-psabi"
$ make > /dev/null
addrdb.cpp: In function ‘util::Result<std::unique_ptr<AddrM
...

💬 dergoegge commented on pull request "fuzz: Change LIMIT_TO_MESSAGE_TYPE from a compile-time to a run-time setting":
(https://github.com/bitcoin/bitcoin/pull/27766#discussion_r1206750051)
I think we can just get rid of the `FUZZ_TARGET_MSG` macro including `MsgTypes()` and use `getAllNetMessageTypes` directly?

🤔 dergoegge reviewed a pull request: "fuzz: Change LIMIT_TO_MESSAGE_TYPE from a compile-time to a run-time setting"
(https://github.com/bitcoin/bitcoin/pull/27766#pullrequestreview-1446186895)
Concept ACK