💬 marcofleon commented on pull request "refactor: GenTxid type safety followups":
(https://github.com/bitcoin/bitcoin/pull/33005#discussion_r2242260982)
I'll leave as is.

💬 willcl-ark commented on pull request "Migrate CI to hosted Cirrus Runners":
(https://github.com/bitcoin/bitcoin/pull/32989#discussion_r2242286183)
Will get with the above if I re-touch

📝 waketraindev opened a pull request: "qt: clear command history when clearing the console"
(https://github.com/bitcoin/bitcoin/pull/33098)
Clears the command history in the qt console when the user clears the console output.

💬 Eunovo commented on pull request "Silent Payments: Receiving":
(https://github.com/bitcoin/bitcoin/pull/32966#discussion_r2242296189)
I've changed this to use to `/352h/1h`. I also edited `GenerateWalletDescriptor` to use `/352h/1h` for test chain.

💬 Eunovo commented on pull request "Silent Payments: Receiving":
(https://github.com/bitcoin/bitcoin/pull/32966#discussion_r2242297337)
Done

💬 Sjors commented on pull request "qt: clear command history when clearing the console":
(https://github.com/bitcoin/bitcoin/pull/33098#issuecomment-3135873608)
That seems like a good idea, but maybe open the PR on the GUI repo: https://github.com/bitcoin-core/gui

💬 ryanofsky commented on pull request "rpc: dumptxoutset height parameter follow-ups (29553)":
(https://github.com/bitcoin/bitcoin/pull/30808#issuecomment-3135880182)
> 29.0 is already tagged (archived), built, and released for a long time, so it isn't possible to change the release notes there now.

Thanks, this makes me think the nicest place to document compatibility information would probably be in RPC documentation itself. E.g. a note like "In version 29.0, the type and height parameters were added. Prior behavior was equivalent to passing type=latest". This way if an incompatible change is made and your script stops working, you coul just check RPC he
...

💬 Christewart commented on pull request "rpc: dumptxoutset height parameter follow-ups (29553)":
(https://github.com/bitcoin/bitcoin/pull/30808#issuecomment-3135891423)
Alternatively I believe 29.1 is publishing RC's, maybe it could be documented in that release with a note about how this change wasn't documented in the 29.0 release? 🤷‍♂️

💬 saikiran57 commented on pull request "Added rescan option for import descriptors":
(https://github.com/bitcoin/bitcoin/pull/31668#discussion_r2242347967)
HI @achow101 can you please approve this PR

💬 willcl-ark commented on pull request "ci: Only pass documented env vars":
(https://github.com/bitcoin/bitcoin/pull/33002#discussion_r2242331540)
Could be worth moving the comment from `02_run_container.sh` to here as this is where this format is first contructed.

```
# Append $USER to /tmp/env to support multi-user systems and $CONTAINER_NAME
# to allow support starting multiple runs simultaneously by the same user.
```

🤔 willcl-ark reviewed a pull request: "ci: Only pass documented env vars"
(https://github.com/bitcoin/bitcoin/pull/33002#pullrequestreview-3070987599)
This seems ok to me.

Should we update https://github.com/bitcoin/bitcoin/blob/00604296e178b13fb1a701a84deac1e20e15259d/ci/README.md?plain=1#L27 and https://github.com/bitcoin/bitcoin/blob/00604296e178b13fb1a701a84deac1e20e15259d/ci/README.md?plain=1#L46 as we now don't pass `$HOME` or `$PATH` in?

📝 waketraindev opened a pull request: "qt: clear command history when clearing the console"
(https://github.com/bitcoin-core/gui/pull/882)
Clears the command history in the qt console when the user clears the console output.

💬 ajtowns commented on pull request "Move `FreespaceChecker` class into its own module":
(https://github.com/bitcoin-core/gui/pull/881#issuecomment-3135937149)
ACK 4542412ae063903654fc1cd95f77889bae76d61c

nit: qt/intro.h forward decl of `class FreespaceChecker` is redundant since the header is included now.

✅ fanquake closed a pull request: "qt: clear command history when clearing the console"
(https://github.com/bitcoin/bitcoin/pull/33098)

💬 hebasto commented on pull request "Move `FreespaceChecker` class into its own module":
(https://github.com/bitcoin-core/gui/pull/881#issuecomment-3135971708)
> nit: qt/intro.h forward decl of `class FreespaceChecker` is redundant since the header is included now.

Thanks! Fixed.

📝 fanquake opened a pull request: "ci: allow for any libc++ intrumentation & use it for TSAN"
(https://github.com/bitcoin/bitcoin/pull/33099)
Allow for instrumenting libc++ with a sanitizer other than MemoryWithOrigins.

Would also close #33087, as with the extra instrumentation, the issue from https://github.com/bitcoin/bitcoin/pull/32862#issuecomment-3114706601 is avoided (also see https://github.com/bitcoin/bitcoin/pull/33081), and we can drop `DEBUG_LOCKORDER`.

👋 fanquake's pull request is ready for review: "ci: allow for any libc++ intrumentation & use it for TSAN"
(https://github.com/bitcoin/bitcoin/pull/33099)

💬 fanquake commented on pull request "rpc: use CScheduler for relocking wallet and remove RPCTimer":
(https://github.com/bitcoin/bitcoin/pull/32862#issuecomment-3135990566)
> the problem seems to be that libc++ itself isn't instrumented.

Following up on this in #33099.

📝 fanquake opened a pull request: "ci: remove `ninja-build` from MSAN jobs"
(https://github.com/bitcoin/bitcoin/pull/33100)
It is part of CI_BASE_PACKAGES.

👍 hebasto approved a pull request: "ci: remove `ninja-build` from MSAN jobs"
(https://github.com/bitcoin/bitcoin/pull/33100#pullrequestreview-3071150626)
ACK cab6736b701f203d6e823e1b5d619368d8d4c5e0, I have reviewed the code and it looks OK.