💬 achow101 commented on pull request "[POC] wallet: Add Support for BIP-353 DNS-Based Bitcoin Address via External Resolver":
(https://github.com/bitcoin/bitcoin/pull/33069#issuecomment-3133584656)
> How is it different than any other multi-process binary?

The multiprocess binaries are produced by this project, built using the same deterministic build system, using the same code as the monolithic binaries. There are already concrete ways that the binaries can be distributed with minimal changes to our own release process. Users who run the multiprocess binaries don't have to do any special configuration for them to work. This is different from requiring users to set a configuration opti
...

⚠️ jonatack opened an issue: "spurious failure in p2p_leak.py --v1transport"
(https://github.com/bitcoin/bitcoin/issues/33090)
### Is there an existing issue for this?

- [x] I have searched the existing issues

### Current behaviour

https://github.com/bitcoin/bitcoin/actions/runs/16601603414/job/46962514184?pr=31886

### Expected behaviour

This test should have passed.

### Steps to reproduce

See logs in

https://github.com/bitcoin/bitcoin/actions/runs/16601603414/job/46962514184?pr=31886

I cannot reproduce it locally.

### Relevant log output

_No response_

### How did you obtain Bitcoin Core

Compiled from sourc
...

💬 jonatack commented on pull request "cli: return local services in -netinfo":
(https://github.com/bitcoin/bitcoin/pull/31886#issuecomment-3133622663)
Yes, I opened an issue to report it: https://github.com/bitcoin/bitcoin/issues/33090

I don't see how to re-start that test.

💬 luke-jr commented on pull request "init: [gui] Avoid UB/crash in InitAndLoadChainstate":
(https://github.com/bitcoin/bitcoin/pull/32987#issuecomment-3133628881)
Alternative to the test option, Core could just add support for reindex=auto (#22072)

🚀 achow101 merged a pull request: "doc: add note for watch-only wallet migration"
(https://github.com/bitcoin/bitcoin/pull/32866)

💬 achow101 commented on pull request "wallet: Add `exportwatchonlywallet` RPC to export a watchonly version of a wallet":
(https://github.com/bitcoin/bitcoin/pull/32489#discussion_r2240683030)
The cache can only be generated if private keys are available, so we need this to write the cache to disk of the watchonly wallet.

💬 achow101 commented on pull request "wallet: Add `exportwatchonlywallet` RPC to export a watchonly version of a wallet":
(https://github.com/bitcoin/bitcoin/pull/32489#discussion_r2240684156)
I think export is a reasonable name since listing them is also an export.

💬 warp-records commented on issue "fuzz: Speed up mini_miner fuzz target?":
(https://github.com/bitcoin/bitcoin/issues/32870#issuecomment-3133776794)
> Looks like it is somewhat slow (c.f. https://cirrus-ci.com/task/6602192649453568?logs=ci#L5401), so it would be nice to make it faster.
>
> Possibly with txgraph, see [bitcoin-core/qa-assets#227 (comment)](https://github.com/bitcoin-core/qa-assets/pull/227#issuecomment-3032434420)

Can you close this now?

💬 achow101 commented on pull request "util: Abort on failing CHECK_NONFATAL in debug builds":
(https://github.com/bitcoin/bitcoin/pull/32588#issuecomment-3133809122)
ACK fa37153288ca420420636046ef6b8c4ba7e5a478

💬 maflcko commented on pull request "assumevalid: log every script validation state change":
(https://github.com/bitcoin/bitcoin/pull/32975#discussion_r2240783171)
Python does not have lifetimes in block scopes and `p2p1` will be visible outside of the block. Also, on a failure, the debug log snippet of this scope will be repeated, and will include irrelevant details twice.

📝 TheTyg opened a pull request: "circle paymaster"
(https://github.com/bitcoin/bitcoin/pull/33091)
implementation of circle pay

<!--
*** Please remove the following help text before submitting: ***

Pull requests without a rationale and clear improvement may be closed
immediately.

GUI-related pull requests should be opened against
https://github.com/bitcoin-core/gui
first. See CONTRIBUTING.md
-->

<!--
Please provide clear motivation for your patch and explain how it improves
Bitcoin Core user experience or Bitcoin Core developer experience
significantly:

* Any test impro
...

✅ hebasto closed a pull request: "circle paymaster"
(https://github.com/bitcoin/bitcoin/pull/33091)

💬 l0rinc commented on pull request "assumevalid: log every script validation state change":
(https://github.com/bitcoin/bitcoin/pull/32975#discussion_r2240810267)
Ok, sure, thanks for the context, narrowed the scope to send and sync only

📝 jordancampa23-ctrl opened a pull request: "Create Jordan Finesse👌"
(https://github.com/bitcoin/bitcoin/pull/33092)
<!--
*** Please remove the following help
[free.pdf](https://github.com/user-attachments/files/21497432/free.pdf)
[free.pdf](https://github.com/user-attachments/files/21497438/free.pdf)
text before submitting: ***

Pull requests without a rationale and clear improvement may be closed
immediately.

GUI-related pull requests should be opened against
https://github.com/bitcoin-core/gui
first. See CONTRIBUTING.md
-->

<!--
Please provide clear motivation for your patch and explain ho
...

💬 luke-jr commented on pull request "test: Add functional tests for blockreconstructionextratxn and extra pool (compactblocks)":
(https://github.com/bitcoin/bitcoin/pull/33023#discussion_r2241039496)
Missing a space

💬 bigshiny90 commented on pull request "test: Add functional tests for blockreconstructionextratxn and extra pool (compactblocks)":
(https://github.com/bitcoin/bitcoin/pull/33023#discussion_r2241107374)
fixed. Thanks!

💬 murchandamus commented on pull request "Reduce minrelaytxfee to 100 sats/kvB":
(https://github.com/bitcoin/bitcoin/pull/32959#issuecomment-3134232262)
> > should probably lower all three settings, not just the one. However, this breaks a dozen tests or so, there seem to be some more missing that it should be breaking, and feerate estimation currently doesn’t do below 1 s/vB
>
> @murchandamus I'm busy with this to make some progress while @RobinLinus is away, what's the process - create a new PR as a continuation of this one?

Given that this branch is on Robin’s repository, it would be the easiest to create your own branch and PR (unless
...

🤔 mzumsande reviewed a pull request: "init: [gui] Avoid UB/crash in InitAndLoadChainstate"
(https://github.com/bitcoin/bitcoin/pull/32987#pullrequestreview-3069373388)
Tested ACK fac90e5261b811739ada56e06ea793a12f9c2c3d

Unrelated, but just mentioning that reindex with the GUI is not great: I tried it with a regtest chain of 1000 empty blocks and the app froze for a few seconds / my OS asked me whether it should terminate the non-responding program. Didn't try it with mainnet, but it's probably not a smooth experience.

📝 l0rinc opened a pull request: "refactor: remove unused `ser_writedata16be` and `ser_readdata16be`"
(https://github.com/bitcoin/bitcoin/pull/33093)
Remove dead code from serialization logic - extracted from https://github.com/bitcoin/bitcoin/pull/31868

💬 l0rinc commented on pull request "[IBD] specialize block serialization":
(https://github.com/bitcoin/bitcoin/pull/31868#issuecomment-3134384578)
Rebased to solve conflict, the PR is still in draft mode until I remeasure its effect on IBD - and I need to find a nicer way to do the single-byte specializations, since they have a measurable effect but make the code super-ugly... Suggestions are welcome.
In the meantime I have split out the first refactor into https://github.com/bitcoin/bitcoin/pull/33093.