💬 MarcoFalke commented on pull request "ci: Add missing set -e to 01_base_install.sh":
(https://github.com/bitcoin/bitcoin/pull/27739#issuecomment-1564144864)
Can you replace `set -e` with `set -ex` and show the surrounding line?

💬 MarcoFalke commented on pull request "ci: Add missing set -e to 01_base_install.sh":
(https://github.com/bitcoin/bitcoin/pull/27739#issuecomment-1564146365)
I can't see how this can happen. The error doesn't happen in base_install, from what I can tell, so it seems unrelated to the changes here. However, it passing on master makes me puzzle.

👍 fanquake approved a pull request: "doc: Add doc/release-notes/release-notes-25.0.md"
(https://github.com/bitcoin/bitcoin/pull/27751#pullrequestreview-1445893134)
ACK 034cb5ad4d4b72cf1ba5b153a558fcf6a8afa9aa

🚀 fanquake merged a pull request: "doc: Add doc/release-notes/release-notes-25.0.md"
(https://github.com/bitcoin/bitcoin/pull/27751)

👍 stickies-v approved a pull request: "[24.x] rpc: Fix invalid bech32 handling"
(https://github.com/bitcoin/bitcoin/pull/27755#pullrequestreview-1445895299)
ACK c2e9214effe9abecae6f81cb10158f9661065da3

I verified that this backports eeee55f9288740747b6e8d806ce8177fd92635cf , but additionally includes some necessary changes from 962a0930e699b74b3c4d019427df6e2b3af5c831 to make compilation and tests work.

I don't see any other, unrelated changes.

📝 MarcoFalke opened a pull request: "fuzz: Change LIMIT_TO_MESSAGE_TYPE from a compile-time to a run-time setting"
(https://github.com/bitcoin/bitcoin/pull/27766)
The `process_message_${msg_type}` fuzz targets have many issues:

* In a context where each fuzz target must be a separate binary, this bloats the storage requirements by the number of message types.
* The qa-assets repo for fuzz inputs also bloats, because each input in the type specific folder (`./process_message_${msg_type}`) is accompanied by a similar input in the general folder (`./`process_message`). The size seems to be ~3GB for the sum of all folders vs 0.3GB for the general folder.
...

🤔 glozow reviewed a pull request: "test: Move test_chain_listunspent wallet check from mempool_packages to wallet_basic"
(https://github.com/bitcoin/bitcoin/pull/27735#pullrequestreview-1445910452)
ACK ffffe622e9cbf926326135bb23958380dcf09df1, thanks for changing! Nice to remove wallet from another non-wallet test.

💬 TheCharlatan commented on pull request "ci: Add missing set -e to 01_base_install.sh":
(https://github.com/bitcoin/bitcoin/pull/27739#issuecomment-1564189924)
Re https://github.com/bitcoin/bitcoin/pull/27739#issuecomment-1564144864

> Can you replace `set -e` with `set -ex` and show the surrounding line?

```
0 upgraded, 0 newly installed, 0 to remove and 1 not upgraded.
+ '[' -n '' ']'
+ [[ '' == \t\r\u\e ]]
+ [[ true == \t\r\u\e ]]
+ git clone --depth=1 https://github.com/include-what-you-use/include-what-you-use -b clang_16 /home/drgrid/bitcoin/ci/scratch/iwyu/include-what-you-use
fatal: destination path '/home/drgrid/bitcoin/ci/scratch/i
...

💬 MarcoFalke commented on pull request "ci: Add missing set -e to 01_base_install.sh":
(https://github.com/bitcoin/bitcoin/pull/27739#issuecomment-1564193669)
Can you share the output where it should say "Skip base install"? Because it should never be called twice

💬 MarcoFalke commented on pull request "ci: Add missing set -e to 01_base_install.sh":
(https://github.com/bitcoin/bitcoin/pull/27739#issuecomment-1564196636)
> `+ [[ true == \t\r\u\e ]]`

Unrelated: Anyone know why it prints "true" as "\t\r\u\e"? Maybe we should remove bash, but I am not sure if there is an alternative.

💬 willcl-ark commented on issue "bitcoind hangs waiting for `g_requests.empty()`":
(https://github.com/bitcoin/bitcoin/issues/27722#issuecomment-1564196898)
Hmmm, curiously enough I was not able to reproduce using either method on master @ aa6cc5bec9

With @theStack method:

```log
2023-05-26T10:39:07Z [http] Received a POST request for / from 127.0.0.1:50704
^C2023-05-26T10:39:10Z [http] Interrupting HTTP server
2023-05-26T10:39:10Z tor: Thread interrupt
2023-05-26T10:39:10Z torcontrol thread exit
2023-05-26T10:39:10Z addcon thread exit
2023-05-26T10:39:10Z opencon thread exit
2023-05-26T10:39:10Z Shutdown: In progress...
2023-05-26T10
...

💬 hebasto commented on issue "ci: failure in Docker build step":
(https://github.com/bitcoin/bitcoin/issues/27492#issuecomment-1564220108)
> I think "rebase if this is seen" is an ok solution here.

It doesn't work: [before rebasing](https://cirrus-ci.com/build/6335819900780544) --> [after rebasing](https://cirrus-ci.com/build/4752523156783104).

👍 0xB10C approved a pull request: "p2p: Log addresses of stalling peers"
(https://github.com/bitcoin/bitcoin/pull/27761#pullrequestreview-1445980519)
Untested ACK fb02a3cd1a105bdf60ca39e1858e77685be88976

Somewhat related: net logging for specific IP subnets/addresses could also be useful for debugging something like #27705. Probably a bigger change though.

💬 TheCharlatan commented on pull request "ci: Add missing set -e to 01_base_install.sh":
(https://github.com/bitcoin/bitcoin/pull/27739#issuecomment-1564245461)
Re https://github.com/bitcoin/bitcoin/pull/27739#issuecomment-1564193669

> Can you share the output where it should say "Skip base install"? Because it should never be called twice
<details><summary>Details</summary>
<p>

ci_native_tidy_ccache
ci_native_tidy_depends
ci_native_tidy_previous_releases

Number of files: 979 (reg: 918, dir: 61)
Number of created files: 973 (reg: 918, dir: 55)
Number of deleted files: 0
Number of regular files transferred: 918
Total file size: 74.35M by
...

💬 MarcoFalke commented on pull request "ci: Add missing set -e to 01_base_install.sh":
(https://github.com/bitcoin/bitcoin/pull/27739#issuecomment-1564274015)
Ok so ` git config --global ci.base-install-done` evaluates to the empty string? Can you share the details where it is first set?


https://github.com/bitcoin/bitcoin/blob/fa534d780e0bb811b7b762cbd430e30f92dd7d7e/ci/test/01_base_install.sh#L81

💬 MarcoFalke commented on pull request "build: Add CMake-based build system":
(https://github.com/bitcoin/bitcoin/pull/25797#discussion_r1206672381)
?

💬 MarcoFalke commented on issue "ci: failure in Docker build step":
(https://github.com/bitcoin/bitcoin/issues/27492#issuecomment-1564277669)
That seems unrelated, see https://github.com/bitcoin/bitcoin/pull/25797/files#r1206672381

💬 antlsdl1 commented on issue "Release schedule for 26.0":
(https://github.com/bitcoin/bitcoin/issues/27758#issuecomment-1564287534)
0xEb0Ddc0579CF3894C78ae2C4A7d5ec3B36bFa13A 같은 **chrome-native://recent-tabs/**

🚀 fanquake merged a pull request: "refactor: Replace `std::optional<bilingual_str>` with `util::Result`"
(https://github.com/bitcoin/bitcoin/pull/25977)

💬 hebasto commented on pull request "build: Add CMake-based build system":
(https://github.com/bitcoin/bitcoin/pull/25797#discussion_r1206695310)
Oh... Bad rebasing. Thanks!