💬 fanquake commented on pull request "test, tracing: don't use problematic `bpf_usdt_readarg_p()`":
(https://github.com/bitcoin/bitcoin/pull/31848#issuecomment-3131490987)
Followup to this in #33086.

⚠️ fanquake opened an issue: "tsan: drop `DEBUG_LOCKORDER` macro from TSAN job?"
(https://github.com/bitcoin/bitcoin/issues/33087)
It was pointed out in https://github.com/bitcoin/bitcoin/pull/32862#issuecomment-3114706601 that that PR uncovered a false positive libc++ tsan warning. It was not initially clear to me why the issue was not happening in the TSAN CI. The reason it does not, is because of `DEBUG_LOCKORDER`. Dropping that from the TSAN CI job does shows the issue. i.e #33081.

I am wondering if the TSAN job should be split up, so that TSAN & `DEBUG_LOCKORDER` do not interfere with each other. It seems better to no
...

💬 0xB10C commented on pull request "contrib: [tracing] fix pointer argument handling in mempool_monitor.py":
(https://github.com/bitcoin/bitcoin/pull/33086#issuecomment-3131511278)
tested ACK 0ce041ea88dbea2bdfaf21fd0e60a86012498f0a

Thanks! I can reproduce the problem and confirm that this fixes it.

💬 fanquake commented on pull request "ci: limit max stack size to 512 KiB":
(https://github.com/bitcoin/bitcoin/pull/33079#issuecomment-3131522841)
https://cirrus-ci.com/task/6487729824858112?logs=ci#L827:
```bash
test 2025-07-28T22:00:07.479407Z TestFramework.bitcoincli (DEBUG): Running bitcoin-cli ['rpc', '-nonamed', '-datadir=/ci_container_base/ci/scratch/test_runner/test_runner_₿_🏃_20250728_215126/wallet_groups_239/node0', 'signrawtransactionwithwallet', '0200000003fbf5404d2aa65d475fdf74a2f5b50f4fb51c8cf46961be8e58f384f2754ac2470100000000fdffffff32b3cd850a25122c1c203103a500bb61d492c38b598ff5079aa60070c52961560100000000fdffffff53a17
...

💬 fanquake commented on pull request "wallet, refactor: Remove Legacy check and error":
(https://github.com/bitcoin/bitcoin/pull/33082#issuecomment-3131553130)
https://github.com/bitcoin/bitcoin/actions/runs/16577317093/job/46884696846?pr=33082#step:7:2967:
```bash
131/145 Test #7: bench_sanity_check ...................Subprocess aborted***Exception: 30.55 sec
Running with -sanity-check option, output is being suppressed as benchmark results will be useless.
wallet/wallet.cpp:521 UpgradeDescriptorCache: Assertion `IsWalletFlagSet(WALLET_FLAG_DESCRIPTORS)' failed.
```

🚀 fanquake merged a pull request: "contrib: [tracing] fix pointer argument handling in mempool_monitor.py"
(https://github.com/bitcoin/bitcoin/pull/33086)

💬 fanquake commented on pull request "contrib: [tracing] fix pointer argument handling in mempool_monitor.py":
(https://github.com/bitcoin/bitcoin/pull/33086#issuecomment-3131654211)
Backported to `29.x` in #33074.

💬 moonfury-ops commented on issue "Bitcoin Kernel Library Project Tracking":
(https://github.com/bitcoin/bitcoin/issues/27587#issuecomment-3131701221)
Hello @TheCharlatan

I’m particularly interested in the following areas:

API design and language bindings — I’d be happy to contribute or test bindings for additional environments such as JavaScript, Kotlin, or Dart.
Read-only clients and context-minimal validation — These directions align well with lightweight and alternative Bitcoin client use cases. Abstracting data storage and validation dependencies is a meaningful step toward broader adoption.
Standalone repository plans — The goal of ma
...

💬 moonfury-ops commented on issue "kernel: feedback on using kernel in alternative implementations":
(https://github.com/bitcoin/bitcoin/issues/31878#issuecomment-3131724379)
Hello @Davidson-Souza

The need for a context-minimal, SANS-IO validation interface is especially compelling.
Being able to reuse Bitcoin Core's consensus logic without depending on its internal database (e.g., leveldb-backed UTXO set) would enable a wide range of innovative projects to maintain compatibility and safety without needing to reimplement fragile or underspecified parts of the protocol.
Your suggestion of a middle-ground approach—a separate module or mode under the libbitcoinkernel
...

👍 TheCharlatan approved a pull request: "kernel: create monolithic kernel static library"
(https://github.com/bitcoin/bitcoin/pull/33077#pullrequestreview-3066726770)
ACK fdbade6f8ded63519b637c8fa6f39914a400ab5e

The alternative of requiring upstream consumers to use cmake to import the library topology into their projects seems a bit heavy handed to me.

💬 fanquake commented on pull request "depends: hard-code necessary c(xx)flags rather than setting them per-host":
(https://github.com/bitcoin/bitcoin/pull/32584#issuecomment-3131746003)
@ryanofsky made some changes to try and address your feedback.

📝 fanquake opened a pull request: "doc: move `cmake -B build -LH` up in Unix build docs"
(https://github.com/bitcoin/bitcoin/pull/33088)
#32269 rebased.

> I had trouble building bitcoin core the way I wanted since now more features require a flag while building. IMO it makes sense to make it a bit more prominent in the build docs how to get the needed flags.

> Related issue: https://github.com/bitcoin/bitcoin/issues/32258

✅ fanquake closed a pull request: "doc: update unix build doc with build flags"
(https://github.com/bitcoin/bitcoin/pull/32269)

💬 fanquake commented on pull request "doc: update unix build doc with build flags":
(https://github.com/bitcoin/bitcoin/pull/32269#issuecomment-3131921976)
Rebased this is in #33088.

🤔 danielabrozzoni reviewed a pull request: "cli: return local services in -netinfo"
(https://github.com/bitcoin/bitcoin/pull/31886#pullrequestreview-3066765486)
tACK 943ee6768d9f94da70aaf90d346d4cf2ea1fa39d

I left a micro nit, feel free to ignore if you don't need to retouch

💬 danielabrozzoni commented on pull request "cli: return local services in -netinfo":
(https://github.com/bitcoin/bitcoin/pull/31886#discussion_r2239320315)
nit: add local services to the comment

👍 ryanofsky approved a pull request: "depends: hard-code necessary c(xx)flags rather than setting them per-host"
(https://github.com/bitcoin/bitcoin/pull/32584#pullrequestreview-3067012972)
Code review ACK 9954d6c833381a44e1ea34d182ffe4d61b65d2ba. No changes since last review other than improving the commit message. Change overall makes sense because it deduplicates host definitions, stops dropping `-std` flags from package builds when custom CFLAGS/CXXFLAGS environment variables are set, and stops passing duplicate flags to cmake that have no effect.

👋 sdaftuar's pull request is ready for review: "[WIP] Cluster mempool implementation"
(https://github.com/bitcoin/bitcoin/pull/28676)

💬 sdaftuar commented on pull request "[WIP] Cluster mempool implementation":
(https://github.com/bitcoin/bitcoin/pull/28676#issuecomment-3132158578)
> I fuzzed this branch ([3bfaedb](https://github.com/bitcoin/bitcoin/commit/3bfaedbd7d9d6e71e9df03fbbb51a33c6184cca6)) with [fuzzamoto](https://github.com/dergoegge/fuzzamoto) and it found an assertion crash in `CTxMemPool::check`.

@dergoegge @instagibbs Thank you both for detecting and pinpointing the bug! Should be fixed now in this branch.

💬 purpleKarrot commented on pull request "kernel: create monolithic kernel static library":
(https://github.com/bitcoin/bitcoin/pull/33077#issuecomment-3132165160)
For https://habla.news/u/purplekarrot.net/cmake-import-export, I have set up several example projects for exporting cmake packages and I deliberately mismatched consumers by using gcc, clang, and msvc.

I am making the bold claim that there is no working alternative to shipping a shared library with cmake package information. Consuming a static library requires a consistent toolchain. `.pc` files are not reloatable.

I will happily remove my NACK once I am proven wrong with a counterexample.
...