💬 glozow commented on pull request "doc: Add legacy wallet removal release notes":
(https://github.com/bitcoin/bitcoin/pull/33075#issuecomment-3129052068)
lgtm ACK fa45ccc15dfc52e798da62548dc43d1bd7889c9a

💬 Crypt-iQ commented on pull request "log: rate limiting followups":
(https://github.com/bitcoin/bitcoin/pull/33011#discussion_r2237712566)
Fixed in 8319a134684df2240057a5e8afaa6ae441fb8a58

💬 Crypt-iQ commented on pull request "log: rate limiting followups":
(https://github.com/bitcoin/bitcoin/pull/33011#discussion_r2237714115)
Fixed in 526403df23a2db781709e4494da3a9f79284531d

💬 Crypt-iQ commented on pull request "log: rate limiting followups":
(https://github.com/bitcoin/bitcoin/pull/33011#discussion_r2237715936)
Fixed in 526403df23a2db781709e4494da3a9f79284531d, renamed `DEBUG` to `DEBUG_LOG` since the former is a macro

💬 Crypt-iQ commented on pull request "log: rate limiting followups":
(https://github.com/bitcoin/bitcoin/pull/33011#discussion_r2237716554)
Fixed in 526403df23a2db781709e4494da3a9f79284531d

💬 Crypt-iQ commented on pull request "log: rate limiting followups":
(https://github.com/bitcoin/bitcoin/pull/33011#discussion_r2237717014)
Fixed in 526403df23a2db781709e4494da3a9f79284531d

💬 Crypt-iQ commented on pull request "log: rate limiting followups":
(https://github.com/bitcoin/bitcoin/pull/33011#discussion_r2237718141)
Fixed in 526403df23a2db781709e4494da3a9f79284531d

💬 Crypt-iQ commented on pull request "log: rate limiting followups":
(https://github.com/bitcoin/bitcoin/pull/33011#discussion_r2237719250)
Fixed in 65c8072757e58f9cad1198ddd8e403d656bb68e2

💬 Crypt-iQ commented on pull request "log: rate limiting followups":
(https://github.com/bitcoin/bitcoin/pull/33011#discussion_r2237727363)
Implemented in 526403df23a2db781709e4494da3a9f79284531d, but I think there is a CI failure now.

💬 glozow commented on pull request "truc: optimize the in package relation calculation":
(https://github.com/bitcoin/bitcoin/pull/33062#discussion_r2237728176)
Ah right, it actually doesn't help there

💬 Crypt-iQ commented on pull request "log: rate limiting followups":
(https://github.com/bitcoin/bitcoin/pull/33011#issuecomment-3129226672)
The latest push 526403df23a2db781709e4494da3a9f79284531d:
- makes `m_limiter` a `std::shared_ptr`
- adds a commit to remove double-hashing in `SourceLocationHasher` (b8e92fb3d4137f91fe6a54829867fc54357da648)
- changes `logging_filesize_rate_limit` to dedupe logic and explicitly check for certain rate-limiting logs

The CI is [failing](https://api.cirrus-ci.com/v1/task/6153650155814912/logs/ci.log) with `DEBUG_LOCKORDER` as `ReadDebugLogLines` is matching against a log from the scheduler hav
...

💬 l0rinc commented on pull request "test: revive test verifying that `GetCoinsCacheSizeState` switches from OK→LARGE→CRITICAL":
(https://github.com/bitcoin/bitcoin/pull/33021#issuecomment-3129437534)
Rebased, no other change needed, ready for review

💬 sdaftuar commented on pull request "validation: docs and cleanups for MemPoolAccept coins views":
(https://github.com/bitcoin/bitcoin/pull/32973#issuecomment-3129561181)
utACK b6d4688f77df9e31fd64e2be300f55bb8e944bd0

💬 RobinLinus commented on pull request "Reduce minrelaytxfee to 100 sats/kvB":
(https://github.com/bitcoin/bitcoin/pull/32959#issuecomment-3129732783)
> @RobinLinus, are you planning on working on this?

I'm interested in working on this, but I'm currently too busy moving apartments. I plan to revisit it in about two weeks. In the meantime, it would be greatly appreciated if someone could help fix the tests that fail when adjusting DEFAULT_BLOCK_MIN_TX_FEE.

💬 l0rinc commented on pull request "test,refactor: extract script template helpers & widen sigop count coverage":
(https://github.com/bitcoin/bitcoin/pull/32729#issuecomment-3129749041)
Rebased after https://github.com/bitcoin/bitcoin/pull/32279 - updating the tests with the new convenience template helpers instead of using `Solver` for them. Ready for review again.

💬 purpleKarrot commented on pull request "kernel: Introduce initial C header API":
(https://github.com/bitcoin/bitcoin/pull/30595#issuecomment-3129870494)
I see in the C++ wrapper that a lot of functions are marked `noexcept`. I assume that the rationale is: "since this function just wraps a C function and C functions cannot throw, the function could just as well be marked `noexcept`".

But this is not how the keyword is meant to be used. The `noexcept` keyword is intended to be used on functions that should not be *allowed* to throw. The compiler then generates a runtime check to terminate the program in the case that the function throws. You c
...

💬 l0rinc commented on pull request "[IBD] Tracking PR for speeding up Initial Block Download":
(https://github.com/bitcoin/bitcoin/pull/32043#issuecomment-3129873283)
Thanks for reviewing and reproducing https://github.com/bitcoin/bitcoin/pull/32279 - it's also merged 🎉
* https://github.com/bitcoin/bitcoin/pull/32497
* https://github.com/bitcoin/bitcoin/pull/30442

Reviews and ACKs for the above 2 remaining ones would be very welcome.

✅ l0rinc closed a pull request: "doc: Fix invalid txid in `gettransaction` RPC example"
(https://github.com/bitcoin/bitcoin/pull/31610)

💬 l0rinc commented on pull request "doc: Fix invalid txid in `gettransaction` RPC example":
(https://github.com/bitcoin/bitcoin/pull/31610#issuecomment-3129900375)
Closing, it seems these invalid examples are on purpose - even though I think there are better ways to "prevent accidental transactions by users" than making the examples 63 characters long.

📝 darosior opened a pull request: "qa: test that we do not disconnect a peer for submitting an invalid compact block"
(https://github.com/bitcoin/bitcoin/pull/33083)
In thinking about https://github.com/bitcoin/bitcoin/pull/33050 and https://github.com/bitcoin/bitcoin/pull/33012#issuecomment-3111631541, i went through the code paths for peer disconnection upon submitting an invalid block. It turns out that the fact we exempt a peer from disconnection upon submitting an invalid compact block was not properly tested, as can be checked with these diffs:
```diff
diff --git a/src/net_processing.cpp b/src/net_processing.cpp
index https://github.com/bitcoin/bitc
...