💬 furszy commented on pull request "wallet: improve IBD sync time by skipping block scanning prior birth time":
(https://github.com/bitcoin/bitcoin/pull/27469#issuecomment-1563661471)
> To review this PR I wrote a simple functional test: https://github.com/pinheadmz/bitcoin/commit/1f0f945aca3a4f5118e49b2d31318ddd4b19d906 which surprised me by failing. I added logging and comments to the test to share it because I don't entirely understand what's happening but it looks to me like, the wallet generates a combo(...) descriptor with a timestamp of 1 and therefore the wallet creation time is always 1 and so the new logic doesn't actually skip any blocks. But if that's the case, do
...

💬 furszy commented on pull request "wallet: when a block is disconnected, update transactions that are no longer conflicted":
(https://github.com/bitcoin/bitcoin/pull/27145#issuecomment-1563723413)
> I've fixed a bug which resulted in the conflicted tx not being marked as inactive if the conflicting tx was not in mapTxSpends.

Could you expand this?

Not sure if I follow the [latest push](https://github.com/bitcoin/bitcoin/compare/6f1d394896fcc7e2687b766418f9cd4e55b613b5..89df7987c2f1eea42454c2b0efc31a924fbfd3a8), where only the inequality was changed.
If `mapTxSpends.count(outpoint) == 1`, the outpoint was spent only once, so the wallet shouldn't contain any conflicting tx.

💬 furszy commented on pull request "wallet: when a block is disconnected, update transactions that are no longer conflicted":
(https://github.com/bitcoin/bitcoin/pull/27145#discussion_r1206163032)
yeah, great if that is already covered.
(sorry for the delayed answer)

📝 nowyouseeithaha opened a pull request: "Patch-1"
(https://github.com/bitcoin/bitcoin/pull/27764)

✅ pinheadmz closed a pull request: "Patch-1"
(https://github.com/bitcoin/bitcoin/pull/27764)

📝 fanquake locked a pull request: "Patch-1"
(https://github.com/bitcoin/bitcoin/pull/27764)

💬 ajtowns commented on pull request "p2p: Log addresses of stalling peers":
(https://github.com/bitcoin/bitcoin/pull/27761#discussion_r1206228638)
Should be `Peer=%d%s` (the result of strprintf isn't a number) and `peeraddr=%s` (for better consistency with other `fLogIPs` logs)

💬 mzumsande commented on pull request "p2p: Log addresses of stalling peers":
(https://github.com/bitcoin/bitcoin/pull/27761#discussion_r1206242431)
fixed, thanks.

💬 MarcoFalke commented on pull request "kernel: Remove shutdown from kernel library":
(https://github.com/bitcoin/bitcoin/pull/27711#issuecomment-1563846514)
> It also provides an easy way to see when calls to shutdown are made without returning to the calling function.

Can you explain this? Am I correct when guessing that any added EXIT* macro, and not the BUBBLE* macros are indicating a missing return?

📝 MarcoFalke opened a pull request: "test: Throw error when -signetchallenge is non-hex"
(https://github.com/bitcoin/bitcoin/pull/27765)
Instead of silently parsing non-hex to an empty challenge, throw an error.

Also, add missing includes while touching the file.

💬 MarcoFalke commented on pull request "test: Move test_chain_listunspent wallet check from mempool_packages to wallet_basic":
(https://github.com/bitcoin/bitcoin/pull/27735#issuecomment-1563922719)
Thx, done

💬 MarcoFalke commented on pull request "doc: Add doc/release-notes/release-notes-25.0.md":
(https://github.com/bitcoin/bitcoin/pull/27751#discussion_r1206361499)
```suggestion
- Transactions of non-witness size 65 bytes and above are now allowed by mempool
```

💬 MarcoFalke commented on pull request "doc: Add doc/release-notes/release-notes-25.0.md":
(https://github.com/bitcoin/bitcoin/pull/27751#discussion_r1206363521)
why? There is no list of all pulls in the notes, so the number is without context?

💬 MarcoFalke commented on pull request "doc: Add doc/release-notes/release-notes-25.0.md":
(https://github.com/bitcoin/bitcoin/pull/27751#issuecomment-1563956991)
Fixed the broken link. Not sure about the other nits.

💬 stratospher commented on pull request "p2p: Log addresses of stalling peers":
(https://github.com/bitcoin/bitcoin/pull/27761#issuecomment-1563972944)
tACK fb02a3c.

nice to have this! cross checked locations where we'd like inbound peer/disconnection peeraddr logging.
(you may have to rebase on master for green CI.)

👍 TheCharlatan approved a pull request: "init: Error if ignored bitcoin.conf file is found"
(https://github.com/bitcoin/bitcoin/pull/27302#pullrequestreview-1445624581)
ACK eefe56967b4eb4b5144325cde4f40fc1cbde3e65

💬 1ma commented on pull request "Allow accepting non-standard transactions on mainnet":
(https://github.com/bitcoin/bitcoin/pull/27578#issuecomment-1564059817)
There are no risks in submitting non-standard transactions to your own node's mempool. Its direct peers will simply discard these when your node broadcasts them, and they will eventually be purged from your mempool as any other non-confirmed transaction.

If anything, node runners want to be able to apply more filters/standardness rules (increased sovereignty), not disable them (decreased sovereignty).

👍 TheCharlatan approved a pull request: "test: Throw error when -signetchallenge is non-hex"
(https://github.com/bitcoin/bitcoin/pull/27765#pullrequestreview-1445755490)
Nice, ACK fa6b11a55663e70369bfbbba5fccc55b33f2b310

💬 kevkevinpal commented on pull request "test: Throw error when -signetchallenge is non-hex":
(https://github.com/bitcoin/bitcoin/pull/27765#issuecomment-1564100105)
ACK [fa6b11a](https://github.com/bitcoin/bitcoin/pull/27765/commits/fa6b11a55663e70369bfbbba5fccc55b33f2b310)

💬 TheCharlatan commented on pull request "ci: Add missing set -e to 01_base_install.sh":
(https://github.com/bitcoin/bitcoin/pull/27739#issuecomment-1564122573)
Still not sure what is going on here:

```
MAKEJOBS="-j12" FILE_ENV="./ci/test/00_setup_env_native_tidy.sh" ./ci/test_run_all.sh
> ...
> fatal: destination path '/home/drgrid/bitcoin/ci/scratch/iwyu/include-what-you-use' already exists and is not an empty directory.
ls home/drgrid/bitcoin/ci/scratch/iwyu/include-what-you-use
> ls: cannot access 'home/drgrid/bitcoin/ci/scratch/iwyu/include-what-you-use': No such file or directory
```

Command runs fine on master, so likely something tha
...