💬 maflcko commented on pull request "RPC: Return `permitbaremultisig` and `maxdatacarriersize` in `getmempoolinfo`":
(https://github.com/bitcoin/bitcoin/pull/29954#issuecomment-3125877362)
lgtm ACK 1c10b7351e194fc788766347f65f4512f61f05e8

📝 maflcko converted_to_draft a pull request: "ci: Run unit test parallel with functional tests"
(https://github.com/bitcoin/bitcoin/pull/33000)
Fixes https://github.com/bitcoin/bitcoin/issues/32770

💬 maflcko commented on pull request "ci: Run unit test parallel with functional tests":
(https://github.com/bitcoin/bitcoin/pull/33000#issuecomment-3125926982)
The implementation can be adjusted, if needed. I guess the main questions are:

* Do people want to use this locally, if yes, then there could be a more user friendly way of calling it?
* Does it help with the new CI? With the old CI system planned to be replaced, it makes little sense to fine-tune it this late, so I'll turn this into a draft for now.

💬 maflcko commented on pull request "[IBD] prevector: store `P2WSH`/`P2TR`/`P2PK` scripts inline":
(https://github.com/bitcoin/bitcoin/pull/32279#issuecomment-3126102054)
review ACK d5104cfbaeb82081e4b00a5084516555e446dcdc 🐺

<details><summary>Show signature</summary>

Signature:

```
untrusted comment: signature from minisign secret key on empty file; verify via: minisign -Vm "${path_to_any_empty_file}" -P RWTRmVTMeKV5noAMqVlsMugDDCyyTSbA3Re5AkUrhvLVln0tSaFWglOw -x "${path_to_this_whole_four_line_signature_blob}"
RUTRmVTMeKV5npGrKx1nqXCw5zeVHdtdYURB/KlyA/LMFgpNCs+SkW9a8N95d+U4AP1RJMi+krxU1A3Yux4bpwZNLvVBKy0wLgM=
trusted comment: review ACK d5104cfbaeb8
...

💬 w0xlt commented on pull request "[POC] wallet: Add Support for BIP-353 DNS-Based Bitcoin Address via External Resolver":
(https://github.com/bitcoin/bitcoin/pull/33069#issuecomment-3126116213)
I've created a C++ implementation of the dnssec-prover, available at: [https://github.com/w0xlt/dnssec-validation](https://github.com/w0xlt/dnssec-validation).
This implementation focuses solely on the DNSSEC **validation** component, which is the critical aspect for our use case.

The `dnssec-validation` binary can also be used as an external dependency in this PR. Functionally, it mirrors `dnssec-prover`, with the main difference being its C++ codebase.

If the goal is to eventually integ
...

💬 maflcko commented on pull request "test: refactor mempool_accept_wtxid":
(https://github.com/bitcoin/bitcoin/pull/33067#issuecomment-3126119690)
> This PR improves mempool_accept_wtxid.py by:
>
> 1. Using a pre-mined chain instead of generating new blocks [522bf76](https://github.com/bitcoin/bitcoin/commit/522bf76d7d8058872a008a721831da264881746d)
>
> 2. Using MiniWallet to avoid RPC calls for signing transactions [4ec5ae9](https://github.com/bitcoin/bitcoin/commit/4ec5ae9fe126ffabcd429277092e3b27f483d430)
>
> 3. Removing child txid variables and using txid.hex directly [361ebd5](https://github.com/bitcoin/bitcoin/co
...

💬 maflcko commented on pull request "test: fix RPC coverage check":
(https://github.com/bitcoin/bitcoin/pull/33064#issuecomment-3126161329)
lgtm ACK 8aed477c3322212a636ab69d4923f89e2d9a63a2

💬 fanquake commented on pull request "guix: accomodate migration to codeberg":
(https://github.com/bitcoin/bitcoin/pull/32439#issuecomment-3126171593)
> FYI my build fails. (But this may have nothing to do with the migration to codeber.):

Yes, the change here is unrelated to the package in Guix.

💬 fanquake commented on pull request "ci: Run unit test parallel with functional tests":
(https://github.com/bitcoin/bitcoin/pull/33000#issuecomment-3126249529)
> Does it help with the new CI? With the old CI system planned to be replaced, it makes little sense to fine-tune it this late, so I'll turn this into a draft for now.

cc @m3dwards @willcl-ark

💬 willcl-ark commented on pull request "Migrate CI to hosted Cirrus Runners":
(https://github.com/bitcoin/bitcoin/pull/32989#issuecomment-3126274500)
This push extracts the repeated `set CI directories` and `Set cache paths` logic into a `configure-environment` action

```yaml
- name: Set CI directories
run: |
echo "BASE_ROOT_DIR=${{ runner.temp }}" >> "$GITHUB_ENV"
echo "BASE_BUILD_DIR=${{ runner.temp }}/build-${{ matrix.build-dir-suffix }}" >> "$GITHUB_ENV"
- name: Set cache paths
run: |
...
```

and simplifies the `configure-docker` action string building to avoid repeat
...

💬 maflcko commented on pull request "ci: Run unit test parallel with functional tests":
(https://github.com/bitcoin/bitcoin/pull/33000#issuecomment-3126276906)
I'd say it should be done after the move. No need to delay the move or block it on this.

🚀 fanquake merged a pull request: "doc/zmq: fix unix socket path example"
(https://github.com/bitcoin/bitcoin/pull/33070)

✅ rkrux closed a pull request: "rpc, doc: clarify watch-only wallets balances in RPCHelp"
(https://github.com/bitcoin/bitcoin/pull/32761)

💬 willcl-ark commented on pull request "Migrate CI to hosted Cirrus Runners":
(https://github.com/bitcoin/bitcoin/pull/32989#issuecomment-3126343860)
Some noteworthy observations from the last two weeks of runs:

1. We have seen variance in network speeds occasionally which has been raised with Cirrus. e.g. in [this run](https://github.com/testing-cirrus-runners/bitcoin/actions/runs/16564301804/job/46840539119#step:4:48) we can see a cache restore hanging for 5 minutes:

<img width="2078" height="498" alt="image" src="https://github.com/user-attachments/assets/f87526f7-386b-40c8-9b3a-f9e7ca284c8f" />

It seems to manifest intermitte
...

📝 willcl-ark opened a pull request: "guix: warn SOURCE_DATE_EPOCH set in guix-codesign"
(https://github.com/bitcoin/bitcoin/pull/33073)
#32678 added a sanity check for this environment variable when running `guix-build` but missed that `guix-codesign` also relies on `SOURCE_DATE_EPOCH`, which can result in non-determinism in the codesigning step: https://github.com/bitcoin-core/guix.sigs/pull/1720#issuecomment-3124332676

To avoid repeating the logic move common functionality into the prelude and call the function in both guix actions.

💬 rkrux commented on pull request "doc: add note for watch-only wallet migration":
(https://github.com/bitcoin/bitcoin/pull/32866#discussion_r2235557541)
Done

💬 rkrux commented on pull request "doc: add note for watch-only wallet migration":
(https://github.com/bitcoin/bitcoin/pull/32866#issuecomment-3126359553)
> ACK [9d25880](https://github.com/bitcoin/bitcoin/commit/9d25880bb720bc675a533098268b9e02f86e17ce)
>
> Happy to re-ack if you touch it again to address the LLM linter suggestion.

Done

📝 fanquake opened a pull request: "[29.x] Backports"
(https://github.com/bitcoin/bitcoin/pull/33074)
Backports:
* #33070

💬 musaHaruna commented on pull request "rpc: Distinguish between vsize and sigop adjusted mempool vsize":
(https://github.com/bitcoin/bitcoin/pull/32800#discussion_r2235578787)
Yeah agreed, to be left as follow-up if others agree.

📝 maflcko opened a pull request: "doc: Add legacy wallet removal release notes"
(https://github.com/bitcoin/bitcoin/pull/33075)
This spans over several pulls, so add a single note for all of them.