💬 yancyribbens commented on pull request "test: add assertions to SRD max weight test":
(https://github.com/bitcoin/bitcoin/pull/33058#discussion_r2232042405)
Is it not true that when the max weight is encountered, the least valuable utxo is removed from the selection via the min-heap? Therefore the most valuable are returned?

💬 achow101 commented on pull request "test: Move `script_assets_tests` into its own suite":
(https://github.com/bitcoin/bitcoin/pull/31576#issuecomment-3120430867)
ACK c40dbbbf77078bb86a652ca151b472e7bef61ae0

💬 willcl-ark commented on pull request "Migrate CI to hosted Cirrus Runners":
(https://github.com/bitcoin/bitcoin/pull/32989#discussion_r2232047661)
Thanks! Removed in a4084cb7554

💬 willcl-ark commented on pull request "Migrate CI to hosted Cirrus Runners":
(https://github.com/bitcoin/bitcoin/pull/32989#discussion_r2232048386)
I have linked to the commit in e83c3718f2c and removed the dangling DANGER_DOCKER_BUILD_CACHE_HOST_DIR below

💬 willcl-ark commented on pull request "Migrate CI to hosted Cirrus Runners":
(https://github.com/bitcoin/bitcoin/pull/32989#discussion_r2232048838)
echo also removed in e83c3718f2c

💬 furszy commented on pull request "index: initial sync speedup, parallelize process":
(https://github.com/bitcoin/bitcoin/pull/26966#discussion_r2232051304)
done!

💬 willcl-ark commented on pull request "Migrate CI to hosted Cirrus Runners":
(https://github.com/bitcoin/bitcoin/pull/32989#discussion_r2232051946)
6d252266e40 and 3e757e511a3 have had the `USE_CIRRUS_RUNNERS` variable removed as it is confusing and doesn't work on PR's to downstream forks as expected (which is partially what it is for).

760497ac393 gives some hints on what a fork should patch, should they wish to use Cirrus Runners on their own CI.

💬 furszy commented on pull request "index: initial sync speedup, parallelize process":
(https://github.com/bitcoin/bitcoin/pull/26966#discussion_r2232052962)
yes, fixed.

💬 willcl-ark commented on pull request "Migrate CI to hosted Cirrus Runners":
(https://github.com/bitcoin/bitcoin/pull/32989#discussion_r2232053247)
6d252266e40 and 3e757e511a3 now hash `FILE_ENV` too for the caches, using:

```bash
DEPENDS_HASH=$(git ls-tree HEAD depends "ci/test/$FILE_ENV" | sha256sum | cut -d' ' -f1)
```

💬 willcl-ark commented on pull request "Migrate CI to hosted Cirrus Runners":
(https://github.com/bitcoin/bitcoin/pull/32989#issuecomment-3120460571)
Thanks for the review on this so far.

Whilst we had tested the docker registry caching on PRs successfully, because I was opening them myself (and was owner of the parent repo) repo-level variables were available to me which were *not* available to 3rd party pull requests.

The short of this is that this meant the docker registry cache setup could _not_ pull from the registry on pull requests and we didn't think it was therefore suitable for our purposes.

We have switched to the `gha` ca
...

👋 willcl-ark's pull request is ready for review: "Migrate CI to hosted Cirrus Runners"
(https://github.com/bitcoin/bitcoin/pull/32989)

💬 w0xlt commented on pull request "wallet: Remove wallet version and several legacy related functions":
(https://github.com/bitcoin/bitcoin/pull/32977#discussion_r2232064980)
Done. Thanks.

💬 w0xlt commented on pull request "wallet: Remove wallet version and several legacy related functions":
(https://github.com/bitcoin/bitcoin/pull/32977#discussion_r2232065117)
Done. Thanks.

🚀 achow101 merged a pull request: "test: Move `script_assets_tests` into its own suite"
(https://github.com/bitcoin/bitcoin/pull/31576)

💬 w0xlt commented on pull request "wallet: Remove wallet version and several legacy related functions":
(https://github.com/bitcoin/bitcoin/pull/32977#discussion_r2232069312)
Done. Thanks.

💬 w0xlt commented on pull request "wallet: Remove wallet version and several legacy related functions":
(https://github.com/bitcoin/bitcoin/pull/32977#discussion_r2232069363)
Done. Thanks.

💬 w0xlt commented on pull request "wallet: Remove wallet version and several legacy related functions":
(https://github.com/bitcoin/bitcoin/pull/32977#discussion_r2232069783)
I will look into this.

💬 w0xlt commented on pull request "wallet: Remove wallet version and several legacy related functions":
(https://github.com/bitcoin/bitcoin/pull/32977#issuecomment-3120479453)
Rebased. Ready for reviews.

🤔 pablomartin4btc reviewed a pull request: "rpc, wallet: replace remaining hardcoded output types with `FormatAllOutputTypes`"
(https://github.com/bitcoin/bitcoin/pull/33065#pullrequestreview-3056872157)
utACK e3ba0757a9410336e904a1b108d86165f347fc52

What about these 2 (`-addresstype` and `-changetype`) in `src/wallet/init.cpp`?

https://github.com/bitcoin/bitcoin/blob/2e97541396b998f6dfb47f9acef51e3ca69e97b2/src/wallet/init.cpp#L44-L51

💬 achow101 commented on pull request "rpc, doc: clarify watch-only wallets balances in RPCHelp":
(https://github.com/bitcoin/bitcoin/pull/32761#issuecomment-3120529045)
I don't really think this change is necessary, especially with the removal of watch-only within a wallet.