💬 yancyribbens commented on pull request "test: add assertions to SRD max weight test":
(https://github.com/bitcoin/bitcoin/pull/33058#issuecomment-3114861829)
> [18:13:33.790] ./wallet/test/coinselector_tests.cpp(1247): �[1;31;49merror: in "coinselector_tests/srd_tests": check EquivalentResult(expected_result, *res) has failed�[0;39;49m

That is the unit test, right? It passes for me locally. I just re-based and pushed again and now that job is passing. I wonder now if there's a possible random seed that could cause SRD to fail.

💬 maflcko commented on pull request "NOMERGE DEBUG WIP ignore":
(https://github.com/bitcoin/bitcoin/pull/33028#discussion_r2229541626)
Same bt as in https://github.com/bitcoin/bitcoin/issues/32524#issuecomment-2888967608:

```
Thread 33 (Thread 0xf5933b40 (LWP 2485619) "b-httpworker.2"):
#0 0xf7f8e589 in __kernel_vsyscall ()
#1 0xf7aaeac7 in read () from /lib32/libc.so.6
#2 0x57dae8b6 in subprocess::util::read_atmost_n (fp=0x595e06d0, buf=0xf59305e4 "", read_upto=1024) at ./util/subprocess.h:437
#3 0x57dc2e19 in subprocess::Popen::execute_process (this=0xf5930cd8) at ./util/subprocess.h:1247
#4 0x57daf434 in subpro
...

💬 jonatack commented on pull request "cli: return local services in -netinfo":
(https://github.com/bitcoin/bitcoin/pull/31886#discussion_r2229541731)
I kept the order the same as in getpeerinfo RPC, the GUI, and the -netinfo peers list.

💬 achow101 commented on pull request "wallet, sqlite: Encapsulate SQLite statements in a RAII class":
(https://github.com/bitcoin/bitcoin/pull/33033#discussion_r2229546952)
I've dropped this commit from this PR and moved it to #33034. Also dropped `value_type` and made the constructor just take `span<const std::byte>` and that seems to work.

💬 achow101 commented on pull request "wallet, sqlite: Encapsulate SQLite statements in a RAII class":
(https://github.com/bitcoin/bitcoin/pull/33033#discussion_r2229549000)
Done

🤔 w0xlt reviewed a pull request: "test: reduce runtime of p2p_opportunistic_1p1c.py"
(https://github.com/bitcoin/bitcoin/pull/33048#pullrequestreview-3053254178)
ACK https://github.com/bitcoin/bitcoin/pull/33048/commits/eb65f57f319dc4e2ea8c83cf7e283c36f1c0d53b

On my machine, master: 43 s
This PR: 27 s

Even reducing the number of transactions and peer connections used in the DoS portions of the test, it still fills the orphan pool past its limit, ensuring that evictions occur.
The use of mock time also makes the test more deterministic.

💬 achow101 commented on pull request "wallet: `addhdkey` RPC to add just keys to wallets via new `unused(KEY)` descriptor":
(https://github.com/bitcoin/bitcoin/pull/29136#discussion_r2229559648)
We can have multiple keys if the key is multipath.

💬 achow101 commented on pull request "wallet: `addhdkey` RPC to add just keys to wallets via new `unused(KEY)` descriptor":
(https://github.com/bitcoin/bitcoin/pull/29136#discussion_r2229563232)
External signer always has private keys disabled.

💬 achow101 commented on pull request "wallet: `addhdkey` RPC to add just keys to wallets via new `unused(KEY)` descriptor":
(https://github.com/bitcoin/bitcoin/pull/29136#discussion_r2229564365)
This call to `Parse` has `require_checksum` set to `false` so the checksum is not required.

💬 achow101 commented on pull request "wallet: `addhdkey` RPC to add just keys to wallets via new `unused(KEY)` descriptor":
(https://github.com/bitcoin/bitcoin/pull/29136#discussion_r2229572215)
Done

💬 achow101 commented on pull request "wallet: `addhdkey` RPC to add just keys to wallets via new `unused(KEY)` descriptor":
(https://github.com/bitcoin/bitcoin/pull/29136#discussion_r2229572501)
Done

💬 achow101 commented on pull request "wallet: `addhdkey` RPC to add just keys to wallets via new `unused(KEY)` descriptor":
(https://github.com/bitcoin/bitcoin/pull/29136#discussion_r2229572728)
Done

💬 achow101 commented on pull request "wallet: `addhdkey` RPC to add just keys to wallets via new `unused(KEY)` descriptor":
(https://github.com/bitcoin/bitcoin/pull/29136#discussion_r2229572849)
Done

💬 achow101 commented on pull request "wallet: `addhdkey` RPC to add just keys to wallets via new `unused(KEY)` descriptor":
(https://github.com/bitcoin/bitcoin/pull/29136#discussion_r2229573142)
Done

💬 achow101 commented on pull request "wallet: `addhdkey` RPC to add just keys to wallets via new `unused(KEY)` descriptor":
(https://github.com/bitcoin/bitcoin/pull/29136#discussion_r2229573405)
Removed

💬 achow101 commented on pull request "wallet: `addhdkey` RPC to add just keys to wallets via new `unused(KEY)` descriptor":
(https://github.com/bitcoin/bitcoin/pull/29136#discussion_r2229573665)
Fixed

💬 maflcko commented on pull request "test: Add and use ElapseTime helper":
(https://github.com/bitcoin/bitcoin/pull/32430#issuecomment-3114952384)
(rebased)

💬 maflcko commented on pull request "util: Abort on failing CHECK_NONFATAL in debug builds":
(https://github.com/bitcoin/bitcoin/pull/32588#discussion_r2229576705)
> make it 101% accurate

thx, done

💬 achow101 commented on pull request "wallet: Construct ScriptPubKeyMans with all data rather than loaded progressively":
(https://github.com/bitcoin/bitcoin/pull/28333#discussion_r2229612292)
The blank flag needs to be unset before `EncryptWallet` so that `EncryptWallet` can generate the new keys after encrypting. Otherwise, the newly created wallet will be encrypted but blank, which is not what we want in this scenario.

💬 w0xlt commented on pull request "Split `CWallet::Create()` into `CreateNew` and `LoadExisting`":
(https://github.com/bitcoin/bitcoin/pull/32636#discussion_r2229614994)
```suggestion
if (nLoadWalletRet != DBErrors::LOAD_OK) {
const auto wallet_file = m_database->Filename();

switch (nLoadWalletRet) {
case DBErrors::CORRUPT:
error = strprintf(_("Error loading %s: Wallet corrupted"), wallet_file);
break;
case DBErrors::NONCRITICAL_ERROR:
warnings.push_back(strprintf(_("Error reading %s! All keys read correctly, but transaction data"

...