💬 fanquake commented on pull request "[29.x] final changes for v29.1rc1":
(https://github.com/bitcoin/bitcoin/pull/33056#issuecomment-3114422676)
Looks good. Just need to `s/29.x/29.1rc1/` in `release-notes.md`. (i.e https://github.com/bitcoin/bitcoin/pull/32480/commits/fdc629fa736d79f5b26a73fafc58f52c16d18f03).

💬 yancyribbens commented on pull request "test: add assertions to SRD max weight test":
(https://github.com/bitcoin/bitcoin/pull/33058#issuecomment-3114425944)
All unit tests pass for me locally, so I'm not sure what CI is trying to tell me.

💬 b-l-u-e commented on issue "`combinepsbt` RPC does not work with P2TR inputs":
(https://github.com/bitcoin/bitcoin/issues/27219#issuecomment-3114487702)
I've tested this issue with the current Bitcoin Core version 29 and can confirm that **the `combinepsbt` RPC now works correctly with P2TR inputs**.

## Test Results:

I created a test scenario with:
1. A Taproot address (`bcrt1ph7wt8kmwvp87hp0re43vvme8c3y8tyg49ghstkaufxs8qjf6j4hskqejs7`)
2. A PSBT spending a Taproot UTXO
3. Signed the PSBT using `walletprocesspsbt`
4. Combined the signed PSBT using `combinepsbt`
5. Finalized the combined PSBT using `finalizepsbt`

## Key Findings:

✅ **PSBT sig
...

📝 benthecarman opened a pull request: "Allow disabling default consistency checks on regtest"
(https://github.com/bitcoin/bitcoin/pull/33059)
This stems from a twitter conversation with @instagibbs and @stickies-v (https://x.com/Stphnvlstk/status/1948352236456714326). Currently trying to sync a 2.5M block regtest chain and its only done 1.3M headers in a few days. This adds the option to disable `fDefaultConsistencyChecks` so it can sync at a normal speed.

I am running this currently running this and it is infinitely faster and no longer using 100% CPU.

💬 mzumsande commented on pull request "Allow disabling default consistency checks on regtest":
(https://github.com/bitcoin/bitcoin/pull/33059#issuecomment-3114567705)
I think you can just do `-checkblockindex=0`

💬 naiyoma commented on pull request "net: make m_mempool optional in PeerManager":
(https://github.com/bitcoin/bitcoin/pull/33029#discussion_r2229343188)
this wasn't intentional — I might have missed some changes since i rebased from the original branch.

💬 naiyoma commented on pull request "net: make m_mempool optional in PeerManager":
(https://github.com/bitcoin/bitcoin/pull/33029#discussion_r2229351697)
I have added it back

✅ benthecarman closed a pull request: "Allow disabling default consistency checks on regtest"
(https://github.com/bitcoin/bitcoin/pull/33059)

💬 benthecarman commented on pull request "Allow disabling default consistency checks on regtest":
(https://github.com/bitcoin/bitcoin/pull/33059#issuecomment-3114594417)
> I think you can just do `-checkblockindex=0`

ah missed that, thank you!

💬 Sjors commented on pull request "[POC] wallet: Enable non-electronic (paper-based) wallet backup with codex32":
(https://github.com/bitcoin/bitcoin/pull/33043#issuecomment-3114614849)
How does this relate to https://github.com/bitcoin/bitcoin/pull/27351 / #32652? It's probably easier to support import before export.

💬 achow101 commented on pull request "wallet, test: Replace MockableDatabase with in-memory SQLiteDatabase":
(https://github.com/bitcoin/bitcoin/pull/33032#discussion_r2229390788)
Made a `MockableSQLiteBatch` and `MockableSQLiteDatabase` which does this.

💬 achow101 commented on pull request "wallet, test: Replace MockableDatabase with in-memory SQLiteDatabase":
(https://github.com/bitcoin/bitcoin/pull/33032#discussion_r2229391286)
Added `MockableSQLiteDatabase`

💬 achow101 commented on pull request "wallet, test: Replace MockableDatabase with in-memory SQLiteDatabase":
(https://github.com/bitcoin/bitcoin/pull/33032#discussion_r2229391898)
Removed now that there's `MockableSQLiteDatabase`

💬 achow101 commented on pull request "wallet, test: Replace MockableDatabase with in-memory SQLiteDatabase":
(https://github.com/bitcoin/bitcoin/pull/33032#discussion_r2229392087)
done

💬 achow101 commented on pull request "wallet, test: Replace MockableDatabase with in-memory SQLiteDatabase":
(https://github.com/bitcoin/bitcoin/pull/33032#discussion_r2229393691)
I prefer to leave this as-is as it is a more specific check. It checks for the db types that are allowed to be legacy wallets, rather than allowing legacy wallets for all non-sqlite databases.

💬 achow101 commented on pull request "wallet, test: Replace MockableDatabase with in-memory SQLiteDatabase":
(https://github.com/bitcoin/bitcoin/pull/33032#discussion_r2229393890)
Removed now that there's `MockableSQLiteDatabase`

🤔 ryanofsky reviewed a pull request: "ipc: add bitcoin-mine test program"
(https://github.com/bitcoin/bitcoin/pull/30437#pullrequestreview-3052852068)
Thanks for the reviews!

Updated 2910315d1d8a3879f4e0bd50bf90870b642bfede -> 9d8851c0103f0dff8d659950e48d70ec86c86b30 ([`pr/mine.27`](https://github.com/ryanofsky/bitcoin/commits/pr/mine.27) -> [`pr/mine.28`](https://github.com/ryanofsky/bitcoin/commits/pr/mine.28), [compare](https://github.com/ryanofsky/bitcoin/compare/pr/mine.27..pr/mine.28)) just updating two code comments.
Updated 9d8851c0103f0dff8d659950e48d70ec86c86b30 -> 3d099384a60c8f64c8d67a9f1e7b8649a9c54313 ([`pr/mine.28`](https://
...

💬 ryanofsky commented on pull request "ipc: add bitcoin-mine test program":
(https://github.com/bitcoin/bitcoin/pull/30437#discussion_r2229307480)
re: https://github.com/bitcoin/bitcoin/pull/30437#discussion_r2213158587

> nit:

Thanks, updated!

💬 ryanofsky commented on pull request "ipc: add bitcoin-mine test program":
(https://github.com/bitcoin/bitcoin/pull/30437#discussion_r2229351651)
re: https://github.com/bitcoin/bitcoin/pull/30437#discussion_r2213947741

> This should also break when the chain tip changes or generate a new template. Right now, it's possible to pass a large `max_tries` and get stuck.

I agree this is not ideal, though I don't think it's necessarily a problem. Probably more ideally this code would use two threads and increment the nonce in one thread and call waitNext in another thread, updating the hash if the tip changes. Calling getTip() every time th
...

💬 maflcko commented on pull request "rpc: use CScheduler for relocking wallet and remove RPCTimer":
(https://github.com/bitcoin/bitcoin/pull/32862#issuecomment-3114706601)
Just wanted to leave a note that this uncovers a false positive libc++ tsan warning, if anyone runs into this.

<details><summary>more details</summary>

https://cirrus-ci.com/task/5230471308640256?logs=check#L1679:

```
WARNING: ThreadSanitizer: data race (pid=22900)
Write of size 8 at 0x720c00021ab0 by thread T1 (mutexes: write M0):
#0 operator delete(void*, unsigned long) <null> (bitcoind+0x17e6cc) (BuildId: cfbd7d2fe965bb79ec7e44f4d6b230691518e5cd)
#1 void std::__1::__lib
...