💬 maflcko commented on pull request "refactor: inline constant return values from `dbwrapper` write methods":
(https://github.com/bitcoin/bitcoin/pull/33042#issuecomment-3112999265)
Looks like this was introduced in 421218d3040279c84616891e8d14b05576b07c57, I guess because it was less verbose. How verbose would it be to pass it up and check it everywhere? Also, `git grep '\<catch\>' ./src/index/base.*` doesn't return anything, so I wonder how index code deals with those exceptions?

💬 ajtowns commented on pull request "net, validation: don't punish peers for consensus-invalid txs":
(https://github.com/bitcoin/bitcoin/pull/33050#issuecomment-3113000946)
See also #33012.

DoS banning was introduced in #517. DoS banning for some txs was removed in #896, #2540 and #3843, and then extended back to cover various post-p2sh soft forks in #26291. DoS banning was changed to be less banny in #14929, changed to discouragement in #19219 and changed from score-based to instant in #29575.

Also related is the `RECENT_CONSENSUS_CHANGE` validation state, which was removed in #31269, but which was intended to prevent banning/discouragement of peers that wou
...

🚀 fanquake merged a pull request: "wallet: Set migrated wallet name only on success"
(https://github.com/bitcoin/bitcoin/pull/32984)

🚀 fanquake merged a pull request: "doc: update headers and remove manual TOCs"
(https://github.com/bitcoin/bitcoin/pull/33040)

🚀 fanquake merged a pull request: "[29.x] test: Do not pass tests on unhandled exceptions"
(https://github.com/bitcoin/bitcoin/pull/33046)

💬 bigshiny90 commented on pull request "test: Add functional tests for blockreconstructionextratxn parameter":
(https://github.com/bitcoin/bitcoin/pull/33023#issuecomment-3113073248)
updated to fix CI Lint fail (whitespace removal)

🚀 fanquake merged a pull request: "test: check proper OP_2ROT behavior"
(https://github.com/bitcoin/bitcoin/pull/33047)

💬 bigshiny90 commented on pull request "test: Add functional tests for blockreconstructionextratxn parameter":
(https://github.com/bitcoin/bitcoin/pull/33023#issuecomment-3113104256)
updated to fix CI Lint errors

💬 laanwj commented on pull request "Enable `-natpmp` by default":
(https://github.com/bitcoin/bitcoin/pull/33004#issuecomment-3113109911)
Post-merge ACK b2d07f872c58af9cfdf9f9a4af0645376f9b98cb

🤔 fanquake reviewed a pull request: "ci: Use optimized Debug build type in test-each-commit"
(https://github.com/bitcoin/bitcoin/pull/32888#pullrequestreview-3051259900)
Seems fine to add this and be using `mold` in one job.

> This ci run took 30min7sec (https://github.com/bitcoin/bitcoin/actions/runs/16112781421/job/45459901801?pr=32888)

This doesn't actually show the new changes here right?

💬 fanquake commented on pull request "ci: Use optimized Debug build type in test-each-commit":
(https://github.com/bitcoin/bitcoin/pull/32888#discussion_r2228252688)
The CMake here is one version too old, otherwise we could also have used `CMAKE_LINKER_TYPE=MOLD`

🚀 fanquake merged a pull request: "ci: Use optimized Debug build type in test-each-commit"
(https://github.com/bitcoin/bitcoin/pull/32888)

👋 fanquake's pull request is ready for review: "test: Add functional tests for blockreconstructionextratxn parameter"
(https://github.com/bitcoin/bitcoin/pull/33023)

💬 stickies-v commented on pull request "rpc: refactor: use string_view in Arg/MaybeArg":
(https://github.com/bitcoin/bitcoin/pull/32983#issuecomment-3113155030)
Force-pushed from [319abd6](https://github.com/bitcoin/bitcoin/commit/319abd609b3d2194e7a05454b6af55b6f16adbf1) to [b8772ef](https://github.com/bitcoin/bitcoin/commit/b8772efebace3f4f0cfed6479648bce7a521ff27) to remove a `std::string` copy in `rpc/mining.cpp`, addressing (part of) @pablomartin4btc's feedback.

---

> It seems like we’re going from `string` → `string_view` → `string`

`string_view` is a non-owning read-only reference, so by definition it has to point to some other string-li
...

📝 Sjors opened a pull request: "Don't fix Python patch version"
(https://github.com/bitcoin/bitcoin/pull/33051)
Fixing the patch version can cause problems when interacting with other programs such as HWI.

E.g. if the user installed Python 3.10.14 and 3.10.16 through PyEnv, if HWI was locked to 3.10 it would default to 3.10.16. HWI then can't find any of its dependencies.

See also https://github.com/bitcoin-core/HWI/pull/695

💬 maflcko commented on pull request "Don't fix Python patch version":
(https://github.com/bitcoin/bitcoin/pull/33051#issuecomment-3113282579)
the lint CI failed

💬 josibake commented on pull request "Silent Payments: sending":
(https://github.com/bitcoin/bitcoin/pull/28201#discussion_r2228447040)
This is fine, actually. What we are doing here is making sure to _never_ include a taproot with script path spend or a witness unknown spend. We can include Pay2Pubkey inputs, so long as there is at least one silent payments eligible input.

In the `CreateSilentPaymentsOutputs` function, we check for at least one eligible input here: https://github.com/bitcoin/bitcoin/blob/4225ebc65595b5ef0f661b4f41e3e21266b93575/src/wallet/spend.cpp#L1116, by calling the `IsInputForSharedSecretDerivation` fun
...

💬 b-l-u-e commented on pull request "rpc: Fix internal bug in descriptorprocesspsbt when encountering invalid signatures":
(https://github.com/bitcoin/bitcoin/pull/33014#issuecomment-3113382620)
@achow101...You were right, my initial approach was incorrect. I now understand that CHECK_NONFATAL is correctly protecting the invariant that a PSBT marked as complete must be finalizable.

The actual bug, as you pointed out, was that the completeness check was too lenient, only checking for the presence of a signature rather than its cryptographic validity.

After ensuring that the logic first verifies the existing signatures before declaring the PSBT complete (the approach you suggested w
...

🤔 darosior reviewed a pull request: "net, validation: don't punish peers for consensus-invalid txs"
(https://github.com/bitcoin/bitcoin/pull/33050#pullrequestreview-3051560671)
Concept ACK.

💬 darosior commented on pull request "net, validation: don't punish peers for consensus-invalid txs":
(https://github.com/bitcoin/bitcoin/pull/33050#discussion_r2228448364)
You might as well drop `expect_disconnect` in the templates then, instead of setting it to False both there and here? Also the reconnect logic just below here is now dead code.