📝 MarcoFalke opened a pull request: " doc: Add doc/release-notes/release-notes-25.0.md "
(https://github.com/bitcoin/bitcoin/pull/27751)
Also, fix a typo in another doc.

💬 fanquake commented on pull request "doc: Add doc/release-notes/release-notes-25.0.md":
(https://github.com/bitcoin/bitcoin/pull/27751#discussion_r1205363139)
Not the release notes?

💬 MarcoFalke commented on issue "Spurious (?) valgrind failure for p2p_compactblocks.py":
(https://github.com/bitcoin/bitcoin/issues/27741#issuecomment-1562731029)
Steps to reproduce on a fresh install of Ubuntu Mantic (currently the same packages as your 23.04):

```
export DEBIAN_FRONTEND=noninteractive && apt update && apt install curl wget htop git vim ccache -y && git clone https://github.com/bitcoin/bitcoin.git --depth=1 ./bitcoin-core && cd bitcoin-core && apt install build-essential libtool autotools-dev automake pkg-config bsdmainutils python3-zmq libevent-dev libboost-dev valgrind -y && ./autogen.sh && ./configure && make -j $(npro
...

💬 MarcoFalke commented on issue "Spurious (?) valgrind failure for p2p_compactblocks.py":
(https://github.com/bitcoin/bitcoin/issues/27741#issuecomment-1562731856)
Maybe try clang over gcc or a newer version of valgrind for now?

👍 TheCharlatan approved a pull request: "index: prevent race by calling 'CustomInit' prior setting 'synced' flag"
(https://github.com/bitcoin/bitcoin/pull/27720#pullrequestreview-1443690741)
Nice, ACK 3126454dcfa1dd29bb66500d5f2b5261684d6c58

👍 stickies-v approved a pull request: "doc: Add doc/release-notes/release-notes-25.0.md"
(https://github.com/bitcoin/bitcoin/pull/27751#pullrequestreview-1443771760)
ACK fab19a8ae30c7f2b9347f70f16799e14dc1970b1, confirmed that the release-notes are identical to what was reviewed in https://github.com/bitcoin/bitcoin/pull/27686/

Suggesting some minor improvements to the release notes, but perhaps this is not a suitable place?

💬 stickies-v commented on pull request "doc: Add doc/release-notes/release-notes-25.0.md":
(https://github.com/bitcoin/bitcoin/pull/27751#discussion_r1205446835)
nit
```suggestion
- Transactions of non-witness size 65 vbytes and above are now allowed by mempool
```

💬 stickies-v commented on pull request "doc: Add doc/release-notes/release-notes-25.0.md":
(https://github.com/bitcoin/bitcoin/pull/27751#discussion_r1205440859)
broken link:
```suggestion
parameter](https://github.com/bitcoin/bitcoin/blob/master/doc/JSON-RPC-interface.md#parameter-passing) called `args` that can
```

💬 stickies-v commented on pull request "doc: Add doc/release-notes/release-notes-25.0.md":
(https://github.com/bitcoin/bitcoin/pull/27751#discussion_r1205451246)
```suggestion
and `-listen` (users may still set them to override). (#26899)
```

💬 stickies-v commented on pull request "doc: Add doc/release-notes/release-notes-25.0.md":
(https://github.com/bitcoin/bitcoin/pull/27751#discussion_r1205449892)
```suggestion
and scripts that contain invalid opcodes. (#25943)
```

💬 stickies-v commented on pull request "doc: Add doc/release-notes/release-notes-25.0.md":
(https://github.com/bitcoin/bitcoin/pull/27751#discussion_r1205451526)
```suggestion
impacting performance. (#26471)

```

💬 MarcoFalke commented on pull request "doc: Add doc/release-notes/release-notes-25.0.md":
(https://github.com/bitcoin/bitcoin/pull/27751#discussion_r1205484400)
No, I don't think it is vbytes, it is non-witness bytes, which is different.

💬 fanquake commented on pull request "doc: Add doc/release-notes/release-notes-25.0.md":
(https://github.com/bitcoin/bitcoin/pull/27751#issuecomment-1562867151)
> Suggesting some minor improvements to the release notes, but perhaps this is not a suitable place?

They should have been suggested before the notes were finalised in #27686. This is just copying them into master.

💬 MarcoFalke commented on pull request "doc: Add doc/release-notes/release-notes-25.0.md":
(https://github.com/bitcoin/bitcoin/pull/27751#discussion_r1205489623)
Or just `/doc/JSON...` or `./../JSON...`?

💬 stickies-v commented on pull request "doc: Add doc/release-notes/release-notes-25.0.md":
(https://github.com/bitcoin/bitcoin/pull/27751#discussion_r1205490836)
Ah, good point. `bytes`, then, as per the PR title? The lack of unit is upsetting high school teachers worldwide.

💬 MarcoFalke commented on issue "Spurious (?) valgrind failure for p2p_compactblocks.py":
(https://github.com/bitcoin/bitcoin/issues/27741#issuecomment-1562872873)
Oh, and if you use clang and valgrind 3.19, you'll also have to set `gdwarf`:

`./configure CC=clang CXX=clang++ CFLAGS='-gdwarf-4' CXXFLAGS='-gdwarf-4'`

💬 stickies-v commented on pull request "doc: Add doc/release-notes/release-notes-25.0.md":
(https://github.com/bitcoin/bitcoin/pull/27751#discussion_r1205496351)
I considered that, but since I think these notes are copy-pasted elsewhere (e.g. bitcoincore.org), I think we generally prefer to stick to absolute links here? At least that's how it is in `release-notes-24.0.1.md` too.

📝 fanquake opened a pull request: "[25.x] Parallel compact block downloads"
(https://github.com/bitcoin/bitcoin/pull/27752)
Backports:
* https://github.com/bitcoin/bitcoin/pull/27626
* https://github.com/bitcoin/bitcoin/pull/27743

Draft for now. As we may need to pull in more changes here.

📝 FATHI899 opened a pull request: "Create helpcoin"
(https://github.com/bitcoin/bitcoin/pull/27753)
<!--
*** Please remove the following help text before submitting: ***

Pull requests without a rationale and clear improvement may be closed
immediately.

GUI-related pull requests should be opened against
https://github.com/bitcoin-core/gui
first. See CONTRIBUTING.md
-->

<!--
Please provide clear motivation for your patch and explain how it improves
Bitcoin Core user experience or Bitcoin Core developer experience
significantly:

* Any test improvements or new tests that improv
...

✅ fanquake closed a pull request: "Create helpcoin"
(https://github.com/bitcoin/bitcoin/pull/27753)