💬 pinheadmz commented on issue "b-msghand invoked oom-killer in Debug build: Master (v28.99) crashing during IBD":
(https://github.com/bitcoin/bitcoin/issues/31561#issuecomment-3096984988)
Closing this now, `Bitcoin Core daemon version v29.99.0-c43cc48aaaaa (debug build)` synced succesfully on a debian VM 8GB memory and no swap

💬 sr-gi commented on pull request "Fix tiebreak when loading blocks from disk (and add tests for comparing chain ties)":
(https://github.com/bitcoin/bitcoin/pull/29640#discussion_r2219412158)
Rebased and fixed

💬 darosior commented on pull request "script: return verification flag responsible for error upon validation failure":
(https://github.com/bitcoin/bitcoin/pull/33012#issuecomment-3097046877)
Rebased to fix a silent merge conflict that was making the "test each commit" CI job fail.

💬 sr-gi commented on pull request "Fix tiebreak when loading blocks from disk (and add tests for comparing chain ties)":
(https://github.com/bitcoin/bitcoin/pull/29640#issuecomment-3097049530)
Rebased to switch from the old (removed) `CBlock::hash` property to the recently introduced `hash_int` and `hash_hex`

💬 glozow commented on pull request "mempool: Avoid needless vtx iteration during IBD":
(https://github.com/bitcoin/bitcoin/pull/32827#issuecomment-3097123255)
ACK 249889bee6b88eb9814eb969e6fb108f86a4bf98

💬 glozow commented on pull request "[29.x] Backport #32521":
(https://github.com/bitcoin/bitcoin/pull/33013#issuecomment-3097142325)
@darosior could you make the release notes updates as well please? Thanks

🚀 glozow merged a pull request: "mempool: Avoid needless vtx iteration during IBD"
(https://github.com/bitcoin/bitcoin/pull/32827)

💬 sipa commented on pull request "script: return verification flag responsible for error upon validation failure":
(https://github.com/bitcoin/bitcoin/pull/33012#discussion_r2219485859)
This has no effect. If `err_flag` is already zero, then `err_flah &= ...;` will not change that.

💬 darosior commented on pull request "script: return verification flag responsible for error upon validation failure":
(https://github.com/bitcoin/bitcoin/pull/33012#discussion_r2219502307)
Oops, thanks. Of course i meant `|=` here.

💬 darosior commented on pull request "script: return verification flag responsible for error upon validation failure":
(https://github.com/bitcoin/bitcoin/pull/33012#discussion_r2219503216)
There is a couple other occurrences where i must have made the same mistake.

👍 stickies-v approved a pull request: "p2p: rename GetAddresses -> GetAddressesUncached"
(https://github.com/bitcoin/bitcoin/pull/32994#pullrequestreview-3037417577)
ACK df65b527f00cbf9fd6675bf22bb1285bfce24f66

💬 stickies-v commented on pull request "p2p: rename GetAddresses -> GetAddressesUncached":
(https://github.com/bitcoin/bitcoin/pull/32994#discussion_r2218753790)
clang-format nit
```suggestion
const std::vector<CAddress> v6_addrs{GetAddressesUncached(/*max_addresses=*/0, /*max_pct=*/0, Network::NET_IPV6, /*filtered=*/false)};
```

💬 stickies-v commented on pull request "p2p: rename GetAddresses -> GetAddressesUncached":
(https://github.com/bitcoin/bitcoin/pull/32994#discussion_r2219505959)
nit: documentation could be made more consistent, as per e.g. the below diff

<details>
<summary>git diff on df65b527f0</summary>

```diff
diff --git a/src/net.h b/src/net.h
index 61b25bd47d..eb08d9de05 100644
--- a/src/net.h
+++ b/src/net.h
@@ -1169,9 +1169,10 @@ public:

// Addrman functions
/**
- * Return all or many randomly selected addresses, optionally by network.
- * This function does not use an address response cache and should only be
- * used in
...

💬 darosior commented on pull request "[29.x] Backport #32521":
(https://github.com/bitcoin/bitcoin/pull/33013#issuecomment-3097189377)
Sure, will do.

💬 stickies-v commented on pull request "p2p: rename GetAddresses -> GetAddressesUncached":
(https://github.com/bitcoin/bitcoin/pull/32994#discussion_r2219514574)
`GetAddressesForPeer` might also make sense. I don't really care about it too much, I think all the above options are all fine and the most important thing for me is that they're not the same, which is addressed, so would personally prefer to pick one thing and then move on.

👋 glozow's pull request is ready for review: "p2p: TxOrphanage revamp cleanups"
(https://github.com/bitcoin/bitcoin/pull/32941)

💬 glozow commented on pull request "p2p: TxOrphanage revamp cleanups":
(https://github.com/bitcoin/bitcoin/pull/32941#issuecomment-3097204926)
This is ready for review. Would also be great to get https://github.com/bitcoin-core/qa-assets/pull/231 in for the 2 new fuzzies

💬 marcofleon commented on pull request "p2p: TxOrphanage revamp cleanups":
(https://github.com/bitcoin/bitcoin/pull/32941#issuecomment-3097235779)
Looks like the `txorphanage_sim` inputs might be invalidated after this PR. Not sure if we should wait to add those inputs until after this gets in or if it's worth adding them before.

💬 mzumsande commented on pull request "p2p: Advance pindexLastCommonBlock early after connecting blocks":
(https://github.com/bitcoin/bitcoin/pull/32180#issuecomment-3097243452)
[b7ff6a6](https://github.com/bitcoin/bitcoin/commit/b7ff6a611a220e9380f6cd6428f1d3483c8d566f) to [3bdff9a](https://github.com/bitcoin/bitcoin/commit/3bdff9a154733f8f9f379448f5595a2e90474bc6): rebased due to conflict with #32868

📝 naiyoma opened a pull request: "net: make m_mempool optional in PeerManager "
(https://github.com/bitcoin/bitcoin/pull/33029)
This PR is a continuation of →https://github.com/bitcoin/bitcoin/pull/22850, to make m_mempool an optional pointer in PeerManager instead of a reference.

some benefits, as mentioned here:https://github.com/bitcoin/bitcoin/pull/26247#issue-1396302764 are:

1. m_mempool is already a pointer in other parts like:
In Chainstate:[ https://github.com/bitcoin/bitcoin/blob/master/src/validation.h#L532](https://github.com/bitcoin/bitcoin/blob/master/src/validation.h#L532)
In BlockAssembler:[ https
...