✅ maflcko closed a pull request: "test: add unit test for psbt_wallet error messages"
(https://github.com/bitcoin/bitcoin/pull/33025)

💬 maflcko commented on pull request "test: add unit test for psbt_wallet error messages":
(https://github.com/bitcoin/bitcoin/pull/33025#issuecomment-3095412719)
Closing for now. You can open a new pull request for the new approach, once there is one.

💬 maflcko commented on pull request "test: Do not pass tests on unhandled exceptions":
(https://github.com/bitcoin/bitcoin/pull/33001#issuecomment-3095471139)
@OrangeDoro Every LLM generated point in your comment is wrong and completely misses the point. This is trivial to see, if you took a look at the previous comments and commit messages.

⚠️ sybot99 opened an issue: "IP leak using bitcoin core"
(https://github.com/bitcoin/bitcoin/issues/33027)
### Is there an existing issue for this?

- [x] I have searched the existing issues

### Current behaviour

Is there any IP leak when I use bitcoin core ?
1. Sync wallet
2. Sending btc

### Expected behaviour

IP leak

### Steps to reproduce

check IP

### Relevant log output

_No response_

### How did you obtain Bitcoin Core

Compiled from source

### What version of Bitcoin Core are you using?

29

### Operating system and version

Win 11 x64

### Machine specifications

_No response_

✅ maflcko closed an issue: "A missing import to the src/chainparamsbase.h"
(https://github.com/bitcoin/bitcoin/issues/33019)

💬 maflcko commented on issue "A missing import to the src/chainparamsbase.h":
(https://github.com/bitcoin/bitcoin/issues/33019#issuecomment-3095495511)
Fixed in 138f8671569f7ebb8c84e9d80c44cddeda9e3845

💬 maflcko commented on issue "A missing import to the src/chainparamsbase.h":
(https://github.com/bitcoin/bitcoin/issues/33019#issuecomment-3095504166)
@totdking As this was fixed in all supported versions of bitcoin core, you are likely running an EOL version. It could make sense to consider updating it. See https://bitcoincore.org/en/lifecycle/

✅ maflcko closed an issue: "IP leak using bitcoin core"
(https://github.com/bitcoin/bitcoin/issues/33027)

💬 maflcko commented on issue "IP leak using bitcoin core":
(https://github.com/bitcoin/bitcoin/issues/33027#issuecomment-3095524743)
Not sure what your question is, but Bitcoin Core connects to other P2P nodes. If you to connect to them over tor, please refer to the existing docs, such as https://github.com/bitcoin/bitcoin/blob/master/doc/tor.md, or the config help.


Usually the issue tracker is used to track technical issues related to the Bitcoin Core code base.

General bitcoin questions and/or support requests are best directed to the [Bitcoin StackExchange](https://bitcoin.stackexchange.com) or the `#bitcoin` IRC channe
...

💬 Sjors commented on issue "intermittent timeout in wallet_signer.py : sendall timed out":
(https://github.com/bitcoin/bitcoin/issues/33015#issuecomment-3095573346)
Same underlying issue as https://github.com/bitcoin/bitcoin/issues/32855#issuecomment-3092571841? Both `send` and `sendall` use the external signer method to send the PSBT over to the device (mock).

The additional logging from #32928 may be helpful to narrow down where the stalling happens.

💬 maflcko commented on pull request "tests: speed up coins_tests by parallelizing":
(https://github.com/bitcoin/bitcoin/pull/32945#issuecomment-3095605427)
lgtm ACK 2a8fdddd4df4b630c0a580f4df6521cb3af01804

💬 maflcko commented on pull request "tests: speed up coins_tests by parallelizing":
(https://github.com/bitcoin/bitcoin/pull/32945#discussion_r2218430945)
```suggestion
'`foo_tests`, or if there are multiple test suites, `foo_tests_bar`.\n'
```

style nit: seems odd to use multiple format styles in the same line.

💬 maflcko commented on pull request "clang-format: align brace-after-struct and *-class formatting":
(https://github.com/bitcoin/bitcoin/pull/32813#discussion_r2218452297)
unrelated note: I understand the setting `IncludeBlocks` is set to `Preserve` (and it should probably stay this way by default, but it would be nice to update the other Include* settings (in another pull request) to properly sort the includes: (1) the main include, (2) everything else (Bitcoin Core includes) (3) third-party library includes (boost, Qt), (4) stdlib includes (those that do not end in `.h`). This way, one could toggle the `IncludeBlocks` to get the desired behavior.

✅ maflcko closed a pull request: "refactor: simplify GetAncestor"
(https://github.com/bitcoin/bitcoin/pull/31778)

💬 maflcko commented on pull request "refactor: simplify GetAncestor":
(https://github.com/bitcoin/bitcoin/pull/31778#issuecomment-3095681699)
Closing for now due to inactivity. Feel free to ask for this to be re-opened or you may open a fresh pull request, once you are working on this again.

💬 Sjors commented on issue "wallet: render BIP388 wallet policies":
(https://github.com/bitcoin/bitcoin/issues/32659#issuecomment-3095726908)
Meanwhile I started working on #33008 which has most of the functionality to send a BIP388 policy to an external signer, get a resulting hmac and store that.

But I haven't worked on converting our descriptors to BIP388 policies yet.

🤔 Sjors reviewed a pull request: "test: add test cases to wallet_signer.py"
(https://github.com/bitcoin/bitcoin/pull/33020#pullrequestreview-3037095566)
These tests have been disabled from the start in d4b0107d68a91ed4d1a5c78c8ca76251329d3f3c of #16546.

For the third commit 74fb47f071451145b550062e382416db9388433d: I suggest deleting the commented out code. It's not doing anything useful for the test, and I can't remember why I wrote it.

💬 Sjors commented on pull request "test: add test cases to wallet_signer.py":
(https://github.com/bitcoin/bitcoin/pull/33020#discussion_r2218550645)
38a6293fa89104f3d6f1907d04c2e4c488157307: this makes it more clear how `set_mock_result` is intended to be used:

```py
self.set_mock_result(self.nodes[1], '0 {"invalid json"}')
```

💬 Eunovo commented on pull request "validation: ensure assumevalid is always used during reindex":
(https://github.com/bitcoin/bitcoin/pull/31615#issuecomment-3095873057)
Rebased on master@ https://github.com/bitcoin/bitcoin/commit/5878f35446

👍 dergoegge approved a pull request: "fuzz: Make process_message(s) more deterministic"
(https://github.com/bitcoin/bitcoin/pull/32822#pullrequestreview-3037221638)
reACK fa1a14a13a15ecfb7587a94ee86b4ace7c819519