💬 stickies-v commented on pull request "rpc, test: Fix JSON parsing errors in unloadwallet and getdescriptoractivity RPCs":
(https://github.com/bitcoin/bitcoin/pull/32845#discussion_r2209990945)
nit: Unfortunately we have to keep the name "scanobjects" for backwards compatibility, but I think the description should be made more relevant to what this RPC is doing, in line with the `blockhashes` documentation, e.g.
```suggestion
RPCArg{"scanobjects", RPCArg::Type::ARR, RPCArg::Optional::NO, "The list of descriptors (scan objects) to examine for activity. Every scan object is either a string descriptor or an object:", {
```
(https://github.com/bitcoin/bitcoin/pull/32845#discussion_r2209990945)
nit: Unfortunately we have to keep the name "scanobjects" for backwards compatibility, but I think the description should be made more relevant to what this RPC is doing, in line with the `blockhashes` documentation, e.g.
```suggestion
RPCArg{"scanobjects", RPCArg::Type::ARR, RPCArg::Optional::NO, "The list of descriptors (scan objects) to examine for activity. Every scan object is either a string descriptor or an object:", {
```
💬 stickies-v commented on pull request "rpc, test: Fix JSON parsing errors in unloadwallet and getdescriptoractivity RPCs":
(https://github.com/bitcoin/bitcoin/pull/32845#discussion_r2209965857)
side note: the docstring for this RPC seems out of date, could be sensible to fix in this PR? e.g.
<details>
<summary>git diff on 01688e1753</summary>
```diff
diff --git a/src/wallet/rpc/wallet.cpp b/src/wallet/rpc/wallet.cpp
index 67b7aafc00..26033d2119 100644
--- a/src/wallet/rpc/wallet.cpp
+++ b/src/wallet/rpc/wallet.cpp
@@ -438,8 +438,8 @@ static RPCHelpMan createwallet()
static RPCHelpMan unloadwallet()
{
return RPCHelpMan{"unloadwallet",
- "Unloads the
...
(https://github.com/bitcoin/bitcoin/pull/32845#discussion_r2209965857)
side note: the docstring for this RPC seems out of date, could be sensible to fix in this PR? e.g.
<details>
<summary>git diff on 01688e1753</summary>
```diff
diff --git a/src/wallet/rpc/wallet.cpp b/src/wallet/rpc/wallet.cpp
index 67b7aafc00..26033d2119 100644
--- a/src/wallet/rpc/wallet.cpp
+++ b/src/wallet/rpc/wallet.cpp
@@ -438,8 +438,8 @@ static RPCHelpMan createwallet()
static RPCHelpMan unloadwallet()
{
return RPCHelpMan{"unloadwallet",
- "Unloads the
...
💬 stickies-v commented on pull request "rpc, test: Fix JSON parsing errors in unloadwallet and getdescriptoractivity RPCs":
(https://github.com/bitcoin/bitcoin/pull/32845#discussion_r2210134549)
I wrote some unit tests for this function, feel free to add to this PR if you think it's helpful: https://github.com/stickies-v/bitcoin/commit/60f9dc8af66bbd4eda81049a10262527f83356a1
(https://github.com/bitcoin/bitcoin/pull/32845#discussion_r2210134549)
I wrote some unit tests for this function, feel free to add to this PR if you think it's helpful: https://github.com/stickies-v/bitcoin/commit/60f9dc8af66bbd4eda81049a10262527f83356a1
💬 stickies-v commented on pull request "rpc, test: Fix JSON parsing errors in unloadwallet and getdescriptoractivity RPCs":
(https://github.com/bitcoin/bitcoin/pull/32845#discussion_r2210018576)
nit: I think the first paragraph of the 01688e17534d3c9011cce92cff9f7935691bb80c commit message can be improved to:
> Mark `blockhashes` and `scanobjects` arguments as required, so the user receives
> a clear help message when either is missing.
(https://github.com/bitcoin/bitcoin/pull/32845#discussion_r2210018576)
nit: I think the first paragraph of the 01688e17534d3c9011cce92cff9f7935691bb80c commit message can be improved to:
> Mark `blockhashes` and `scanobjects` arguments as required, so the user receives
> a clear help message when either is missing.
💬 willcl-ark commented on pull request "Migrate CI to hosted Cirrus Runners":
(https://github.com/bitcoin/bitcoin/pull/32989#discussion_r2210214872)
Does podman accept `docker buildx build` as a command? I will check in a min with it.
but this was why not originally…
(https://github.com/bitcoin/bitcoin/pull/32989#discussion_r2210214872)
Does podman accept `docker buildx build` as a command? I will check in a min with it.
but this was why not originally…
👍 willcl-ark approved a pull request: "depends: fix libevent `_WIN32_WINNT` usage"
(https://github.com/bitcoin/bitcoin/pull/32837#pullrequestreview-3024686388)
crACK f5647c6c5ae85e9469cfc5df6fcac23752e1695a
Checked that the backported patch matches (minus the `wepoll.c` changes which we don't have in our version of libevent).
guix build:
```
❯ find guix-build-$(git rev-parse --short=12 HEAD)/output/ -type f -print0 | env LC_ALL=C sort -z | xargs -r0 sha256sum
54f1ec86a1e595a5529f115a333c5f6cf575ff35f0b87ed501f36f83e28d9063 guix-build-f5647c6c5ae8/output/aarch64-linux-gnu/SHA256SUMS.part
e9db7e23661bac03b87e38dfc974d27b72ce8d684d9cff7e7105c
...
(https://github.com/bitcoin/bitcoin/pull/32837#pullrequestreview-3024686388)
crACK f5647c6c5ae85e9469cfc5df6fcac23752e1695a
Checked that the backported patch matches (minus the `wepoll.c` changes which we don't have in our version of libevent).
guix build:
```
❯ find guix-build-$(git rev-parse --short=12 HEAD)/output/ -type f -print0 | env LC_ALL=C sort -z | xargs -r0 sha256sum
54f1ec86a1e595a5529f115a333c5f6cf575ff35f0b87ed501f36f83e28d9063 guix-build-f5647c6c5ae8/output/aarch64-linux-gnu/SHA256SUMS.part
e9db7e23661bac03b87e38dfc974d27b72ce8d684d9cff7e7105c
...
💬 josibake commented on issue "ci: improve "test each commit" job to handle more complex scenarios":
(https://github.com/bitcoin/bitcoin/issues/32991#issuecomment-3078415629)
> For other subtree merges, it does seem to work
AFAICT, this only happens when files in the subtree have been changed, and files in the main repo with the same name have also been changed, i.e., `CMakePresets.json` from the failure I linked. This file is in the bitcoin core root and the secp256k1 root.
> Is your subtree merge commit correct
I hope so! I'm using the same command we us to update the subtree in the project. I'm not sure what you mean by "create the subtree merge commit from scr
...
(https://github.com/bitcoin/bitcoin/issues/32991#issuecomment-3078415629)
> For other subtree merges, it does seem to work
AFAICT, this only happens when files in the subtree have been changed, and files in the main repo with the same name have also been changed, i.e., `CMakePresets.json` from the failure I linked. This file is in the bitcoin core root and the secp256k1 root.
> Is your subtree merge commit correct
I hope so! I'm using the same command we us to update the subtree in the project. I'm not sure what you mean by "create the subtree merge commit from scr
...
💬 willcl-ark commented on pull request "Migrate CI to hosted Cirrus Runners":
(https://github.com/bitcoin/bitcoin/pull/32989#discussion_r2210290456)
OK it seems `docker buildx build` does work with podman, so I have changed buildx to be used unconditionally in this commit now. Thanks!
(https://github.com/bitcoin/bitcoin/pull/32989#discussion_r2210290456)
OK it seems `docker buildx build` does work with podman, so I have changed buildx to be used unconditionally in this commit now. Thanks!
💬 maflcko commented on pull request "Migrate CI to hosted Cirrus Runners":
(https://github.com/bitcoin/bitcoin/pull/32989#discussion_r2210302841)
Yeah, if buildx is missing on some platforms, it could also use auto-detection to use it when available and not, when not.
(https://github.com/bitcoin/bitcoin/pull/32989#discussion_r2210302841)
Yeah, if buildx is missing on some platforms, it could also use auto-detection to use it when available and not, when not.
✅ fanquake closed an issue: "depends: Windows libevent build broken against mingw-w64 13.x"
(https://github.com/bitcoin/bitcoin/issues/32707)
(https://github.com/bitcoin/bitcoin/issues/32707)
💬 stickies-v commented on pull request "Adds transaction propagation information to mempool transactions":
(https://github.com/bitcoin/bitcoin/pull/32986#issuecomment-3078438016)
> I'm unsure whether the added complexity is justified, given that it's unlikely to be used beyond that specific context.
Would adding tracepoint(s) be a suitable alternative? More overhead for the user, but probably much less in this repo?
(https://github.com/bitcoin/bitcoin/pull/32986#issuecomment-3078438016)
> I'm unsure whether the added complexity is justified, given that it's unlikely to be used beyond that specific context.
Would adding tracepoint(s) be a suitable alternative? More overhead for the user, but probably much less in this repo?
🚀 fanquake merged a pull request: "depends: fix libevent `_WIN32_WINNT` usage"
(https://github.com/bitcoin/bitcoin/pull/32837)
(https://github.com/bitcoin/bitcoin/pull/32837)
💬 lamachina commented on issue "Release Schedule for 30.0":
(https://github.com/bitcoin/bitcoin/issues/32275#issuecomment-3078441041)
blacknode.co is ready #️⃣🧡
(https://github.com/bitcoin/bitcoin/issues/32275#issuecomment-3078441041)
blacknode.co is ready #️⃣🧡
💬 fanquake commented on pull request "depends: fix libevent `_WIN32_WINNT` usage":
(https://github.com/bitcoin/bitcoin/pull/32837#issuecomment-3078450101)
Backported to 29.x in #32863.
(https://github.com/bitcoin/bitcoin/pull/32837#issuecomment-3078450101)
Backported to 29.x in #32863.
⚠️ tonypatrick8390 opened an issue: "WHAT IS THE GREATEST WAY TO CATCH A CHEATING PARTNER?"
(https://github.com/bitcoin/bitcoin/issues/32992)
### Please describe the feature you'd like to see added.
In any relationship, trust is fundamental, and discovering infidelity can be emotionally devastating. When faced with this challenging situation, finding reliable information is critical. I turned to FUNDS RECLAIMER COMPANY, a resource-oriented tool designed to help individuals gather pertinent data without invasive methods. This service offered me insights into the online activities that could shed light on the truth of my partner’s acti
...
(https://github.com/bitcoin/bitcoin/issues/32992)
### Please describe the feature you'd like to see added.
In any relationship, trust is fundamental, and discovering infidelity can be emotionally devastating. When faced with this challenging situation, finding reliable information is critical. I turned to FUNDS RECLAIMER COMPANY, a resource-oriented tool designed to help individuals gather pertinent data without invasive methods. This service offered me insights into the online activities that could shed light on the truth of my partner’s acti
...
💬 willcl-ark commented on pull request "Migrate CI to hosted Cirrus Runners":
(https://github.com/bitcoin/bitcoin/pull/32989#discussion_r2210385688)
Actually I feel a bit less convinced that dropping a `sudo ... ` command into the CI scripts is ideal for this actually. I see comments that 32 bits should now be "fixed": https://github.com/google/sanitizers/issues/1614#issuecomment-1885369007
Testing this now locally...
(https://github.com/bitcoin/bitcoin/pull/32989#discussion_r2210385688)
Actually I feel a bit less convinced that dropping a `sudo ... ` command into the CI scripts is ideal for this actually. I see comments that 32 bits should now be "fixed": https://github.com/google/sanitizers/issues/1614#issuecomment-1885369007
Testing this now locally...
💬 maflcko commented on issue "ci: improve "test each commit" job to handle more complex scenarios":
(https://github.com/bitcoin/bitcoin/issues/32991#issuecomment-3078554931)
I can't reproduce this locally, when copy-pasting the command (https://github.com/bitcoin/bitcoin/actions/runs/16315746903/job/46081155541?pr=28122#step:7:3), even when installing the git version from GHA (https://github.com/actions/runner-images/commit/723cd0240d0c380f28bfd66e4ec6556dc3b536fd#diff-cc12e5c5d005932feaacf280af949d83e2cb6020dff8203d9ead2e00c30e8b7fR77):
```
# git checkout a4c84b90c0f2be478e84c39785cbda2a8b2512db && git rebase --exec "git merge --no-commit origin/master && echo ./.
...
(https://github.com/bitcoin/bitcoin/issues/32991#issuecomment-3078554931)
I can't reproduce this locally, when copy-pasting the command (https://github.com/bitcoin/bitcoin/actions/runs/16315746903/job/46081155541?pr=28122#step:7:3), even when installing the git version from GHA (https://github.com/actions/runner-images/commit/723cd0240d0c380f28bfd66e4ec6556dc3b536fd#diff-cc12e5c5d005932feaacf280af949d83e2cb6020dff8203d9ead2e00c30e8b7fR77):
```
# git checkout a4c84b90c0f2be478e84c39785cbda2a8b2512db && git rebase --exec "git merge --no-commit origin/master && echo ./.
...
💬 maflcko commented on issue "ci: improve "test each commit" job to handle more complex scenarios":
(https://github.com/bitcoin/bitcoin/issues/32991#issuecomment-3078562830)
> I'm not sure what you mean by "create the subtree merge commit from scratch."
Sorry, I misread that you were rebasing the subtree merge commit, but you were rebasing *on* the subtree merge commit, which should be correct.
(https://github.com/bitcoin/bitcoin/issues/32991#issuecomment-3078562830)
> I'm not sure what you mean by "create the subtree merge commit from scratch."
Sorry, I misread that you were rebasing the subtree merge commit, but you were rebasing *on* the subtree merge commit, which should be correct.
📝 brunoerg opened a pull request: "fuzz: wallet: add target for tx scanning"
(https://github.com/bitcoin/bitcoin/pull/32993)
Tracking issue (#29901)
This PR adds a fuzz target for wallet tx scanning (`ScanForWalletTransactions`). Unfortunately, it's not a regression test for the issue #31474 since it would require a more complex scenario/async operations.
(https://github.com/bitcoin/bitcoin/pull/32993)
Tracking issue (#29901)
This PR adds a fuzz target for wallet tx scanning (`ScanForWalletTransactions`). Unfortunately, it's not a regression test for the issue #31474 since it would require a more complex scenario/async operations.
👍 stickies-v approved a pull request: "log: [refactor] Use info level for init logs"
(https://github.com/bitcoin/bitcoin/pull/32967#pullrequestreview-3024974858)
ACK fa65716a878dbc0daabf1b31e832db5b230c285c
Mostly refactor operations, with a couple of minor logging statement updates (e.g. removing function names, adding detail on which operation is started/exited, ...)
(https://github.com/bitcoin/bitcoin/pull/32967#pullrequestreview-3024974858)
ACK fa65716a878dbc0daabf1b31e832db5b230c285c
Mostly refactor operations, with a couple of minor logging statement updates (e.g. removing function names, adding detail on which operation is started/exited, ...)