📝 maflcko opened a pull request: "test: Trigger UB in wallet crosschain migration"
(https://github.com/bitcoin/bitcoin/pull/32988)
(https://github.com/bitcoin/bitcoin/pull/32988)
💬 maflcko commented on pull request "wallet: Set migrated wallet name only on success":
(https://github.com/bitcoin/bitcoin/pull/32984#issuecomment-3077217292)
> I was unable to write a working functional test for this behavior.
It should be pretty trivial, see https://github.com/bitcoin/bitcoin/pull/32988
(https://github.com/bitcoin/bitcoin/pull/32984#issuecomment-3077217292)
> I was unable to write a working functional test for this behavior.
It should be pretty trivial, see https://github.com/bitcoin/bitcoin/pull/32988
💬 stickies-v commented on pull request "rpc, test: Fix JSON parsing errors in unloadwallet and getdescriptoractivity RPCs":
(https://github.com/bitcoin/bitcoin/pull/32845#discussion_r2209481857)
Oh no I'm not talking about the helper function's parameter name, that's fine imo, I'm talking about the error message that's thrown and eventually returned to the user, referencing an RPC parameter that potentially doesn't exist. Again, no biggie, just a symptom that concerns aren't entirely separated.
(https://github.com/bitcoin/bitcoin/pull/32845#discussion_r2209481857)
Oh no I'm not talking about the helper function's parameter name, that's fine imo, I'm talking about the error message that's thrown and eventually returned to the user, referencing an RPC parameter that potentially doesn't exist. Again, no biggie, just a symptom that concerns aren't entirely separated.
💬 maflcko commented on pull request "wallet: Remove `upgradewallet` RPC":
(https://github.com/bitcoin/bitcoin/pull/32944#issuecomment-3077308944)
migrated wallets will take over the legacy bdb version, which I am not sure is meaningful or useful. The `upgradewallet` RPC can be used to bump it. I think it would be good to explain and document the expectations around this, and the interactions with this pull, going forward.
(https://github.com/bitcoin/bitcoin/pull/32944#issuecomment-3077308944)
migrated wallets will take over the legacy bdb version, which I am not sure is meaningful or useful. The `upgradewallet` RPC can be used to bump it. I think it would be good to explain and document the expectations around this, and the interactions with this pull, going forward.
💬 maflcko commented on issue "ARM Windows build and release":
(https://github.com/bitcoin/bitcoin/issues/31388#issuecomment-3077357630)
You are probably looking for https://bitcoincore.org/en/download, but I don't think this will ever ship msvc compiled binaries, because they are non-deterministic and proprietary (c) . If you really want them, you'll have to compile them yourself. In the meantime, emulation (running the x86 on arm) should work fine.
(https://github.com/bitcoin/bitcoin/issues/31388#issuecomment-3077357630)
You are probably looking for https://bitcoincore.org/en/download, but I don't think this will ever ship msvc compiled binaries, because they are non-deterministic and proprietary (c) . If you really want them, you'll have to compile them yourself. In the meantime, emulation (running the x86 on arm) should work fine.
💬 maflcko commented on pull request "[IBD] log start of script validation past `assumevalid` block":
(https://github.com/bitcoin/bitcoin/pull/32975#discussion_r2209567919)
Not sure what the point is of logging this, when it doesn't detect the case when the checks are enabled initially (due to the minchainwork being less than two weeks worth of headers on top of the av block) ? See also https://github.com/bitcoin/bitcoin/pull/31615
(https://github.com/bitcoin/bitcoin/pull/32975#discussion_r2209567919)
Not sure what the point is of logging this, when it doesn't detect the case when the checks are enabled initially (due to the minchainwork being less than two weeks worth of headers on top of the av block) ? See also https://github.com/bitcoin/bitcoin/pull/31615
✅ maflcko closed a pull request: "test: Trigger UB in wallet crosschain migration"
(https://github.com/bitcoin/bitcoin/pull/32988)
(https://github.com/bitcoin/bitcoin/pull/32988)
💬 josibake commented on pull request "Silent Payments: Receiving":
(https://github.com/bitcoin/bitcoin/pull/32966#discussion_r2209598289)
Worth mentioning, the only reason we wouldn't be able to do this is if this function (and `TopUp`) are called generically on SPKMans, e.g., in a loop. I don't think this is the case, but wanted to mention it.
(https://github.com/bitcoin/bitcoin/pull/32966#discussion_r2209598289)
Worth mentioning, the only reason we wouldn't be able to do this is if this function (and `TopUp`) are called generically on SPKMans, e.g., in a loop. I don't think this is the case, but wanted to mention it.
💬 saikiran57 commented on pull request "Added rescan option for import descriptors":
(https://github.com/bitcoin/bitcoin/pull/31668#discussion_r2209623040)
Hi @achow101 kindly give some update on this.
(https://github.com/bitcoin/bitcoin/pull/31668#discussion_r2209623040)
Hi @achow101 kindly give some update on this.
📝 willcl-ark opened a pull request: "Migrate CI to hosted Cirrus Runners"
(https://github.com/bitcoin/bitcoin/pull/32989)
This changeset migrates all current self-hosted CI jobs over to hosted [Cirrus Runners](https://cirrus-runners.app/).
These runners cost a flat rate of $150/month, and we qualify for an open source discount of 50%. Therefore they are $75/month/runner.
One "runner" should more accurately be thought of in terms of the number of vCPU you are purchasing: https://cirrus-runners.app/pricing/ or in terms of "concurrency", where 1 runners gets you 1.0 concurrency.
e.g. a Linux x86 Runner gets you
...
(https://github.com/bitcoin/bitcoin/pull/32989)
This changeset migrates all current self-hosted CI jobs over to hosted [Cirrus Runners](https://cirrus-runners.app/).
These runners cost a flat rate of $150/month, and we qualify for an open source discount of 50%. Therefore they are $75/month/runner.
One "runner" should more accurately be thought of in terms of the number of vCPU you are purchasing: https://cirrus-runners.app/pricing/ or in terms of "concurrency", where 1 runners gets you 1.0 concurrency.
e.g. a Linux x86 Runner gets you
...
🤔 BrandonOdiwuor reviewed a pull request: "rpc, test: Fix JSON parsing errors in unloadwallet and getdescriptoractivity RPCs"
(https://github.com/bitcoin/bitcoin/pull/32845#pullrequestreview-3023823917)
Tested ACK 01688e17534d3c9011cce92cff9f7935691bb80c
Was able to verify that this fixes the JSON parsing error on `unloadwallet` and `getdescriptoractivity` RPCs
Tested on macOS 15.5
Branch: Master
<img width="870" height="203" alt="Screenshot 2025-07-16 at 11 41 41" src="https://github.com/user-attachments/assets/88508a93-3dfb-4676-9040-d8789677da1a" />
Commit: 01688e17534d3c9011cce92cff9f7935691bb80c
<img width="1511" height="887" alt="Screenshot 2025-07-15 at 14 36 44" src="http
...
(https://github.com/bitcoin/bitcoin/pull/32845#pullrequestreview-3023823917)
Tested ACK 01688e17534d3c9011cce92cff9f7935691bb80c
Was able to verify that this fixes the JSON parsing error on `unloadwallet` and `getdescriptoractivity` RPCs
Tested on macOS 15.5
Branch: Master
<img width="870" height="203" alt="Screenshot 2025-07-16 at 11 41 41" src="https://github.com/user-attachments/assets/88508a93-3dfb-4676-9040-d8789677da1a" />
Commit: 01688e17534d3c9011cce92cff9f7935691bb80c
<img width="1511" height="887" alt="Screenshot 2025-07-15 at 14 36 44" src="http
...
📝 rkrux opened a pull request: "wallet: remove outdated `pszSkip` arg of database `Rewrite` func"
(https://github.com/bitcoin/bitcoin/pull/32990)
This argument might have been used in the legacy wallets, but I don't see any implementation using this argument in the SQLite wallets. Removing it cleans up the code a bit.
<!--
*** Please remove the following help text before submitting: ***
Pull requests without a rationale and clear improvement may be closed
immediately.
GUI-related pull requests should be opened against
https://github.com/bitcoin-core/gui
first. See CONTRIBUTING.md
-->
<!--
Please provide clear motivation
...
(https://github.com/bitcoin/bitcoin/pull/32990)
This argument might have been used in the legacy wallets, but I don't see any implementation using this argument in the SQLite wallets. Removing it cleans up the code a bit.
<!--
*** Please remove the following help text before submitting: ***
Pull requests without a rationale and clear improvement may be closed
immediately.
GUI-related pull requests should be opened against
https://github.com/bitcoin-core/gui
first. See CONTRIBUTING.md
-->
<!--
Please provide clear motivation
...
💬 rkrux commented on pull request "wallet: remove outdated `pszSkip` arg of database `Rewrite` func":
(https://github.com/bitcoin/bitcoin/pull/32990#issuecomment-3077678719)
I noted this while reviewing #28333.
(https://github.com/bitcoin/bitcoin/pull/32990#issuecomment-3077678719)
I noted this while reviewing #28333.
💬 fanquake commented on pull request "Migrate CI to hosted Cirrus Runners":
(https://github.com/bitcoin/bitcoin/pull/32989#discussion_r2209816654)
Can this be specific? I think either document the warning, or drop this comment, or just drop the workaround, if it's only a warning.
(https://github.com/bitcoin/bitcoin/pull/32989#discussion_r2209816654)
Can this be specific? I think either document the warning, or drop this comment, or just drop the workaround, if it's only a warning.
💬 fanquake commented on pull request "Migrate CI to hosted Cirrus Runners":
(https://github.com/bitcoin/bitcoin/pull/32989#discussion_r2209824251)
> and can help achieve
This is a bit vauge; have we seen this not work properly? It's also not completely clear to me that we need buildx to use the registry. Seems like it also works with buildkit, which is now just the default `docker build`, it any recent Docker version.
(https://github.com/bitcoin/bitcoin/pull/32989#discussion_r2209824251)
> and can help achieve
This is a bit vauge; have we seen this not work properly? It's also not completely clear to me that we need buildx to use the registry. Seems like it also works with buildkit, which is now just the default `docker build`, it any recent Docker version.
💬 fanquake commented on pull request "Migrate CI to hosted Cirrus Runners":
(https://github.com/bitcoin/bitcoin/pull/32989#issuecomment-3077789486)
Concept ACK. This will also need to go back to `27.x`.
(https://github.com/bitcoin/bitcoin/pull/32989#issuecomment-3077789486)
Concept ACK. This will also need to go back to `27.x`.
💬 fanquake commented on pull request "Migrate CI to hosted Cirrus Runners":
(https://github.com/bitcoin/bitcoin/pull/32989#discussion_r2209832345)
Wonder if we should just move this into the scripts, rather than set it here, so that it'll also be done for local usage.
(https://github.com/bitcoin/bitcoin/pull/32989#discussion_r2209832345)
Wonder if we should just move this into the scripts, rather than set it here, so that it'll also be done for local usage.
💬 josibake commented on pull request "Silent Payments: Implement BIP352":
(https://github.com/bitcoin/bitcoin/pull/28122#issuecomment-3077810296)
CI failure is due to the "test each commit" job not being able to handle a subtree merge commit. Ignoring for now; will look into fixing the CI job.
(https://github.com/bitcoin/bitcoin/pull/28122#issuecomment-3077810296)
CI failure is due to the "test each commit" job not being able to handle a subtree merge commit. Ignoring for now; will look into fixing the CI job.
💬 josibake commented on pull request "Silent Payments: sending":
(https://github.com/bitcoin/bitcoin/pull/28201#issuecomment-3077814381)
CI failure is from the test each commit job not handling a subtree pull; ignoring for now and will look into a CI fix later.
(https://github.com/bitcoin/bitcoin/pull/28201#issuecomment-3077814381)
CI failure is from the test each commit job not handling a subtree pull; ignoring for now and will look into a CI fix later.
✅ rkrux closed a pull request: "test: test that descriptorprocesspsbt removes non witness utxos in PSBT"
(https://github.com/bitcoin/bitcoin/pull/32413)
(https://github.com/bitcoin/bitcoin/pull/32413)