💬 maflcko commented on pull request "wallet, rpc: add v3 transaction creation and wallet support":
(https://github.com/bitcoin/bitcoin/pull/32896#discussion_r2208017260)
```suggestion
CMutableTransaction rawTx = ConstructTransaction(request.params[0], request.params[1], request.params[2], rbf, self.Arg<uint32_t>("version"));
```
nit: This should allow to drop the parsing in `ConstructTransaction` and the manual indexing here.
(https://github.com/bitcoin/bitcoin/pull/32896#discussion_r2208017260)
```suggestion
CMutableTransaction rawTx = ConstructTransaction(request.params[0], request.params[1], request.params[2], rbf, self.Arg<uint32_t>("version"));
```
nit: This should allow to drop the parsing in `ConstructTransaction` and the manual indexing here.
💬 1440000bytes commented on pull request "Reduce minrelaytxfee to 100 sats/kvB":
(https://github.com/bitcoin/bitcoin/pull/32959#issuecomment-3074405875)
Bitcoin Core
Nobody cares... We have better things.
(https://github.com/bitcoin/bitcoin/pull/32959#issuecomment-3074405875)
Bitcoin Core
Nobody cares... We have better things.
💬 1440000bytes commented on pull request "Reduce minrelaytxfee to 100 sats/kvB":
(https://github.com/bitcoin/bitcoin/pull/32959#issuecomment-3074407862)
I dont need drama
(https://github.com/bitcoin/bitcoin/pull/32959#issuecomment-3074407862)
I dont need drama
✅ fanquake closed an issue: "ci: Use previous releases in tests on Windows"
(https://github.com/bitcoin/bitcoin/issues/32192)
(https://github.com/bitcoin/bitcoin/issues/32192)
💬 fanquake commented on issue "ci: Use previous releases in tests on Windows":
(https://github.com/bitcoin/bitcoin/issues/32192#issuecomment-3074416760)
Fixed by #32219.
(https://github.com/bitcoin/bitcoin/issues/32192#issuecomment-3074416760)
Fixed by #32219.
✅ fanquake closed an issue: "test: bip324_tests & net_tests failure with `-O3 -flto`"
(https://github.com/bitcoin/bitcoin/issues/32337)
(https://github.com/bitcoin/bitcoin/issues/32337)
💬 fanquake commented on issue "test: bip324_tests & net_tests failure with `-O3 -flto`":
(https://github.com/bitcoin/bitcoin/issues/32337#issuecomment-3074432903)
Closing for now, as I can no-longer recreate this, with Alpine 3.22.1, GCC 14.2.0, ld 2.44.
(https://github.com/bitcoin/bitcoin/issues/32337#issuecomment-3074432903)
Closing for now, as I can no-longer recreate this, with Alpine 3.22.1, GCC 14.2.0, ld 2.44.
✅ fanquake closed an issue: "Ability to build the library"
(https://github.com/bitcoin/bitcoin/issues/31964)
(https://github.com/bitcoin/bitcoin/issues/31964)
💬 fanquake commented on issue "Ability to build the library":
(https://github.com/bitcoin/bitcoin/issues/31964#issuecomment-3074441382)
Closing this in favour of #27587 & #30595. Those are the threads to follow for progress on this.
(https://github.com/bitcoin/bitcoin/issues/31964#issuecomment-3074441382)
Closing this in favour of #27587 & #30595. Those are the threads to follow for progress on this.
💬 fanquake commented on issue "Avoid plural forms in non-GUI translatable strings (lacks `%n` support)":
(https://github.com/bitcoin/bitcoin/issues/31890#issuecomment-3074461493)
Was there any followup here?
(https://github.com/bitcoin/bitcoin/issues/31890#issuecomment-3074461493)
Was there any followup here?
💬 sipa commented on pull request "cluster mempool: add TxGraph work controls":
(https://github.com/bitcoin/bitcoin/pull/32263#discussion_r2208070567)
Indeed. With a PostLinearize() added, I think we can even go to 3, but that seems like only a very marginal benefit anyway, and be much less obvious.
(https://github.com/bitcoin/bitcoin/pull/32263#discussion_r2208070567)
Indeed. With a PostLinearize() added, I think we can even go to 3, but that seems like only a very marginal benefit anyway, and be much less obvious.
📝 Sazwan96 opened a pull request: "Bitcoin.png"
(https://github.com/bitcoin/bitcoin/pull/32980)
<!--
*** Please remove the following help text before submitting: ***
Pull requests without a rationale and clear improvement may be closed
immediately.
GUI-related pull requests should be opened against
https://github.com/bitcoin-core/gui
first. See CONTRIBUTING.md
-->
<!--
Please provide clear motivation for your patch and explain how it improves
Bitcoin Core user experience or Bitcoin Core developer experience
significantly:
* Any test improvements or new tests that improv
...
(https://github.com/bitcoin/bitcoin/pull/32980)
<!--
*** Please remove the following help text before submitting: ***
Pull requests without a rationale and clear improvement may be closed
immediately.
GUI-related pull requests should be opened against
https://github.com/bitcoin-core/gui
first. See CONTRIBUTING.md
-->
<!--
Please provide clear motivation for your patch and explain how it improves
Bitcoin Core user experience or Bitcoin Core developer experience
significantly:
* Any test improvements or new tests that improv
...
💬 sipa commented on pull request "cluster mempool: add TxGraph work controls":
(https://github.com/bitcoin/bitcoin/pull/32263#issuecomment-3074471173)
Will address the outstanding comments if I touch up.
(https://github.com/bitcoin/bitcoin/pull/32263#issuecomment-3074471173)
Will address the outstanding comments if I touch up.
✅ fanquake closed a pull request: "Bitcoin.png"
(https://github.com/bitcoin/bitcoin/pull/32980)
(https://github.com/bitcoin/bitcoin/pull/32980)
📝 Sazwan96 opened a pull request: "Bitcoin Core"
(https://github.com/bitcoin/bitcoin/pull/32981)
<!--
*** Please remove the following help text before submitting: ***
Pull requests without a rationale and clear improvement may be closed
immediately.
GUI-related pull requests should be opened against
https://github.com/bitcoin-core/gui
first. See CONTRIBUTING.md
-->
<!--
Please provide clear motivation for your patch and explain how it improves
Bitcoin Core user experience or Bitcoin Core developer experience
significantly:
* Any test improvements or new tests that improv
...
(https://github.com/bitcoin/bitcoin/pull/32981)
<!--
*** Please remove the following help text before submitting: ***
Pull requests without a rationale and clear improvement may be closed
immediately.
GUI-related pull requests should be opened against
https://github.com/bitcoin-core/gui
first. See CONTRIBUTING.md
-->
<!--
Please provide clear motivation for your patch and explain how it improves
Bitcoin Core user experience or Bitcoin Core developer experience
significantly:
* Any test improvements or new tests that improv
...
💬 Sazwan96 commented on pull request "Bitcoin Core":
(https://github.com/bitcoin/bitcoin/pull/32981#issuecomment-3074498291)
Helo
(https://github.com/bitcoin/bitcoin/pull/32981#issuecomment-3074498291)
Helo
✅ pinheadmz closed a pull request: "Bitcoin Core"
(https://github.com/bitcoin/bitcoin/pull/32981)
(https://github.com/bitcoin/bitcoin/pull/32981)
💬 RobinLinus commented on pull request "Reduce minrelaytxfee to 100 sats/kvB":
(https://github.com/bitcoin/bitcoin/pull/32959#issuecomment-3074619747)
> DUST_RELAY_TX_FEE should be decreased along with this as well...
DEFAULT_MIN_RELAY_TX_FEE and DUST_RELAY_TX_FEE serve different purposes. The former is about protecting the P2P network, while the latter also aims at protecting the UTXO set from DoS attacks. Given that half of the UTXO set is spam these days, it seems like the dust limit should rather get _increased_ than decreased. So it's a whole different discussion, and I would not want to conflate these two in this PR.
(https://github.com/bitcoin/bitcoin/pull/32959#issuecomment-3074619747)
> DUST_RELAY_TX_FEE should be decreased along with this as well...
DEFAULT_MIN_RELAY_TX_FEE and DUST_RELAY_TX_FEE serve different purposes. The former is about protecting the P2P network, while the latter also aims at protecting the UTXO set from DoS attacks. Given that half of the UTXO set is spam these days, it seems like the dust limit should rather get _increased_ than decreased. So it's a whole different discussion, and I would not want to conflate these two in this PR.
💬 pinheadmz commented on pull request "bitcoin-cli: Add -ipcconnect option":
(https://github.com/bitcoin/bitcoin/pull/32297#issuecomment-3074628613)
I got some crashes testing 37cd2c076434e7acbdbb20996cf87afb2cb5bc84 on macos/arm64. This is on a pruned mainnet node catching up on about 30 days behind blockchain tip. After these two crashes I wasn't able to reproduce any more for a little while after a few restarts then got the third crash.
**server:** `build/bin/bitcoin-node -server=1 -printtoconsole=1 -ipcbind=unix -debug=ipc -debug=rpc -debug=http`
**client:** `build/bin/bitcoin-cli -getinfo`
**server:**
```
2025-07-15T17:16:16Z
...
(https://github.com/bitcoin/bitcoin/pull/32297#issuecomment-3074628613)
I got some crashes testing 37cd2c076434e7acbdbb20996cf87afb2cb5bc84 on macos/arm64. This is on a pruned mainnet node catching up on about 30 days behind blockchain tip. After these two crashes I wasn't able to reproduce any more for a little while after a few restarts then got the third crash.
**server:** `build/bin/bitcoin-node -server=1 -printtoconsole=1 -ipcbind=unix -debug=ipc -debug=rpc -debug=http`
**client:** `build/bin/bitcoin-cli -getinfo`
**server:**
```
2025-07-15T17:16:16Z
...
💬 w0xlt commented on pull request "wallet: Remove `CWallet::nWalletVersion` and several related functions":
(https://github.com/bitcoin/bitcoin/pull/32977#discussion_r2208180280)
Done in https://github.com/bitcoin/bitcoin/pull/32977/commits/fc4d563edb5feab273e5770f1b369cb6fe8a0c8c
(https://github.com/bitcoin/bitcoin/pull/32977#discussion_r2208180280)
Done in https://github.com/bitcoin/bitcoin/pull/32977/commits/fc4d563edb5feab273e5770f1b369cb6fe8a0c8c