Bitcoin Core Github
44 subscribers
120K links
Download Telegram
💬 fanquake commented on issue "[BTC signet v22.0] websocket not working as expect":
(https://github.com/bitcoin/bitcoin/issues/32848#issuecomment-3074364853)
Closing for now. Feel free to reopen, with all the required details and steps to reproduce.
💬 maflcko commented on pull request "fix: Python 3 bytes comparison in linearize-data.py":
(https://github.com/bitcoin/bitcoin/pull/32978#issuecomment-3074369242)
Are there steps to reproduce, or a test to confirm the fix?
💬 instagibbs commented on pull request "p2p: improve TxOrphanage denial of service bounds":
(https://github.com/bitcoin/bitcoin/pull/31829#issuecomment-3074385460)
Looking at logs, was wondering if we can get some more information about which peer/ which tx is being evicted from the orphanage? I'm eyeballing some logs since I've been running variants of this for a few weeks now, and the `orphanage overflow` string shows up significantly more often due to the non-timeout of announcements after this PR.

e.g.: "2025-07-07T11:27:34.481530Z [txpackages] orphanage overflow, removed 1 tx (4 announcements)"

Being able to quickly see that, f.e., the only reas
...
💬 maflcko commented on pull request "wallet, rpc: add v3 transaction creation and wallet support":
(https://github.com/bitcoin/bitcoin/pull/32896#discussion_r2208017260)
```suggestion
CMutableTransaction rawTx = ConstructTransaction(request.params[0], request.params[1], request.params[2], rbf, self.Arg<uint32_t>("version"));
```

nit: This should allow to drop the parsing in `ConstructTransaction` and the manual indexing here.
💬 1440000bytes commented on pull request "Reduce minrelaytxfee to 100 sats/kvB":
(https://github.com/bitcoin/bitcoin/pull/32959#issuecomment-3074405875)
Bitcoin Core

Nobody cares... We have better things.
💬 1440000bytes commented on pull request "Reduce minrelaytxfee to 100 sats/kvB":
(https://github.com/bitcoin/bitcoin/pull/32959#issuecomment-3074407862)
I dont need drama
fanquake closed an issue: "ci: Use previous releases in tests on Windows"
(https://github.com/bitcoin/bitcoin/issues/32192)
💬 fanquake commented on issue "ci: Use previous releases in tests on Windows":
(https://github.com/bitcoin/bitcoin/issues/32192#issuecomment-3074416760)
Fixed by #32219.
fanquake closed an issue: "test: bip324_tests & net_tests failure with `-O3 -flto`"
(https://github.com/bitcoin/bitcoin/issues/32337)
💬 fanquake commented on issue "test: bip324_tests & net_tests failure with `-O3 -flto`":
(https://github.com/bitcoin/bitcoin/issues/32337#issuecomment-3074432903)
Closing for now, as I can no-longer recreate this, with Alpine 3.22.1, GCC 14.2.0, ld 2.44.
fanquake closed an issue: "Ability to build the library"
(https://github.com/bitcoin/bitcoin/issues/31964)
💬 fanquake commented on issue "Ability to build the library":
(https://github.com/bitcoin/bitcoin/issues/31964#issuecomment-3074441382)
Closing this in favour of #27587 & #30595. Those are the threads to follow for progress on this.
💬 fanquake commented on issue "Avoid plural forms in non-GUI translatable strings (lacks `%n` support)":
(https://github.com/bitcoin/bitcoin/issues/31890#issuecomment-3074461493)
Was there any followup here?
💬 sipa commented on pull request "cluster mempool: add TxGraph work controls":
(https://github.com/bitcoin/bitcoin/pull/32263#discussion_r2208070567)
Indeed. With a PostLinearize() added, I think we can even go to 3, but that seems like only a very marginal benefit anyway, and be much less obvious.
📝 Sazwan96 opened a pull request: "Bitcoin.png"
(https://github.com/bitcoin/bitcoin/pull/32980)
<!--
*** Please remove the following help text before submitting: ***

Pull requests without a rationale and clear improvement may be closed
immediately.

GUI-related pull requests should be opened against
https://github.com/bitcoin-core/gui
first. See CONTRIBUTING.md
-->

<!--
Please provide clear motivation for your patch and explain how it improves
Bitcoin Core user experience or Bitcoin Core developer experience
significantly:

* Any test improvements or new tests that improv
...
💬 sipa commented on pull request "cluster mempool: add TxGraph work controls":
(https://github.com/bitcoin/bitcoin/pull/32263#issuecomment-3074471173)
Will address the outstanding comments if I touch up.
fanquake closed a pull request: "Bitcoin.png"
(https://github.com/bitcoin/bitcoin/pull/32980)
📝 Sazwan96 opened a pull request: "Bitcoin Core"
(https://github.com/bitcoin/bitcoin/pull/32981)
<!--
*** Please remove the following help text before submitting: ***

Pull requests without a rationale and clear improvement may be closed
immediately.

GUI-related pull requests should be opened against
https://github.com/bitcoin-core/gui
first. See CONTRIBUTING.md
-->

<!--
Please provide clear motivation for your patch and explain how it improves
Bitcoin Core user experience or Bitcoin Core developer experience
significantly:

* Any test improvements or new tests that improv
...
💬 Sazwan96 commented on pull request "Bitcoin Core":
(https://github.com/bitcoin/bitcoin/pull/32981#issuecomment-3074498291)
Helo
pinheadmz closed a pull request: "Bitcoin Core"
(https://github.com/bitcoin/bitcoin/pull/32981)